github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3962] [MERGED] Fix mobile navigation tabs disappearing on top bounce #5135

New Issue
Closed
opened 2026-02-28 21:06:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:06:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3962
Author: @mbaeuerle
Created: 12/11/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @joel-jeremy

Base: master ← Head: fix-mobile-nav-tabs-bounce

📝 Commits (1)

  • beefae3 Fix iOS mobile navigation tabs disappearing on bouncing top

📊 Changes

2 files changed (+9 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/MobileNavTabs.tsx (+3 -3)
➕ upcoming-release-notes/3962.md (+6 -0)

📄 Description

The mobile navigation tabs are hidden whenever you scroll down, they reappear when scrolling up. This is intended behavior.
On a bounce at the top however they disappear erroneously. I guess due to the bounce which scrolls slightly back down.
The same appears at the bottom where a bounce back up makes the tabs reappear.

This only seems to be an issue on iOS. Could not test it on Android due to not owning a device. But I could not detect this behavior in Firefox with small viewport.

This solution prevents the hiding / opening of the nav tabs by checking if it's at the top / bottom.

Issue at the top:
bug

Issue at the bottom:
bug2

Fixed:
fixed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3962 **Author:** [@mbaeuerle](https://github.com/mbaeuerle) **Created:** 12/11/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `fix-mobile-nav-tabs-bounce` --- ### 📝 Commits (1) - [`beefae3`](https://github.com/actualbudget/actual/commit/beefae347150be26864c760e09728c741491e254) Fix iOS mobile navigation tabs disappearing on bouncing top ### 📊 Changes **2 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/MobileNavTabs.tsx` (+3 -3) ➕ `upcoming-release-notes/3962.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> The mobile navigation tabs are hidden whenever you scroll down, they reappear when scrolling up. This is intended behavior. On a bounce at the top however they disappear erroneously. I guess due to the bounce which scrolls slightly back down. The same appears at the bottom where a bounce back up makes the tabs reappear. This only seems to be an issue on iOS. Could not test it on Android due to not owning a device. But I could not detect this behavior in Firefox with small viewport. This solution prevents the hiding / opening of the nav tabs by checking if it's at the top / bottom. Issue at the top: ![bug](https://github.com/user-attachments/assets/167a320a-947e-4c6f-918e-99f24affd73c) Issue at the bottom: ![bug2](https://github.com/user-attachments/assets/21a585e2-20cf-46c0-8634-a8223bfb4f24) Fixed: ![fixed](https://github.com/user-attachments/assets/5d179fed-6542-4d32-98ef-5eee1351c725) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:06:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5135
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?