github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4446] [MERGED] ✨ New OpenID first login UX #5386

New Issue
Closed
opened 2026-02-28 21:11:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:11:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4446
Author: @lelemm
Created: 2/24/2025
Status: ✅ Merged
Merged: 4/8/2025
Merged by: @lelemm

Base: master ← Head: bugfix/review_openid_parameters

📝 Commits (10+)

  • 39fe0cf Fix for openid review parameters
  • 788a572 Refactor and bug fix of OpenId parameters on first login
  • 71899a9 md
  • 4918a85 change some design
  • 6f5585e adjustments
  • 36c3f42 responsive login
  • adf3b1f Merge branch 'master' into bugfix/review_openid_parameters
  • f28b221 linter
  • 34345ea removed debugger
  • 81611e2 Merge branch 'master' into bugfix/review_openid_parameters

📊 Changes

11 files changed (+277 additions, -102 deletions)

View changed files

📝 packages/component-library/src/Input.tsx (+8 -1)
📝 packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.tsx (+6 -1)
📝 packages/desktop-client/src/components/manager/subscribe/Login.tsx (+155 -53)
📝 packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx (+17 -37)
📝 packages/loot-core/src/server/main.ts (+29 -5)
📝 packages/loot-core/src/types/server-handlers.d.ts (+1 -1)
📝 packages/sync-server/src/accounts/openid.js (+19 -1)
📝 packages/sync-server/src/accounts/password.js (+24 -0)
📝 packages/sync-server/src/app-account.js (+4 -1)
📝 packages/sync-server/src/app-openid.js (+8 -2)
➕ upcoming-release-notes/4446.md (+6 -0)

📄 Description

Changed the first login with OpenID UX:

  • Password validation so the user can only review the openid (on first login) if it has the credentials for it
  • Password validation for the first user login with openid to eliminate racing condition of the first user

Steps to test this.

  • Clone my branch
  • run yarn
  • run rm -rf packages/sync-server/server-files to delete all server files
  • run rm packages/sync-server/.migrate to delete old migrations
  • run yarn start:server-dev
  • Open localhost:5006
  • Enable feature flag for OpenID
  • Enable OpenId (to make easier to test, use passwordless.id provider)
  • Ctrl+f5 to ensure that you don't have the frontend cached
  • Test this new form.
    • You should only be able to review openid configurations using the server password (avoiding bad actors)
    • You should only be able to login as first user after inserting the server password (avoiding bad actors)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4446 **Author:** [@lelemm](https://github.com/lelemm) **Created:** 2/24/2025 **Status:** ✅ Merged **Merged:** 4/8/2025 **Merged by:** [@lelemm](https://github.com/lelemm) **Base:** `master` ← **Head:** `bugfix/review_openid_parameters` --- ### 📝 Commits (10+) - [`39fe0cf`](https://github.com/actualbudget/actual/commit/39fe0cf47d30eb560e8152bad166afabdb6a8c18) Fix for openid review parameters - [`788a572`](https://github.com/actualbudget/actual/commit/788a572f84239d18cb5413b43876bea556d7cf2f) Refactor and bug fix of OpenId parameters on first login - [`71899a9`](https://github.com/actualbudget/actual/commit/71899a9925ac38c2c3ff765975c57a1fb9217a87) md - [`4918a85`](https://github.com/actualbudget/actual/commit/4918a85489a3643c56fa2d20a578af5625aa6425) change some design - [`6f5585e`](https://github.com/actualbudget/actual/commit/6f5585ec043f0107d44b9022bf7973275f94fd8c) adjustments - [`36c3f42`](https://github.com/actualbudget/actual/commit/36c3f424ceced3bf4e47843f7c2516a07dd7c6ee) responsive login - [`adf3b1f`](https://github.com/actualbudget/actual/commit/adf3b1f64d7dda20f8ef0c0279a1370f5dbb1d17) Merge branch 'master' into bugfix/review_openid_parameters - [`f28b221`](https://github.com/actualbudget/actual/commit/f28b2216bcf79c561f04358c31abc17a0cb942c0) linter - [`34345ea`](https://github.com/actualbudget/actual/commit/34345eae274009f004b079efd7eee93abf8ee053) removed debugger - [`81611e2`](https://github.com/actualbudget/actual/commit/81611e2c178536ee63beb74f2a9500dff198cfeb) Merge branch 'master' into bugfix/review_openid_parameters ### 📊 Changes **11 files changed** (+277 additions, -102 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/src/Input.tsx` (+8 -1) 📝 `packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/manager/subscribe/Login.tsx` (+155 -53) 📝 `packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx` (+17 -37) 📝 `packages/loot-core/src/server/main.ts` (+29 -5) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+1 -1) 📝 `packages/sync-server/src/accounts/openid.js` (+19 -1) 📝 `packages/sync-server/src/accounts/password.js` (+24 -0) 📝 `packages/sync-server/src/app-account.js` (+4 -1) 📝 `packages/sync-server/src/app-openid.js` (+8 -2) ➕ `upcoming-release-notes/4446.md` (+6 -0) </details> ### 📄 Description Changed the first login with OpenID UX: - Password validation so the user can only review the openid (on first login) if it has the credentials for it - Password validation for the first user login with openid to eliminate racing condition of the first user Steps to test this. - Clone my branch - run `yarn` - run `rm -rf packages/sync-server/server-files` to delete all server files - run `rm packages/sync-server/.migrate` to delete old migrations - run `yarn start:server-dev` - Open localhost:5006 - Enable feature flag for OpenID - Enable OpenId (to make easier to test, use `passwordless.id` provider) - Ctrl+f5 to ensure that you don't have the frontend cached - Test this new form. - You should only be able to review openid configurations using the server password (avoiding bad actors) - You should only be able to login as first user after inserting the server password (avoiding bad actors) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:11:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?