github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5392] [MERGED] Fix undefined points error in contributor points #5912

New Issue
Closed
opened 2026-02-28 21:20:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:20:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5392
Author: @MatissJanis
Created: 7/25/2025
Status: ✅ Merged
Merged: 7/25/2025
Merged by: @MatissJanis

Base: master ← Head: cursor/fix-undefined-points-error-in-contributor-points-9bfa

📝 Commits (3)

  • 4cb5e16 Fix potential null reference errors in point counting script
  • 07a9e40 Changes from background agent bc-0fa87c24-91ba-420b-9bdf-faeaa2f7c6de
  • 4533491 Rename 5393.md to 5392.md

📊 Changes

2 files changed (+14 additions, -4 deletions)

View changed files

📝 .github/scripts/count-points.mjs (+8 -4)
➕ upcoming-release-notes/5392.md (+6 -0)

📄 Description

Failing CI job: https://github.com/actualbudget/actual/actions/runs/16526264065/job/46740250320

Fix: Prevent TypeError: Cannot read properties of undefined (reading 'points') in count-points.mjs

This error occurred when non-organization members performed actions (like removing "needs triage" labels or closing issues). The script attempted to access userStats.points for these users, but stats.get(login) returned undefined for non-members, causing the crash.

This PR adds null checks (if (userStats)) before attempting to update user statistics, ensuring that points are only processed for recognized organization members and gracefully ignoring actions by non-members without error.

Open in Web • Open in Cursor

Learn more about Background Agents

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5392 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 7/25/2025 **Status:** ✅ Merged **Merged:** 7/25/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/fix-undefined-points-error-in-contributor-points-9bfa` --- ### 📝 Commits (3) - [`4cb5e16`](https://github.com/actualbudget/actual/commit/4cb5e16b9c331aca4e4313607d327c640ce966c0) Fix potential null reference errors in point counting script - [`07a9e40`](https://github.com/actualbudget/actual/commit/07a9e408d9aa733c2f6601179bf463e2aefe87be) Changes from background agent bc-0fa87c24-91ba-420b-9bdf-faeaa2f7c6de - [`4533491`](https://github.com/actualbudget/actual/commit/453349131397e5607d792c1ca95e722b81e6a1df) Rename 5393.md to 5392.md ### 📊 Changes **2 files changed** (+14 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/scripts/count-points.mjs` (+8 -4) ➕ `upcoming-release-notes/5392.md` (+6 -0) </details> ### 📄 Description Failing CI job: https://github.com/actualbudget/actual/actions/runs/16526264065/job/46740250320 Fix: Prevent `TypeError: Cannot read properties of undefined (reading 'points')` in `count-points.mjs` This error occurred when non-organization members performed actions (like removing "needs triage" labels or closing issues). The script attempted to access `userStats.points` for these users, but `stats.get(login)` returned `undefined` for non-members, causing the crash. This PR adds null checks (`if (userStats)`) before attempting to update user statistics, ensuring that points are only processed for recognized organization members and gracefully ignoring actions by non-members without error. --- [Open in Web](https://cursor.com/agents?id=bc-0fa87c24-91ba-420b-9bdf-faeaa2f7c6de) • [Open in Cursor](https://cursor.com/background-agent?bcId=bc-0fa87c24-91ba-420b-9bdf-faeaa2f7c6de) Learn more about [Background Agents](https://docs.cursor.com/background-agent/web-and-mobile) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:20:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5912
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?