github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3393] [MERGED] 🔧 Prevent sidebar from saving to metadata until resize is complete #4827

New Issue
Closed
opened 2026-02-28 21:01:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:01:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3393
Author: @MikesGlitch
Created: 9/8/2024
Status: ✅ Merged
Merged: 9/8/2024
Merged by: @MikesGlitch

Base: master ← Head: fix/reducing-no-of-calls-to-save-metadata.json

📝 Commits (2)

  • 102b11d prevent sidebar from saving to metadata until resize is complete
  • 44712a2 add release notes

📊 Changes

2 files changed (+22 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/sidebar/Sidebar.tsx (+16 -4)
➕ upcoming-release-notes/3393.md (+6 -0)

📄 Description

The sidebar is saving to metadata.json every time the window is resized and on every movement while being dragged.
Recording 2024-09-08 at 10 27 32

This fix makes it save when the drag has ended.

I looked into this due to this bug: https://github.com/actualbudget/actual/issues/3390 . I'm doubtful that it will fix it, but it's the only thing I can see that's saving to metadata.json a lot.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3393 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 9/8/2024 **Status:** ✅ Merged **Merged:** 9/8/2024 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `fix/reducing-no-of-calls-to-save-metadata.json` --- ### 📝 Commits (2) - [`102b11d`](https://github.com/actualbudget/actual/commit/102b11de0202fdf5c81f1196c08238e454b28472) prevent sidebar from saving to metadata until resize is complete - [`44712a2`](https://github.com/actualbudget/actual/commit/44712a275c03855fb2f9ef1968525922a1984b41) add release notes ### 📊 Changes **2 files changed** (+22 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/sidebar/Sidebar.tsx` (+16 -4) ➕ `upcoming-release-notes/3393.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> The sidebar is saving to metadata.json every time the window is resized and on every movement while being dragged. ![Recording 2024-09-08 at 10 27 32](https://github.com/user-attachments/assets/fd38b999-14be-4aaa-80f6-64d816ea06ba) This fix makes it save when the drag has ended. I looked into this due to this bug: https://github.com/actualbudget/actual/issues/3390 . I'm doubtful that it will fix it, but it's the only thing I can see that's saving to metadata.json a lot. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:01:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4827
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?