mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-11 12:43:09 -05:00
Remove height transition animation from modals when adjusting to viewport height for smoother experience (#4620)
* Use dvh to determine height of modal based on dynamic visual viewport * Apply to dialog instead of another div * Remove modal transition * Release notes
This commit is contained in:
committed by
GitHub
parent
606e39252f
commit
d16d022b50
@@ -96,14 +96,13 @@ export const Modal = ({
|
||||
{...props}
|
||||
>
|
||||
{/* A container for positioning the modal relative to the visual viewport */}
|
||||
<div
|
||||
<View
|
||||
style={{
|
||||
display: 'flex',
|
||||
alignItems: 'center',
|
||||
justifyContent: 'center',
|
||||
height: 'var(--visual-viewport-height)',
|
||||
overflowY: 'auto',
|
||||
transition: 'height .25s',
|
||||
}}
|
||||
>
|
||||
<ReactAriaModal>
|
||||
@@ -169,7 +168,7 @@ export const Modal = ({
|
||||
</Dialog>
|
||||
)}
|
||||
</ReactAriaModal>
|
||||
</div>
|
||||
</View>
|
||||
</ReactAriaModalOverlay>
|
||||
);
|
||||
};
|
||||
|
||||
6
upcoming-release-notes/4620.md
Normal file
6
upcoming-release-notes/4620.md
Normal file
@@ -0,0 +1,6 @@
|
||||
---
|
||||
category: Enhancements
|
||||
authors: [joel-jeremy]
|
||||
---
|
||||
|
||||
Remove height transition animation from modals when adjusting to viewport height for smoother experience.
|
||||
Reference in New Issue
Block a user