github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4428] [MERGED] 🔨 OPENID: Refactor mixed stuff #5379

New Issue
Closed
opened 2026-02-28 21:11:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:11:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4428
Author: @lelemm
Created: 2/21/2025
Status: ✅ Merged
Merged: 3/14/2025
Merged by: @lelemm

Base: master ← Head: enhance/openid_variables_refactor

📝 Commits (6)

  • 7a81bee Refactor
  • 05af489 changed the variable name back to loginMethod
  • fd0ad1e md
  • f0a5fd0 Update packages/sync-server/src/app.js
  • 152c800 Merge remote-tracking branch 'org/master' into enhance/openid_variables_refactor
  • 515b35a merge

📊 Changes

5 files changed (+32 additions, -8 deletions)

View changed files

📝 packages/sync-server/package.json (+0 -1)
📝 packages/sync-server/src/account-db.js (+10 -6)
📝 packages/sync-server/src/app.js (+15 -0)
📝 packages/sync-server/src/config-types.ts (+1 -1)
➕ upcoming-release-notes/4428.md (+6 -0)

📄 Description

Removed variable MULTIUSER because it was not being used anymore

Changed how the sync server utilizes the OpenID env vars (and config.json):

  • Now when the variable is present, at startup it tries to configure OpenId with these values
  • This was a user feedback

Removed the command yarn enable-openid because its deprecated on this new model

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4428 **Author:** [@lelemm](https://github.com/lelemm) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 3/14/2025 **Merged by:** [@lelemm](https://github.com/lelemm) **Base:** `master` ← **Head:** `enhance/openid_variables_refactor` --- ### 📝 Commits (6) - [`7a81bee`](https://github.com/actualbudget/actual/commit/7a81bee6a2685b05bdb9f9e62bcec9b3f2d40906) Refactor - [`05af489`](https://github.com/actualbudget/actual/commit/05af4894c1afea694ebbafe8edacfe1ee3412df5) changed the variable name back to loginMethod - [`fd0ad1e`](https://github.com/actualbudget/actual/commit/fd0ad1e53d88df457fb13169b0407dd3bb86bd4f) md - [`f0a5fd0`](https://github.com/actualbudget/actual/commit/f0a5fd08d288abd95a3650840f5b8509df9fefc2) Update packages/sync-server/src/app.js - [`152c800`](https://github.com/actualbudget/actual/commit/152c8000e6b4414a19c681f5ac09f1e2523f70dc) Merge remote-tracking branch 'org/master' into enhance/openid_variables_refactor - [`515b35a`](https://github.com/actualbudget/actual/commit/515b35a2c9710383799ba838cc574573a33fa3dd) merge ### 📊 Changes **5 files changed** (+32 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/package.json` (+0 -1) 📝 `packages/sync-server/src/account-db.js` (+10 -6) 📝 `packages/sync-server/src/app.js` (+15 -0) 📝 `packages/sync-server/src/config-types.ts` (+1 -1) ➕ `upcoming-release-notes/4428.md` (+6 -0) </details> ### 📄 Description #### Removed variable `MULTIUSER` because it was not being used anymore #### Changed how the sync server utilizes the OpenID env vars (and config.json): - Now when the variable is present, at startup it tries to configure OpenId with these values - This was a user feedback #### Removed the command `yarn enable-openid` because its deprecated on this new model --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:11:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5379
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?