github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4566] [MERGED] ♻️ (components) remove InputWithContent component #5457

New Issue
Closed
opened 2026-02-28 21:12:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:12:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4566
Author: @MatissJanis
Created: 3/7/2025
Status: ✅ Merged
Merged: 3/10/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/input-with-content

📝 Commits (8)

  • 85ac7ee ♻️ (components) remove InputWithContent component
  • 1dc1b9d Update VRT
  • 8a5b734 Merge branch 'master' into matiss/input-with-content
  • 2928b39 Merge branch 'master' into matiss/input-with-content
  • f355d8f Increase click target for mobile
  • fe0271f Patch linter
  • 84f24c5 Update VRT
  • e4e479c Trigger Actions

📊 Changes

7 files changed (+172 additions, -187 deletions)

View changed files

📝 packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-9-chromium-linux.png (+0 -0)
➖ packages/desktop-client/src/components/common/InputWithContent.tsx (+0 -69)
📝 packages/desktop-client/src/components/common/Search.tsx (+92 -61)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionListWithBalances.tsx (+8 -21)
📝 packages/desktop-client/src/components/util/AmountInput.tsx (+66 -36)
➕ upcoming-release-notes/4566.md (+6 -0)

📄 Description

inlining some of its functionality in the consumers instead. This allows us to reduce the footprint of stuff we will need to include in the component library.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4566 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/7/2025 **Status:** ✅ Merged **Merged:** 3/10/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/input-with-content` --- ### 📝 Commits (8) - [`85ac7ee`](https://github.com/actualbudget/actual/commit/85ac7eea4aea201d64bf77081de65ba57e83a2ea) :recycle: (components) remove InputWithContent component - [`1dc1b9d`](https://github.com/actualbudget/actual/commit/1dc1b9d733ca265b14c88c0b3b0fd7528ef11b35) Update VRT - [`8a5b734`](https://github.com/actualbudget/actual/commit/8a5b734837117605e2596573c2a0da234d77962a) Merge branch 'master' into matiss/input-with-content - [`2928b39`](https://github.com/actualbudget/actual/commit/2928b392ff95aff8b073e01f462b579f9aa96e03) Merge branch 'master' into matiss/input-with-content - [`f355d8f`](https://github.com/actualbudget/actual/commit/f355d8f202cde888847a3cb41a91ea1984a28cec) Increase click target for mobile - [`fe0271f`](https://github.com/actualbudget/actual/commit/fe0271fc1efb23fb4b331f9c31aa5c7057ba40a3) Patch linter - [`84f24c5`](https://github.com/actualbudget/actual/commit/84f24c5c0d3823efdeffc2aa0c67b5c8271336a9) Update VRT - [`e4e479c`](https://github.com/actualbudget/actual/commit/e4e479c08ac67db7df72adde781e16450c4a8cd3) Trigger Actions ### 📊 Changes **7 files changed** (+172 additions, -187 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-9-chromium-linux.png` (+0 -0) ➖ `packages/desktop-client/src/components/common/InputWithContent.tsx` (+0 -69) 📝 `packages/desktop-client/src/components/common/Search.tsx` (+92 -61) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionListWithBalances.tsx` (+8 -21) 📝 `packages/desktop-client/src/components/util/AmountInput.tsx` (+66 -36) ➕ `upcoming-release-notes/4566.md` (+6 -0) </details> ### 📄 Description inlining some of its functionality in the consumers instead. This allows us to reduce the footprint of stuff we will need to include in the component library. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:12:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5457
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?