github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3553] [MERGED] :electron: Reduce electron package size #4923

New Issue
Closed
opened 2026-02-28 21:03:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:03:17 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3553
Author: @MikesGlitch
Created: 10/3/2024
Status: ✅ Merged
Merged: 10/4/2024
Merged by: @MikesGlitch

Base: master ← Head: electron/cleanup-package

📝 Commits (7)

📊 Changes

8 files changed (+42 additions, -35 deletions)

View changed files

📝 packages/desktop-electron/bin/update-client (+8 -0)
📝 packages/desktop-electron/index.ts (+6 -3)
📝 packages/desktop-electron/modules.d.ts (+0 -6)
📝 packages/desktop-electron/package.json (+3 -6)
📝 packages/desktop-electron/server.ts (+7 -6)
📝 packages/desktop-electron/window-state.ts (+10 -12)
➕ upcoming-release-notes/3553.md (+6 -0)
📝 yarn.lock (+2 -2)

📄 Description

We currently include all of loot-core's dependencies in the electron app. This may have been the root cause of the better-sqlite x64/arm64 issues we had a while ago. We don't need to include these modules because we bundle loot-core into bundle.desktop.js.

This change makes it much easier to see what the Electron app really depends on.

Difference in size:

Old :
image

New:
image

Tested on:

  • Windows
  • Linux
  • Mac

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3553 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 10/3/2024 **Status:** ✅ Merged **Merged:** 10/4/2024 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `electron/cleanup-package` --- ### 📝 Commits (7) - [`cab00fc`](https://github.com/actualbudget/actual/commit/cab00fc426fc3f3647aeea62ee5306aec6f21423) remove unneeded loot core ref and keeping better-sqlite external - [`0f8436b`](https://github.com/actualbudget/actual/commit/0f8436b6806a37e4b9249a874db844d6b9c5549c) release notes - [`157b0d5`](https://github.com/actualbudget/actual/commit/157b0d55dee1920d49608e8668a46b55b873920c) putting the package config back - [`a7ea319`](https://github.com/actualbudget/actual/commit/a7ea319fd0c127d635bed584b4d873284b00938c) cleaning up - [`08c02bb`](https://github.com/actualbudget/actual/commit/08c02bb21d9182c2e0e6736f1a61a57d03408e54) add missing db files - [`0b34b75`](https://github.com/actualbudget/actual/commit/0b34b75ab1dc7f5518eb3f752c10d75abd5c61e3) updates - [`ae24535`](https://github.com/actualbudget/actual/commit/ae2453593d5f7be7fc4326799554678ee7875271) window state updates ### 📊 Changes **8 files changed** (+42 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-electron/bin/update-client` (+8 -0) 📝 `packages/desktop-electron/index.ts` (+6 -3) 📝 `packages/desktop-electron/modules.d.ts` (+0 -6) 📝 `packages/desktop-electron/package.json` (+3 -6) 📝 `packages/desktop-electron/server.ts` (+7 -6) 📝 `packages/desktop-electron/window-state.ts` (+10 -12) ➕ `upcoming-release-notes/3553.md` (+6 -0) 📝 `yarn.lock` (+2 -2) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> We currently include all of loot-core's dependencies in the electron app. This may have been the root cause of the better-sqlite x64/arm64 issues we had a while ago. We don't need to include these modules because we bundle loot-core into bundle.desktop.js. This change makes it much easier to see what the Electron app _really_ depends on. **Difference in size:** **Old :** ![image](https://github.com/user-attachments/assets/c7fa7b0a-2265-407b-bdfa-fa5c72a4bcd5) **New:** ![image](https://github.com/user-attachments/assets/f4cb2f00-adb7-4de3-b5ff-64b30de14ad8) **Tested on:** - [x] Windows - [x] Linux - [x] Mac --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:03:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4923
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?