github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5421] [MERGED] Fix translate rule stages #5926

New Issue
Closed
opened 2026-02-28 21:21:03 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:21:03 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5421
Author: @milanalexandre
Created: 7/29/2025
Status: ✅ Merged
Merged: 8/4/2025
Merged by: @youngcw

Base: master ← Head: fix/translate-rule-stages

📝 Commits (4)

📊 Changes

4 files changed (+20 additions, -2 deletions)

View changed files

📝 packages/desktop-client/e2e/help-menu.test.ts (+1 -0)
📝 packages/desktop-client/src/components/rules/RuleRow.tsx (+2 -2)
📝 packages/loot-core/src/shared/rules.ts (+11 -0)
➕ upcoming-release-notes/5421.md (+6 -0)

📄 Description

This PR adds internationalization support for rule stage labels in the rules interface
Fixes #5338
Capture d’écran 2025-07-29 à 21 35 46

problematic test log :

[chromium] › e2e/help-menu.test.ts:33:7 › Help menu › Check the keyboard shortcuts modal visuals 

    Test timeout of 60000ms exceeded.
    Error: locator.click: Target page, context or browser has been closed
    Call log:
      - waiting for getByRole('button', { name: 'Help' })


      32 |
      33 |   test('Check the keyboard shortcuts modal visuals', async () => {
    > 34 |     await page.getByRole('button', { name: 'Help' }).click();
         |                                                      ^
      35 |     await page.getByText('Keyboard shortcuts').click();
      36 |
      37 |     const keyboardShortcutsModal = page.getByRole('dialog', {

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5421 **Author:** [@milanalexandre](https://github.com/milanalexandre) **Created:** 7/29/2025 **Status:** ✅ Merged **Merged:** 8/4/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix/translate-rule-stages` --- ### 📝 Commits (4) - [`cba526d`](https://github.com/actualbudget/actual/commit/cba526d8819eb02ed405a039e5a477270b0e6670) add translation support for rule stages - [`ac67af5`](https://github.com/actualbudget/actual/commit/ac67af59f9506e42355cff72c29f3819388ca516) add relese note - [`76bfd84`](https://github.com/actualbudget/actual/commit/76bfd845d6e0638a2276690a8c56cf5004a92249) fix test - [`25dd761`](https://github.com/actualbudget/actual/commit/25dd76189b9e8655997b66767e6aac8183b904c4) feed back ### 📊 Changes **4 files changed** (+20 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/help-menu.test.ts` (+1 -0) 📝 `packages/desktop-client/src/components/rules/RuleRow.tsx` (+2 -2) 📝 `packages/loot-core/src/shared/rules.ts` (+11 -0) ➕ `upcoming-release-notes/5421.md` (+6 -0) </details> ### 📄 Description This PR adds internationalization support for rule stage labels in the rules interface Fixes #5338 <img width="705" height="527" alt="Capture d’écran 2025-07-29 à 21 35 46" src="https://github.com/user-attachments/assets/ad262501-93fa-4d6a-be56-e9860b7c1b6e" /> problematic test log : ``` [chromium] › e2e/help-menu.test.ts:33:7 › Help menu › Check the keyboard shortcuts modal visuals Test timeout of 60000ms exceeded. Error: locator.click: Target page, context or browser has been closed Call log: - waiting for getByRole('button', { name: 'Help' }) 32 | 33 | test('Check the keyboard shortcuts modal visuals', async () => { > 34 | await page.getByRole('button', { name: 'Help' }).click(); | ^ 35 | await page.getByText('Keyboard shortcuts').click(); 36 | 37 | const keyboardShortcutsModal = page.getByRole('dialog', { ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:21:03 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5926
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?