github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3044] [MERGED] Fix a few number parsing issues #4652

New Issue
Closed
opened 2026-02-28 20:59:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:59:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3044
Author: @youngcw
Created: 7/12/2024
Status: ✅ Merged
Merged: 8/4/2024
Merged by: @youngcw

Base: master ← Head: youngcw/ofx-number-parse

📝 Commits (7)

📊 Changes

5 files changed (+20 additions, -14 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/parse-file.test.ts (+0 -12)
📝 packages/loot-core/src/server/accounts/parse-file.ts (+1 -1)
📝 packages/loot-core/src/shared/util.test.ts (+12 -0)
📝 packages/loot-core/src/shared/util.ts (+1 -1)
➕ upcoming-release-notes/3044.md (+6 -0)

📄 Description

Revert a change that caused ofx parsing to not allow non decimal comma number formats. Also tweak the generic parser to work with decimal only values. I've increased the number of tests that are run on the generic parser to check for more use cases, and all the supported number formats.

Fixes: #2800
fixes: #1051

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3044 **Author:** [@youngcw](https://github.com/youngcw) **Created:** 7/12/2024 **Status:** ✅ Merged **Merged:** 8/4/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `youngcw/ofx-number-parse` --- ### 📝 Commits (7) - [`926f0ef`](https://github.com/actualbudget/actual/commit/926f0ef7de974deabfd24ce6d2afacc0110278c6) revert built in number parse - [`bcc3c0a`](https://github.com/actualbudget/actual/commit/bcc3c0a942925ef00a08e162461ece673cfc0be9) note - [`a99dda7`](https://github.com/actualbudget/actual/commit/a99dda765f37d20a327a5efd99206d0c405462de) tests - [`1ae1552`](https://github.com/actualbudget/actual/commit/1ae1552e5ea3683fe56a48d98352b33a15470dbe) remove trivial test - [`60451f1`](https://github.com/actualbudget/actual/commit/60451f14f80ff5fc7546f5688619acde04e3759d) more tests - [`6d24f07`](https://github.com/actualbudget/actual/commit/6d24f077d3b3d82e42a794761a437ab5671315a0) Merge branch 'master' into youngcw/ofx-number-parse - [`80a3b67`](https://github.com/actualbudget/actual/commit/80a3b673e51b1897f207600d6661bde7dd7d560a) Merge branch 'master' into youngcw/ofx-number-parse ### 📊 Changes **5 files changed** (+20 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/parse-file.test.ts` (+0 -12) 📝 `packages/loot-core/src/server/accounts/parse-file.ts` (+1 -1) 📝 `packages/loot-core/src/shared/util.test.ts` (+12 -0) 📝 `packages/loot-core/src/shared/util.ts` (+1 -1) ➕ `upcoming-release-notes/3044.md` (+6 -0) </details> ### 📄 Description Revert a change that caused ofx parsing to not allow non decimal comma number formats. Also tweak the generic parser to work with decimal only values. I've increased the number of tests that are run on the generic parser to check for more use cases, and all the supported number formats. Fixes: #2800 fixes: #1051 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:59:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4652
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?