[PR #4632] [MERGED] ♻️ removal of '.testing.ts' file extensions in favour of mocks #5497

Closed
opened 2026-02-28 21:13:26 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4632
Author: @MatissJanis
Created: 3/15/2025
Status: Merged
Merged: 3/18/2025
Merged by: @MatissJanis

Base: masterHead: matiss/testing-extensions


📝 Commits (4)

  • 5eb9072 ♻️ removal of '.testing.ts' file extensions in favour of mocks
  • 0a2d21f Add missing resetEvents
  • 94ee8c7 patch
  • e659be5 Merge branch 'master' into matiss/testing-extensions

📊 Changes

22 files changed (+32 additions, -36 deletions)

View changed files

📝 packages/api/jest.config.js (+0 -2)
📝 packages/loot-core/jest.config.js (+0 -2)
📝 packages/loot-core/jest.web.config.js (+0 -2)
📝 packages/loot-core/src/client/__mocks__/platform.web.ts (+0 -0)
📝 packages/loot-core/src/mocks/setup.ts (+3 -0)
📝 packages/loot-core/src/platform/client/fetch/__mocks__/index.ts (+1 -1)
📝 packages/loot-core/src/platform/client/fetch/index.browser.ts (+4 -4)
packages/loot-core/src/platform/client/fetch/index.testing.ts (+0 -2)
📝 packages/loot-core/src/platform/client/fetch/index.ts (+3 -1)
📝 packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts (+2 -3)
📝 packages/loot-core/src/platform/server/asyncStorage/index.electron.ts (+1 -1)
📝 packages/loot-core/src/platform/server/asyncStorage/index.ts (+1 -1)
📝 packages/loot-core/src/platform/server/connection/__mocks__/index.ts (+1 -6)
📝 packages/loot-core/src/platform/server/connection/index.api.ts (+1 -1)
📝 packages/loot-core/src/platform/server/connection/index.d.ts (+0 -3)
📝 packages/loot-core/src/platform/server/connection/index.electron.ts (+3 -1)
📝 packages/loot-core/src/platform/server/connection/index.ts (+3 -1)
📝 packages/loot-core/src/platform/server/fetch/__mocks__/index.ts (+0 -0)
packages/loot-core/src/platform/server/fetch/index.d.ts (+0 -4)
📝 packages/loot-core/src/platform/server/fetch/index.ts (+0 -0)

...and 2 more files

📄 Description

Technically this should be exactly the same functionality. Expect we are no longer using the .testing.ts file extensions - but instead test mocks.

Split off from https://github.com/actualbudget/actual/pull/4592


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4632 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/15/2025 **Status:** ✅ Merged **Merged:** 3/18/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/testing-extensions` --- ### 📝 Commits (4) - [`5eb9072`](https://github.com/actualbudget/actual/commit/5eb9072e8a7b6b55bad3321fb6b243513a35d590) :recycle: removal of '.testing.ts' file extensions in favour of mocks - [`0a2d21f`](https://github.com/actualbudget/actual/commit/0a2d21f81f51093e2a465f10d5fddc9373d1c2ad) Add missing resetEvents - [`94ee8c7`](https://github.com/actualbudget/actual/commit/94ee8c7de5726e6f55643ff3d2ee23278438c62b) patch - [`e659be5`](https://github.com/actualbudget/actual/commit/e659be5854fd0d1baf6742a5ee1c615f7a5eef4e) Merge branch 'master' into matiss/testing-extensions ### 📊 Changes **22 files changed** (+32 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/jest.config.js` (+0 -2) 📝 `packages/loot-core/jest.config.js` (+0 -2) 📝 `packages/loot-core/jest.web.config.js` (+0 -2) 📝 `packages/loot-core/src/client/__mocks__/platform.web.ts` (+0 -0) 📝 `packages/loot-core/src/mocks/setup.ts` (+3 -0) 📝 `packages/loot-core/src/platform/client/fetch/__mocks__/index.ts` (+1 -1) 📝 `packages/loot-core/src/platform/client/fetch/index.browser.ts` (+4 -4) ➖ `packages/loot-core/src/platform/client/fetch/index.testing.ts` (+0 -2) 📝 `packages/loot-core/src/platform/client/fetch/index.ts` (+3 -1) 📝 `packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts` (+2 -3) 📝 `packages/loot-core/src/platform/server/asyncStorage/index.electron.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/asyncStorage/index.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/connection/__mocks__/index.ts` (+1 -6) 📝 `packages/loot-core/src/platform/server/connection/index.api.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/connection/index.d.ts` (+0 -3) 📝 `packages/loot-core/src/platform/server/connection/index.electron.ts` (+3 -1) 📝 `packages/loot-core/src/platform/server/connection/index.ts` (+3 -1) 📝 `packages/loot-core/src/platform/server/fetch/__mocks__/index.ts` (+0 -0) ➖ `packages/loot-core/src/platform/server/fetch/index.d.ts` (+0 -4) 📝 `packages/loot-core/src/platform/server/fetch/index.ts` (+0 -0) _...and 2 more files_ </details> ### 📄 Description Technically this should be exactly the same functionality. Expect we are no longer using the `.testing.ts` file extensions - but instead test mocks. Split off from https://github.com/actualbudget/actual/pull/4592 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:13:26 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5497