github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2946] [MERGED] Port finance modals to use new Modal component based on React Aria Modal #4606

New Issue
Closed
opened 2026-02-28 20:58:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:58:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2946
Author: @joel-jeremy
Created: 6/26/2024
Status: ✅ Merged
Merged: 7/20/2024
Merged by: @joel-jeremy

Base: master ← Head: react-aria-modal

📝 Commits (10+)

📊 Changes

58 files changed (+4496 additions, -3676 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/account-page.js (+1 -1)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/Modals.tsx (+38 -128)
📝 packages/desktop-client/src/components/common/Modal.tsx (+4 -3)
➕ packages/desktop-client/src/components/common/Modal2.tsx (+460 -0)
📝 packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (+79 -21)
📝 packages/desktop-client/src/components/mobile/budget/index.tsx (+20 -0)
📝 packages/desktop-client/src/components/modals/AccountAutocompleteModal.tsx (+51 -48)
📝 packages/desktop-client/src/components/modals/AccountMenuModal.tsx (+80 -68)
📝 packages/desktop-client/src/components/modals/BudgetListModal.tsx (+26 -26)
📝 packages/desktop-client/src/components/modals/BudgetPageMenuModal.tsx (+17 -15)
📝 packages/desktop-client/src/components/modals/CategoryAutocompleteModal.tsx (+55 -52)
📝 packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx (+88 -78)
📝 packages/desktop-client/src/components/modals/CategoryMenuModal.tsx (+80 -71)
📝 packages/desktop-client/src/components/modals/CloseAccountModal.tsx (+140 -133)
📝 packages/desktop-client/src/components/modals/ConfirmCategoryDelete.tsx (+81 -74)
📝 packages/desktop-client/src/components/modals/ConfirmTransactionDelete.tsx (+41 -34)
📝 packages/desktop-client/src/components/modals/ConfirmTransactionEdit.tsx (+75 -67)
📝 packages/desktop-client/src/components/modals/ConfirmUnlinkAccount.tsx (+37 -31)
📝 packages/desktop-client/src/components/modals/CoverModal.tsx (+36 -30)

...and 38 more files

📄 Description

No changes were made on the Modal children nodes aside from adding a <ModalHeader ... /> component and making the children node a lambda which accepts a close function

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2946 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 6/26/2024 **Status:** ✅ Merged **Merged:** 7/20/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `react-aria-modal` --- ### 📝 Commits (10+) - [`34c7c01`](https://github.com/actualbudget/actual/commit/34c7c01937355c5e674bbb17f93bd2dcfaaf7ab0) React Aria Modal POC - [`68c1c3f`](https://github.com/actualbudget/actual/commit/68c1c3ff4219dcf6625fe17865315c801f000c69) Fix imports - [`06e826b`](https://github.com/actualbudget/actual/commit/06e826b9bd54ce062976dc6686255a16509fc6ee) Use composition - [`272f3cc`](https://github.com/actualbudget/actual/commit/272f3cc1cb0c5e7171f5ccfb1c50d8cbfced55c4) Fix typecheck and lint errors - [`dbca85b`](https://github.com/actualbudget/actual/commit/dbca85b6d348659ab8ccfe7752f01a0b245d2f14) VRT - [`387cd2f`](https://github.com/actualbudget/actual/commit/387cd2fa32ebf3cf337e09c6e24cb4a39ed0922a) Fix schedule details modal header - [`6bd9281`](https://github.com/actualbudget/actual/commit/6bd9281b1ee4d17aa0cf9e60b390790f16b23ea1) Fix typecheck error + VRT - [`43fff6d`](https://github.com/actualbudget/actual/commit/43fff6d070d7222829ff5719452a42b1f6ede0b6) Fix typecheck error - [`1cfc74c`](https://github.com/actualbudget/actual/commit/1cfc74ca51c97e0a5a1bcffaf0d31ceff40de33b) Release notes - [`d57de76`](https://github.com/actualbudget/actual/commit/d57de76e511a9514e79e48d8a58bcc5ecbc96aad) Update release note ### 📊 Changes **58 files changed** (+4496 additions, -3676 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/account-page.js` (+1 -1) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/Modals.tsx` (+38 -128) 📝 `packages/desktop-client/src/components/common/Modal.tsx` (+4 -3) ➕ `packages/desktop-client/src/components/common/Modal2.tsx` (+460 -0) 📝 `packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx` (+79 -21) 📝 `packages/desktop-client/src/components/mobile/budget/index.tsx` (+20 -0) 📝 `packages/desktop-client/src/components/modals/AccountAutocompleteModal.tsx` (+51 -48) 📝 `packages/desktop-client/src/components/modals/AccountMenuModal.tsx` (+80 -68) 📝 `packages/desktop-client/src/components/modals/BudgetListModal.tsx` (+26 -26) 📝 `packages/desktop-client/src/components/modals/BudgetPageMenuModal.tsx` (+17 -15) 📝 `packages/desktop-client/src/components/modals/CategoryAutocompleteModal.tsx` (+55 -52) 📝 `packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx` (+88 -78) 📝 `packages/desktop-client/src/components/modals/CategoryMenuModal.tsx` (+80 -71) 📝 `packages/desktop-client/src/components/modals/CloseAccountModal.tsx` (+140 -133) 📝 `packages/desktop-client/src/components/modals/ConfirmCategoryDelete.tsx` (+81 -74) 📝 `packages/desktop-client/src/components/modals/ConfirmTransactionDelete.tsx` (+41 -34) 📝 `packages/desktop-client/src/components/modals/ConfirmTransactionEdit.tsx` (+75 -67) 📝 `packages/desktop-client/src/components/modals/ConfirmUnlinkAccount.tsx` (+37 -31) 📝 `packages/desktop-client/src/components/modals/CoverModal.tsx` (+36 -30) _...and 38 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> No changes were made on the Modal children nodes aside from adding a `<ModalHeader ... />` component and making the children node a lambda which accepts a `close` function --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:58:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4606
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?