github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3772] [CLOSED] Sub category groups #5048

New Issue
Closed
opened 2026-02-28 21:05:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:05:09 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3772
Author: @UnderKoen
Created: 11/3/2024
Status: ❌ Closed

Base: master ← Head: feat/sub-categories

📝 Commits (6)

  • 2a9e296 feat: sub category groups
  • 9d9207c chore: release note
  • 7618a39 fix: adding initial child group add budget twice to total
  • d9ec619 feat: groups for income
  • 6a7ef6f chore: rename button to "Add sub-group"
  • 9988c6e Merge remote-tracking branch 'origin/master' into feat/sub-categories

📊 Changes

29 files changed (+256 additions, -83 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/BudgetCategories.jsx (+48 -38)
📝 packages/desktop-client/src/components/budget/BudgetTable.jsx (+1 -1)
📝 packages/desktop-client/src/components/budget/ExpenseCategory.tsx (+3 -0)
📝 packages/desktop-client/src/components/budget/ExpenseGroup.tsx (+9 -1)
📝 packages/desktop-client/src/components/budget/IncomeCategory.tsx (+3 -0)
📝 packages/desktop-client/src/components/budget/IncomeGroup.tsx (+6 -0)
📝 packages/desktop-client/src/components/budget/IncomeHeader.tsx (+5 -2)
📝 packages/desktop-client/src/components/budget/SidebarCategory.tsx (+6 -1)
📝 packages/desktop-client/src/components/budget/SidebarGroup.tsx (+14 -2)
📝 packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx (+3 -2)
📝 packages/desktop-client/src/components/budget/index.tsx (+4 -6)
📝 packages/desktop-client/src/components/settings/Experimental.tsx (+3 -0)
📝 packages/desktop-client/src/hooks/useCategories.ts (+9 -2)
📝 packages/desktop-client/src/hooks/useFeatureFlag.ts (+1 -0)
➕ packages/loot-core/migrations/1726730827000_sub_category_groups.sql (+5 -0)
📝 packages/loot-core/src/client/actions/queries.ts (+2 -2)
📝 packages/loot-core/src/client/reducers/queries.ts (+10 -4)
📝 packages/loot-core/src/server/accounts/sync.test.ts (+5 -1)
📝 packages/loot-core/src/server/accounts/transfer.test.ts (+5 -1)
📝 packages/loot-core/src/server/budget/base.test.ts (+1 -1)

...and 9 more files

📄 Description

Previous: #3589

Add hierachy to category groups.

What is changed compared to the previous is:

  • All exisiting usage of groups should not be broken
  • Features use a flatten group list so sub groups are tough of as normal groups.
  • A feature flag for this feature.
  • Budget page is the only page to use the hierachal groups.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3772 **Author:** [@UnderKoen](https://github.com/UnderKoen) **Created:** 11/3/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat/sub-categories` --- ### 📝 Commits (6) - [`2a9e296`](https://github.com/actualbudget/actual/commit/2a9e296dfdf5d5b6cc0c695926b5d5c430b31782) feat: sub category groups - [`9d9207c`](https://github.com/actualbudget/actual/commit/9d9207cbb551e773b665006534e8c1c680574de6) chore: release note - [`7618a39`](https://github.com/actualbudget/actual/commit/7618a39e018fe195c03ca94e6353b7da7f9cefab) fix: adding initial child group add budget twice to total - [`d9ec619`](https://github.com/actualbudget/actual/commit/d9ec619b5f250e877d2c8840a0c9133eb9ae63bd) feat: groups for income - [`6a7ef6f`](https://github.com/actualbudget/actual/commit/6a7ef6f29c1cd2753da2d98058077505aaad1d75) chore: rename button to "Add sub-group" - [`9988c6e`](https://github.com/actualbudget/actual/commit/9988c6e805e7b029885d71f0aa1fcd0402d783e2) Merge remote-tracking branch 'origin/master' into feat/sub-categories ### 📊 Changes **29 files changed** (+256 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/BudgetCategories.jsx` (+48 -38) 📝 `packages/desktop-client/src/components/budget/BudgetTable.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/ExpenseCategory.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/budget/ExpenseGroup.tsx` (+9 -1) 📝 `packages/desktop-client/src/components/budget/IncomeCategory.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/budget/IncomeGroup.tsx` (+6 -0) 📝 `packages/desktop-client/src/components/budget/IncomeHeader.tsx` (+5 -2) 📝 `packages/desktop-client/src/components/budget/SidebarCategory.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/budget/SidebarGroup.tsx` (+14 -2) 📝 `packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+4 -6) 📝 `packages/desktop-client/src/components/settings/Experimental.tsx` (+3 -0) 📝 `packages/desktop-client/src/hooks/useCategories.ts` (+9 -2) 📝 `packages/desktop-client/src/hooks/useFeatureFlag.ts` (+1 -0) ➕ `packages/loot-core/migrations/1726730827000_sub_category_groups.sql` (+5 -0) 📝 `packages/loot-core/src/client/actions/queries.ts` (+2 -2) 📝 `packages/loot-core/src/client/reducers/queries.ts` (+10 -4) 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+5 -1) 📝 `packages/loot-core/src/server/accounts/transfer.test.ts` (+5 -1) 📝 `packages/loot-core/src/server/budget/base.test.ts` (+1 -1) _...and 9 more files_ </details> ### 📄 Description Previous: #3589 Add hierachy to category groups. What is changed compared to the previous is: - All exisiting usage of groups should not be broken - Features use a flatten group list so sub groups are tough of as normal groups. - A feature flag for this feature. - Budget page is the only page to use the hierachal groups. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:05:09 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5048
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?