github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3552] [MERGED] ♻️ split ImportTransactionsModal into smaller component files #4922

New Issue
Closed
opened 2026-02-28 21:03:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:03:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3552
Author: @MatissJanis
Created: 10/3/2024
Status: ✅ Merged
Merged: 10/4/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/ts-import

📝 Commits (2)

  • 10085ee ♻️ split ImportTransactionsModal into smaller component files
  • f629962 Update parseDate test import path

📊 Changes

14 files changed (+818 additions, -736 deletions)

View changed files

➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/CheckboxOption.jsx (+43 -0)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/DateFormatSelect.jsx (+39 -0)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/FieldMappings.jsx (+132 -0)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx (+28 -735)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/InOutOption.jsx (+37 -0)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/MultiplierOption.jsx (+32 -0)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/ParsedDate.jsx (+30 -0)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/SelectField.jsx (+29 -0)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/SubLabel.jsx (+12 -0)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/Transaction.jsx (+241 -0)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/index.ts (+1 -0)
➕ packages/desktop-client/src/components/modals/ImportTransactionsModal/utils.js (+187 -0)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/utils.test.js (+1 -1)
➕ upcoming-release-notes/3552.md (+6 -0)

📄 Description

Migrating massive files to TypeScript is hard. Splitting up ImportTransactionsModal into one-component-per-file to help with the migration.

This PR has no other functional changes. It's exactly the same code as before except split in multiple files.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3552 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/3/2024 **Status:** ✅ Merged **Merged:** 10/4/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/ts-import` --- ### 📝 Commits (2) - [`10085ee`](https://github.com/actualbudget/actual/commit/10085eeaa299d4d9a58a9fc7f73071444d2098ce) :recycle: split ImportTransactionsModal into smaller component files - [`f629962`](https://github.com/actualbudget/actual/commit/f629962c069619b5fdd1db4dcbd52fe358be8704) Update parseDate test import path ### 📊 Changes **14 files changed** (+818 additions, -736 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/CheckboxOption.jsx` (+43 -0) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/DateFormatSelect.jsx` (+39 -0) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/FieldMappings.jsx` (+132 -0) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx` (+28 -735) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/InOutOption.jsx` (+37 -0) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/MultiplierOption.jsx` (+32 -0) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/ParsedDate.jsx` (+30 -0) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/SelectField.jsx` (+29 -0) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/SubLabel.jsx` (+12 -0) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/Transaction.jsx` (+241 -0) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/index.ts` (+1 -0) ➕ `packages/desktop-client/src/components/modals/ImportTransactionsModal/utils.js` (+187 -0) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/utils.test.js` (+1 -1) ➕ `upcoming-release-notes/3552.md` (+6 -0) </details> ### 📄 Description Migrating massive files to TypeScript is hard. Splitting up `ImportTransactionsModal` into one-component-per-file to help with the migration. This PR has no other functional changes. It's exactly the same code as before except split in multiple files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:03:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4922
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?