Commit Graph

1157 Commits

Author SHA1 Message Date
Neil
cd2d186599 Add new types for reports files (#2067)
* work

* notes

* error fixes

* updates

* card fix

* fix filters

* splitting PR work

* notes
2023-12-11 16:31:25 -08:00
Joel Jeremy Marquez
b3bcff094d [Maintenance] ESLint - prefer-const on loot-core server (#2032)
* Another round of prefer-const rule updates

* Release notes

* Fix test error

* Fix sync.ts
2023-12-09 13:22:16 -08:00
Matiss Janis Aboltins
7955fe7aed ♻️ (typescript) refactor FixedSizeList to TS (#2022) 2023-12-07 19:30:29 +00:00
Neil
2741422c0a Custom Reports optimization (#1988)
* Range fix and payee fix

* bug fixes and UI tweaks

* range options, hover UI

* Select - UnSelect All Buttons

* fix hidden group bug

* YAxis PrivacyFilter

* notes

* more privacyFilter graphs

* overflowY fix

* Loading Indicator

* Fix Filter button hover

* data revamp

* review fixes

* LoadingIndicator fixes

* remove a loop

* filterbuttontype

* lint fixes

* review fixes

* filtersbutton

* updates

* Split out functions to separate files

* uncategorized optimization

* rename ambiguous variables

* notes

* remove indexStack

* renaming variables

* Improve scrolling of tableGraph

* revert renaming variables

* code fixes

* lint fixes

* review fixes

* fix

* review fixes

* variable name changes

* const eslint fixes

* remove indexStack
2023-12-06 09:33:19 -08:00
Tuhin Ghose
cde4551eb7 [Maintenance] Migrating util.js and chartTheme.js to typescript (#2009) 2023-12-06 08:26:17 +00:00
Matiss Janis Aboltins
7174fccfe4 ♻️ (typescript) adding strict typings to utils.ts (#2023) 2023-12-06 08:22:33 +00:00
Joel Jeremy Marquez
0303292a28 [Maintenance] ESLint: prefer-const components folder part 2 (#2034)
* ESLint prefer-const components folder part 2

* Release notes
2023-12-05 13:36:29 -08:00
Joel Jeremy Marquez
f95df06800 [Maintenance] ESLint: prefer-const components folder part 1 (#2033)
* ESLint prefer-const components folder part 1

* Release notes
2023-12-05 13:14:37 -08:00
DJ Mountney
3680d45814 Add API category tests (#2036) 2023-12-05 20:08:48 +00:00
Joel Jeremy Marquez
dc872647a9 [Maintenance] Use Page component for mobile pages (#1993)
* Use Page component for mobile pages

* Release notes

* Use Button instead of Link in MobileBackButton

* Update mobile budget table to use Page component

* Settings page cleanup

* Fix lint error

* Updates + small font size increase in  page headings

* Fix rebase error

* Button height

* Revert payees navtab
2023-12-05 11:18:35 -08:00
Matiss Janis Aboltins
7a45d467b7 ♻️ (eslint) enable 'react/no-children-prop' rule and fix issues (#2029) 2023-12-05 18:58:22 +00:00
Joel Jeremy Marquez
79aa07ff1a Fix bulk edit field modal in desktop (#2031)
* Fix bulk edit field modal in desktop

* Release notes
2023-12-05 09:44:30 -08:00
Kyle Mckay
c4ff099f26 Fix failure to create category with deleted name (#2002)
* Fix failure to create category with deleted name

I'm not 100% familiar with the design of the data model so may have
misinterpreted what's going on here, but how I read this:

- The tombstone flag is used to soft delete categories.
- When creating a new category, duplicate names within a group are
  prevented.
- When checking for duplicate names, the tombstone flag was unchecked
  which meant deleted categories were falsely blocking creation.

I had a look at category deleteion logic to verify that simply including
the tombstone flag in this check is sane and see that there's a category
mapping being maintained to redirect one category to another on
deletion. So from what I can tell the correct behaviour here is to allow
a new category with the previously deleted name, rather than to revive
the old category (to preserve that old mapping lineage).

* Add release note

* Add regression test
2023-12-05 08:48:16 -07:00
Vishnu Kaushik
ad2b577515 Fix #1977: Filter Amount formatting issue (#2008)
* Fix #1977: Filter Amount formatting issue

* Fix linting and add release notes
2023-12-05 08:42:54 -07:00
Michael Clark
5f52801869 [Maintenance] Adding Aria labels for accessibility (#2025) 2023-12-04 19:31:38 +00:00
Ameek Singh
6bfd9586e0 [Maintenance] Converting dateRange and useReport to tsx (#2007) 2023-12-02 22:43:56 +00:00
Michael Clark
f36713e0be [Maintenance] BudgetTotals, GoCardlessLink, Import, WelcomeScreen components to Typescript. (#2004) 2023-12-02 22:43:29 +00:00
DJ Mountney
8b20169b59 Add some initial api tests for budgets and accounts (#1991) 2023-12-02 20:42:53 +00:00
Matiss Janis Aboltins
da03acc394 🔖 (23.12.0) darkmode, transaction locking, mobile updates and more (#2003) v23.12.0 2023-12-02 19:26:02 +00:00
Joel Jeremy Marquez
5d1f2d48ae Larger mobile autocomplete fonts and paddings (#1900)
* Larger mobile autocomplete fonts and paddings

* Release notes

* VRT + update tests

* Update tests

* Update data-highlighted and tests

* Use styles text

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Adjust Add Transaction padding + VRT updates

* Larger autocomplete text and divider

* Fix rebase

* Fix rebase

* Fix icons

* Adjust fonts

* Fix lint errors

* PR feedback

* VRT

* Update embedded autocomplete highlight hover color

* Refactor create payee button

* Embedded create payee button color

* Dummy change to re-run CI
2023-12-01 13:10:01 -08:00
youngcw
c96782d7c1 [Goals]: Sort the priorities properly (#2000)
* sort properly

* note
2023-12-01 08:40:35 -07:00
Neil
5d61dfce68 Update rules API (#1987)
* Update rules.ts

* notes

* Update packages/loot-core/src/server/accounts/rules.ts

Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>

* Entity update

* fix

---------

Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
2023-11-30 10:27:51 -08:00
youngcw
5a81a25b7e fix broken schedule amount sign in firefox (#1992)
* fix broken schedule amount sign in firefox

* note

* delete line
2023-11-30 09:50:31 -07:00
Stefan Hall
29f323e721 Validates minimum node version to 18.12.0 for @actual-app/api npm package (#1980) 2023-11-28 19:19:18 +00:00
shall0pass
c462604833 [Bugfix] Goals: Schedule overbudget condition (#1984)
* fix overbudget in schedules template

* release note
2023-11-27 18:18:26 -06:00
Neil
e48f36cd20 Custom Reports Bug Fixes (#1930)
* Range fix and payee fix

* bug fixes and UI tweaks

* range options, hover UI

* Select - UnSelect All Buttons

* fix hidden group bug

* YAxis PrivacyFilter

* notes

* more privacyFilter graphs

* overflowY fix

* Loading Indicator

* Fix Filter button hover

* review fixes

* LoadingIndicator fixes

* remove a loop

* filterbuttontype

* review fixes

* filtersbutton

* updates
2023-11-26 12:19:58 -08:00
Michael Clark
1ed84059d7 [Maintenance] Update ConfirmCategoryDelete, GoCardlessExternalMsg, ManageRulesModal to tsx (#1972) 2023-11-26 19:49:26 +00:00
William Kurniawan
5d8b96a749 Fix cancel add category group (#1975) 2023-11-26 16:38:05 +00:00
Julian Dominguez-Schatz
0920bdc3fa Fix bug in rule transaction apply preventing amount overrides (#1976) 2023-11-26 16:35:09 +00:00
Mohamed Muhsin
c3a9b4dda3 [refactor] Migrate Discover schedules to tsx (#1946) 2023-11-26 15:51:18 +00:00
Matiss Janis Aboltins
eab0068428 🎨 (fix) gocardless success button color (#1970) 2023-11-26 15:50:28 +00:00
Joel Jeremy Marquez
0d1b962b2f Fix budget amount not saved when clicking on another budget cell (#1965)
* Fix budget amount not saved when clicking on another budget cell

* Release notes
2023-11-25 16:52:38 -08:00
Joel Jeremy Marquez
67b9143dfc Transfer and Off Budget category in mobile (#1955)
* Transfer and Off Budget category in mobile

* Release notes

* Fix typo

* Update lookupName callers
2023-11-25 16:52:05 -08:00
Zach Whelchel
e7f298e32a [Bugfix] Fixed modal error and transactions now unlock when moved across accounts. (#1962) 2023-11-25 14:52:01 +00:00
Matiss Janis Aboltins
516f0c259f 🔧 (vrt) make screenshot comparisons more strict (#1960) 2023-11-25 14:34:24 +00:00
Neil
2c87c60328 Dark Theme Live (#1925)
* Remove Featureflag

* notes

* VRT updates

* Dark Theme fixes

* VRT updates

* VRT updates

* Revert "VRT updates"

This reverts commit 7d669f2df2.

* Revert VRT

Reverting VRT

* VRT updates

* pillbackground

* VRT updates

* Theme Selector

* VRT Updates

* notes

* VRT updates
2023-11-24 13:20:03 -08:00
DJ Mountney
b4fd6e86ed Create category rules for ynab imports (#1944) 2023-11-23 08:36:15 +00:00
Matiss Janis Aboltins
a3e71a8b49 🔧 (eslint) enable object-shorthand:properties rule (#1959) 2023-11-22 22:52:53 +00:00
Joel Jeremy Marquez
aa9c992f2e Part 2 of eslint prefer-const (#1958)
* Part 2 of eslint prefer-const

* Release notes

* Update
2023-11-22 14:28:09 -08:00
Zach Whelchel
ca498b19cc Lock transactions after reconcilliation (#1789) 2023-11-22 22:14:34 +00:00
Matiss Janis Aboltins
8be2389fd9 ♻️ (typescript) ported gocardless auth file to TS (#1941) 2023-11-22 21:54:43 +00:00
Matiss Janis Aboltins
46988800ef ♻️ (typescript) refactor global-events to TS (#1942) 2023-11-22 19:35:30 +00:00
Joel Jeremy Marquez
881999bcfe ESLint prefer-const (#1956) 2023-11-22 11:12:22 -08:00
Joel Jeremy Marquez
9c124e8e44 Consistent button size in budget title bar + use zondicon eye icon (#1951)
* Consistent button size in budget title bar + use zondicon eye icon

* Release notes

* VRT
2023-11-22 11:02:02 -08:00
Kyle Mckay
3306963c54 [Maintenance] Refactor payee table to typescript (#1948) 2023-11-22 17:58:07 +00:00
Kyle Mckay
baa474843a [Maintenance] Split up large payee management components file (#1950) 2023-11-21 19:27:20 +00:00
Matiss Janis Aboltins
6ed1b58321 🔧 (eslint) disallow using 'var': no-var rule (#1949) 2023-11-21 19:18:13 +00:00
Paul Sukow
28266ed9a2 Fix switching budget from rollover budget to report budget and immediately back does not work (#1933)
* Fix switching budget from rollover budget to report budget and immediately back does not work

* Pr Changes
2023-11-21 08:15:18 -08:00
Julian Dominguez-Schatz
cd6bd9ece8 Fix crash when undoing a rule application (#1885)
* Undo shouldn't open modal if it wasn't open before

* Add release notes
2023-11-21 00:19:31 -08:00
Michael Huynh
fb2f712c16 Fix flickering scroll bar on mobile transaction input (#1782) (#1929) 2023-11-20 12:46:47 -08:00