🔧 (eslint) disallow using 'var': no-var rule (#1949)

.eslintrc.js

@@ -92,6 +92,8 @@ module.exports = {
     //   },
     // ],
 
+    'no-var': 'warn',
+
     'import/extensions': [
       'warn',
       'never',

packages/desktop-client/src/browser-preload.browser.js

@@ -82,7 +82,7 @@ global.Actual = {
         let filename = file.name.replace(/.*(\.[^.]*)/, 'file$1');
 
         if (file) {
-          var reader = new FileReader();
+          let reader = new FileReader();
           reader.readAsArrayBuffer(file);
           reader.onload = async function (ev) {
             let filepath = `/uploads/${filename}`;

packages/desktop-electron/afterSignHook.js

@@ -1,7 +1,7 @@
 const fs = require('fs');
 const path = require('path');
 
-var electron_notarize = require('electron-notarize');
+let electron_notarize = require('electron-notarize');
 
 // This is expected to be run by `electron-builder` after it signs the build.
 // It's disabled for now as we currently don't sign builds after Actual being open sourced.

packages/desktop-electron/security.js

@@ -30,7 +30,7 @@ electron.app.on('ready', function () {
     permission,
     callback,
   ) {
-    var url = webContents.getURL();
+    let url = webContents.getURL();
     if (url.startsWith('file://')) {
       callback(true);
     } else {

packages/node-libofx/index.js

@@ -5,7 +5,7 @@ let _libofxPromise;
 let _libofx;
 let ffi;
 
-var parser = {
+let parser = {
   ctx: null,
   transactions: [],
 

upcoming-release-notes/1949.md

@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+eslint: disallow using 'var': no-var rule