github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

Fix: Add async/Promise type annotations to budget name validation functions #1782

New Issue
Closed
opened 2026-02-28 19:54:29 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 19:54:29 -06:00
Owner
Copy Link

Originally created by @coderabbitai[bot] on GitHub (Jan 20, 2025).

Originally assigned to: @joel-jeremy on GitHub.

Description

The following functions in packages/desktop-client/src/components/modals/manager/DuplicateFileModal.tsx need type adjustments to properly reflect their asynchronous nature:

  1. uniqueBudgetName: Should be marked as async and return Promise<string>
  2. validateBudgetName: Should be marked as async and return Promise<{ valid: boolean; message?: string; }>

Both functions use the asynchronous send function but currently don't reflect this in their type signatures.

Context

Originally created by @coderabbitai[bot] on GitHub (Jan 20, 2025). Originally assigned to: @joel-jeremy on GitHub. ## Description The following functions in `packages/desktop-client/src/components/modals/manager/DuplicateFileModal.tsx` need type adjustments to properly reflect their asynchronous nature: 1. `uniqueBudgetName`: Should be marked as `async` and return `Promise<string>` 2. `validateBudgetName`: Should be marked as `async` and return `Promise<{ valid: boolean; message?: string; }>` Both functions use the asynchronous `send` function but currently don't reflect this in their type signatures. ## Context - PR: https://github.com/actualbudget/actual/pull/4114 - Comment: https://github.com/actualbudget/actual/pull/4114#discussion_r1921649899
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1782
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?