github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: Modals - missing ErrorBoundary #1991

New Issue
Closed
opened 2026-02-28 20:00:41 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-02-28 20:00:41 -06:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Mar 29, 2025).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

The Modals component is missing a wrapping ErrorBoundary. If any of the modals encounter an exception - this results in a fatal error crashing the entire page (user seems a blank white page).

Obviously this is not great..

How can we reproduce the issue?

Throw an exception in one of the modals on your dev server.

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @MatissJanis on GitHub (Mar 29, 2025). ### Verified issue does not already exist? - [x] I have searched and found no existing issue ### What happened? The `Modals` component is missing a wrapping `ErrorBoundary`. If any of the modals encounter an exception - this results in a fatal error crashing the entire page (user seems a blank white page). Obviously this is not great.. ### How can we reproduce the issue? Throw an exception in one of the modals on your dev server. ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the tech debtbug labels 2026-02-28 20:00:41 -06:00
GiteaMirror commented 2026-02-28 20:00:42 -06:00
Author
Owner
Copy Link

@koonweee commented on GitHub (Mar 30, 2025):

@MatissJanis any clarification on how to reprod? I tried throwing an error in a button's onclick but it does not crash the app

nvm, TIL event handlers don't trigger error boundaries. https://legacy.reactjs.org/docs/error-boundaries.html#how-about-event-handlers

@koonweee commented on GitHub (Mar 30, 2025): ~@MatissJanis any clarification on how to reprod? I tried throwing an error in a button's onclick but it does not crash the app~ nvm, TIL event handlers don't trigger error boundaries. https://legacy.reactjs.org/docs/error-boundaries.html#how-about-event-handlers
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug tech debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1991
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?