[Bug]: schedule template percentages breaks schedule name parsing #1960

Closed
opened 2026-02-28 19:59:57 -06:00 by GiteaMirror · 5 comments
Owner

Originally created by @jhollowe on GitHub (Mar 12, 2025).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

I have schedules with [ and ] in them, specifically starting with [M] for monthly schedules and [Y] for yearly. Before #4257, these schedules worked perfectly in my budget templates. in 25.3.0, these schedules are no longer correctly linked to the corresponding templates.

How can we reproduce the issue?

create a schedule named [M] test schedule and attempt to link it to a category with the template #template schedule [M] test schedule. This will work before 25.3.0 and fail after.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Windows 10

Originally created by @jhollowe on GitHub (Mar 12, 2025). ### Verified issue does not already exist? - [x] I have searched and found no existing issue ### What happened? I have schedules with `[` and `]` in them, specifically starting with `[M]` for monthly schedules and `[Y]` for yearly. Before #4257, these schedules worked perfectly in my budget templates. in 25.3.0, these schedules are no longer correctly linked to the corresponding templates. ### How can we reproduce the issue? create a schedule named `[M] test schedule` and attempt to link it to a category with the template `#template schedule [M] test schedule`. This will work before 25.3.0 and fail after. ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Chrome ### Operating System Windows 10
GiteaMirror added the buggoal templates labels 2026-02-28 19:59:57 -06:00
Author
Owner

@jhollowe commented on GitHub (Mar 12, 2025):

@MattFaz it looks like the regex for #4257 is causing my schedules (e.g. [M] test schedule) to fail. Could you look into making the regexes more selective in searching for [increase/decrease X%]?

@jhollowe commented on GitHub (Mar 12, 2025): @MattFaz it looks like the regex for #4257 is causing my schedules (e.g. `[M] test schedule`) to fail. Could you look into making the regexes more selective in searching for `[increase/decrease X%]`?
Author
Owner

@MattFaz commented on GitHub (Mar 17, 2025):

@jhollowe sorry for the slow reply, I'm currently travelling.

Makes sense, I hadn't anticipated that scenario and it didn't fail any existing tests. I will look into updating the regex to be more selective this week.

@MattFaz commented on GitHub (Mar 17, 2025): @jhollowe sorry for the slow reply, I'm currently travelling. Makes sense, I hadn't anticipated that scenario and it didn't fail any existing tests. I will look into updating the regex to be more selective this week.
Author
Owner

@jhollowe commented on GitHub (May 4, 2025):

Any update on this?

@jhollowe commented on GitHub (May 4, 2025): Any update on this?
Author
Owner

@MattFaz commented on GitHub (Jun 18, 2025):

@jhollowe I've created a PR to address this issue: https://github.com/actualbudget/actual/pull/5189
I've attached a screen recording showing the behavior has been fixed.

@MattFaz commented on GitHub (Jun 18, 2025): @jhollowe I've created a PR to address this issue: https://github.com/actualbudget/actual/pull/5189 I've attached a screen recording showing the behavior has been fixed.
Author
Owner

@jhollowe commented on GitHub (Jun 18, 2025):

Thanks @MattFaz!

@jhollowe commented on GitHub (Jun 18, 2025): Thanks @MattFaz!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1960