Empty commit to bump ci

* fix: crash on filtering by amount

* doc: add release notes

.cursor/rules/commands.mdc

@@ -0,0 +1,12 @@
+---
+alwaysApply: true
+---
+
+When running yarn commands - always run them in the root directory. Do not run them in child workspaces.
+
+The following commands can be useful:
+
+- `yarn typecheck` to run typechecker
+- `yarn lint` to run the code linter and formatter
+- `yarn lint:fix` to fix some of the code lint issues (running this is preferred over `yarn lint`)
+- `yarn test` to run all the tests

.cursor/rules/pull-request.mdc

@@ -1,24 +0,0 @@
----
-description: 
-globs: 
-alwaysApply: true
----
-Before pushing code changes or opening a pull request, follow these steps:
-
-1. Check if your branch already has a changelog file in the "upcoming-release-notes" folder.
-2. If there is no changelog file for your branch:
-   a. Find the number of the most recent (highest-numbered) open issue or pull request on GitHub.
-   b. Increment that number by 1. Use this as the filename for your new changelog file.
-   c. Create a new markdown file in the "upcoming-release-notes" folder with the following format:
-
-```
----
-category: Features OR Maintenance OR Enhancements OR Bugfix
-authors: [$GithubUsername]
----
-
-$Description
-```
-
-3. Commit the new changelog file.
-4. Proceed with your push or pull request.

.cursor/rules/typescript.mdc

@@ -30,3 +30,7 @@ Syntax and Formatting
 - Use the "function" keyword for pure functions.
 - Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.
 - Use declarative JSX, keeping JSX minimal and readable.
+
+Change validation
+
+- Run `yarn typecheck` in the root directory to validate that the generated TypeScript code is correct

.github/workflows/size-compare.yml

@@ -81,7 +81,7 @@ jobs:
           base-stats-json-path: ./base/web-stats.json
           title: desktop-client
 
-      - uses: github/webpack-bundlesize-compare-action@v2.1.0
+      - uses: twk3/rollup-size-compare-action@v1.1.1
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           current-stats-json-path: ./head/loot-core-stats.json

.prettierignore

@@ -7,6 +7,8 @@ packages/api/migrations
 packages/crdt/dist
 packages/component-library/src/icons/**/*
 packages/desktop-client/bundle.browser.js
+packages/desktop-client/stats.json
+packages/desktop-client/.swc/
 packages/desktop-client/build/
 packages/desktop-client/locale/
 packages/desktop-client/build-electron/
@@ -23,5 +25,6 @@ packages/desktop-electron/dist/
 packages/loot-core/**/node_modules/*
 packages/loot-core/**/lib-dist/*
 packages/loot-core/**/proto/*
+packages/sync-server/coverage/
 .yarn/*
 upcoming-release-notes/*

CODEOWNERS

@@ -0,0 +1,10 @@
+# CODEOWNERS file for Actual Budget
+# Please add your name to code-paths that you feel especially 
+# passionate about. You will be notified for any PRs there.
+
+/packages/api/                                    @MatissJanis
+/packages/component-library/                      @MatissJanis
+/packages/desktop-client/src/components/mobile    @joel-jeremy 
+/packages/desktop-electron/                       @MikesGlitch
+/packages/loot-core/src/server/budget             @youngcw
+/packages/sync-server/                            @matt-fidd

eslint.config.mjs

@@ -457,6 +457,7 @@ export default pluginTypescript.config(
         'warn',
         {
           varsIgnorePattern: '^(_|React)',
+          argsIgnorePattern: '^(_|React)',
           ignoreRestSiblings: true,
           caughtErrors: 'none',
         },

package.json

@@ -41,6 +41,7 @@
     "test:debug": "yarn workspaces foreach --all --verbose run test",
     "e2e": "yarn workspaces foreach --all --exclude desktop-electron --parallel --verbose run e2e",
     "e2e:desktop": "yarn build:desktop --skip-exe-build && yarn workspace desktop-electron e2e",
+    "playwright": "yarn workspace @actual-app/web run playwright",
     "vrt": "yarn workspaces foreach --all --parallel --verbose run vrt",
     "vrt:docker": "./bin/run-vrt",
     "rebuild-electron": "./node_modules/.bin/electron-rebuild -f -m ./packages/loot-core",

packages/component-library/src/View.tsx

@@ -23,7 +23,11 @@ export const View = forwardRef<HTMLDivElement, ViewProps>((props, ref) => {
       {...restProps}
       ref={innerRef ?? ref}
       style={nativeStyle}
-      className={cx('view', className, css(style))}
+      className={cx(
+        'view',
+        className,
+        style && Object.keys(style).length > 0 ? css(style) : undefined,
+      )}
     />
   );
 });

packages/crdt/src/index.ts

@@ -1,4 +1,6 @@
-import * as SyncPb from './proto/sync_pb';
+/* eslint-disable @typescript-eslint/no-explicit-any */
+import './proto/sync_pb.js'; // Import for side effects
+
 export {
   merkle,
   getClock,
@@ -11,4 +13,11 @@ export {
   Timestamp,
 } from './crdt';
 
-export const SyncProtoBuf = SyncPb;
+// Access global proto namespace
+export const SyncRequest = (globalThis as any).proto.SyncRequest;
+export const SyncResponse = (globalThis as any).proto.SyncResponse;
+export const Message = (globalThis as any).proto.Message;
+export const MessageEnvelope = (globalThis as any).proto.MessageEnvelope;
+export const EncryptedData = (globalThis as any).proto.EncryptedData;
+
+export const SyncProtoBuf = (globalThis as any).proto;

packages/desktop-client/e2e/command-bar.test.ts

@@ -0,0 +1,77 @@
+import { type Page } from '@playwright/test';
+
+import { expect, test } from './fixtures';
+import { ConfigurationPage } from './page-models/configuration-page';
+
+test.describe('Command bar', () => {
+  let page: Page;
+  let configurationPage: ConfigurationPage;
+
+  test.beforeAll(async ({ browser }) => {
+    page = await browser.newPage();
+    configurationPage = new ConfigurationPage(page);
+
+    await page.goto('/');
+    await configurationPage.createTestFile();
+
+    // Move mouse to corner of the screen;
+    // sometimes the mouse hovers on a budget element thus rendering an input box
+    // and this breaks screenshot tests
+    await page.mouse.move(0, 0);
+
+    // ensure page is loaded
+    await expect(page.getByTestId('budget-table')).toBeVisible();
+    await expect(page.getByRole('button', { name: 'Add group' })).toBeVisible({
+      timeout: 10000,
+    });
+  });
+
+  test.afterAll(async () => {
+    await page.close();
+  });
+
+  test('Check the command bar visuals', async () => {
+    // Open the command bar
+    await page.keyboard.press('ControlOrMeta+k');
+    const commandBar = page.getByRole('combobox', {
+      name: 'Command Bar',
+    });
+
+    await expect(commandBar).toBeVisible();
+    await expect(page).toMatchThemeScreenshots();
+
+    // Close the command bar
+    await page.keyboard.press('Escape');
+    await expect(commandBar).not.toBeVisible();
+  });
+
+  test('Check the command bar search works correctly', async () => {
+    await page.keyboard.press('ControlOrMeta+k');
+
+    const commandBar = page.getByRole('combobox', {
+      name: 'Command Bar',
+    });
+
+    await expect(commandBar).toBeVisible();
+    await expect(commandBar).toHaveValue('');
+
+    // Search and navigate to reports
+    await commandBar.fill('reports');
+    await page.keyboard.press('Enter');
+    await expect(page.getByTestId('reports-page')).toBeVisible();
+    await expect(page.getByText('Loading reports...')).not.toBeVisible(); // wait for screen to load
+
+    // Navigate to schedule page
+    await page.keyboard.press('ControlOrMeta+k');
+    await page.keyboard.press('ArrowDown');
+    await page.keyboard.press('ArrowDown'); // Select second suggestion - Schedules
+    await expect(page).toMatchThemeScreenshots();
+
+    await page.keyboard.press('Enter');
+    await expect(
+      page.getByRole('button', {
+        name: 'Add new schedule',
+      }),
+    ).toBeVisible();
+  });
+});

packages/desktop-client/e2e/page-models/mobile-transaction-entry-page.ts

@@ -6,6 +6,7 @@ export class MobileTransactionEntryPage {
   readonly page: Page;
   readonly header: Locator;
   readonly amountField: Locator;
+  readonly globalAmountField: Locator;
   readonly transactionForm: Locator;
   readonly footer: Locator;
   readonly addTransactionButton: Locator;
@@ -15,6 +16,7 @@ export class MobileTransactionEntryPage {
     this.header = page.getByRole('heading');
     this.transactionForm = page.getByTestId('transaction-form');
     this.amountField = this.transactionForm.getByTestId('amount-input');
+    this.globalAmountField = page.getByTestId('navigable-focus-input');
     this.footer = page.getByTestId('transaction-form-footer');
     this.addTransactionButton = this.footer.getByRole('button', {
       name: 'Add transaction',