github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3260] [CLOSED] [PM-8372] Generate higher minimum number/special character values #52337

New Issue
Closed
opened 2026-05-01 16:17:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 16:17:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3260
Author: @b02860de585071a2
Created: 5/24/2024
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (10+)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/Core/Pages/Generator/GeneratorPage.xaml (+2 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes https://github.com/bitwarden/mobile/issues/3259

Code changes

Context: see desktop blob and mobile blob for comparison.

  • src/Core/Pages/Generator/GeneratorPage.xaml: Change max value of MinNumber and MinSpecial (5 -> 9)

I have built and tested this on Android 13 and 14, armeabi-v7a and arm64-v8a. I do not have the ability to test an iOS build, but it should be an equally easy fix.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3260 **Author:** [@b02860de585071a2](https://github.com/b02860de585071a2) **Created:** 5/24/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`7043be6`](https://github.com/bitwarden/android/commit/7043be67dda8fba618db19168c3776a503dfdea7) Update CODEOWNERS (#2701) - [`e274c04`](https://github.com/bitwarden/android/commit/e274c0410749a8c87ec35abce47b9e58bf3ce43c) [PM-3513] Show error SSO policy (#2707) - [`8cae840`](https://github.com/bitwarden/android/commit/8cae840c68082907f9fef7c662450d898edd0f7a) Autosync the updated translations (#2704) - [`249406e`](https://github.com/bitwarden/android/commit/249406e3a8c43624736696dbd4da19987aef9388) [PM-3545] Fix biometric unlock for autofill (#2710) - [`e30f990`](https://github.com/bitwarden/android/commit/e30f9903d13cfa60e6e29433e01d7695cb6897c5) fix for TDE pref naming collision (#2712) - [`9c7ff85`](https://github.com/bitwarden/android/commit/9c7ff853d726a895c61d9af5e462f3b796676a3b) Autosync the updated translations (#2720) - [`819aabb`](https://github.com/bitwarden/android/commit/819aabb33020b9d7039554ebe64b4620ee932cc2) don't clear key needed for bio/auto migration in pin migration (#2721) - [`7ec5c8c`](https://github.com/bitwarden/android/commit/7ec5c8ccfdf2ae97a7b7cc8fd18306578e366627) Bumped version to 2023.8.0 (#2725) - [`47be3d6`](https://github.com/bitwarden/android/commit/47be3d6aef1bf46cc3b3103dbc22b2a133a27a03) Bumped version to 2023.8.1 (#2730) - [`68759fc`](https://github.com/bitwarden/android/commit/68759fc60829bcf8937c4268bbbfd4e6d16cfd00) [PM-3547] Change logic to set user key for inactive account (#2715) ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Generator/GeneratorPage.xaml` (+2 -2) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fixes https://github.com/bitwarden/mobile/issues/3259 ## Code changes Context: see [desktop blob](https://github.com/bitwarden/clients/blob/main/apps%2Fdesktop%2Fsrc%2Fapp%2Ftools%2Fgenerator.component.html#L282-L305) and [mobile blob](https://github.com/bitwarden/mobile/blob/main/src%2FCore%2FPages%2FGenerator%2FGeneratorPage.xaml#L497-L525) for comparison. * `src/Core/Pages/Generator/GeneratorPage.xaml`: Change max value of `MinNumber` and `MinSpecial` (5 -> 9) I have built and tested this on Android 13 and 14, armeabi-v7a and arm64-v8a. I do not have the ability to test an iOS build, but it should be an equally easy fix. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 16:17:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?