github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1048] [MERGED] Fix auto biometric prompt on vault timeout #2720

New Issue
Closed
opened 2025-11-26 23:23:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1048
Author: @aaxdev
Created: 8/22/2020
Status: ✅ Merged
Merged: 12/21/2020
Merged by: @kspearrin

Base: master ← Head: issue/auto-biometric-prompt-vault-timeout

📝 Commits (3)

  • 67663d7 Fix auto biometric prompt on vault timeout
  • 9d5008e Revert "Fix auto biometric prompt on vault timeout"
  • 61a2c2b Let biometric prompt on vault timeout (android)

📊 Changes

1 file changed (+0 additions, -4 deletions)

View changed files

📝 src/App/App.xaml.cs (+0 -4)

📄 Description

A condition force to not show the auto biometric prompt (https://github.com/bitwarden/mobile/issues/1045).

This condition don't change the case about when you lock manually the vault from settings page or app bar, because the value of the function parameter is false in those cases, and the prompt is not shown, as expected.

However, in the case that the vault is not locked and you hit the home button or when you lock the phone screen, the value of the function parameter is true, and the condition set it on false, then the prompt will not be shown when you'll access back to the app. Whatever vault timeout selected, it's happen when the vault timed out. When it sets to "Immediatly" this behavior is annoying when you want to switch to another app and go back to it.

GIF issue (expand)

gif

I don't get this issue on iOS version, it's maybe due to the sub condition vaultTimeout, i have always his value on null when i try it on Android but since i don't have any Mac environment, i can't debug it on iOS.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1048 **Author:** [@aaxdev](https://github.com/aaxdev) **Created:** 8/22/2020 **Status:** ✅ Merged **Merged:** 12/21/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `issue/auto-biometric-prompt-vault-timeout` --- ### 📝 Commits (3) - [`67663d7`](https://github.com/bitwarden/android/commit/67663d7be9fa6a5bf7486c6237d85d7556dcccb9) Fix auto biometric prompt on vault timeout - [`9d5008e`](https://github.com/bitwarden/android/commit/9d5008eba851bb5957ce738b7790b00782ae0a47) Revert "Fix auto biometric prompt on vault timeout" - [`61a2c2b`](https://github.com/bitwarden/android/commit/61a2c2b1631248cb8aab298179764c2229da71c3) Let biometric prompt on vault timeout (android) ### 📊 Changes **1 file changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+0 -4) </details> ### 📄 Description A condition force to not show the auto biometric prompt (https://github.com/bitwarden/mobile/issues/1045). This condition don't change the case about when you lock manually the vault from settings page or app bar, because the value of the function parameter is false in those cases, and the prompt is not shown, as expected. However, in the case that the vault is not locked and you hit the home button or when you lock the phone screen, the value of the function parameter is true, and the condition set it on false, then the prompt will not be shown when you'll access back to the app. Whatever vault timeout selected, it's happen when the vault timed out. When it sets to "Immediatly" this behavior is annoying when you want to switch to another app and go back to it. <details> <summary>GIF issue (expand)</summary> ![gif](https://i.gyazo.com/0a32a289e100f62ab74882ab2ee894f5.gif) </details> I don't get this issue on iOS version, it's maybe due to the sub condition vaultTimeout, i have always his value on null when i try it on Android but since i don't have any Mac environment, i can't debug it on iOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2720
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?