github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1005] [MERGED] Modified Permissions Flow #2704

New Issue
Closed
opened 2025-11-26 23:22:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1005
Author: @MattTheDev
Created: 7/8/2020
Status: ✅ Merged
Merged: 7/8/2020
Merged by: @MattTheDev

Base: master ← Head: android-camera-permissions-flow

📝 Commits (1)

  • 38bcd7d Modified Permissions Flow

📊 Changes

3 files changed (+31 additions, -2 deletions)

View changed files

📝 src/Android/MainActivity.cs (+2 -2)
📝 src/App/Pages/Vault/AddEditPage.xaml.cs (+8 -0)
➕ src/App/Utilities/PermissionManager.cs (+21 -0)

📄 Description

Objective

Permissions flow for Android was causing the white screen on initial permission grant on occasion. Moved permission grant to pre-TOTP page load. This resvoles #975

Code Changes

src/Android/MainActivity.cs - ZXing.Net.Mobile.Forms.Android.PermissionsHandler.OnRequestPermissionsResult was deprecated, and with new flow, was hanging. I've modified this to point to the new method.

src/App/Pages/Vault/AddEditPage.xaml.cs - Added permissions check on click to confirm access to camera. If access is denied, return to add page.

src/App/Utilities/PermissionManager.cs - Added static method for checking/requesting permissions using Xamarin Essentials, for this use case and potential future consumption.

Known Issues (Must Fix)

  • None known. Requesting a test on a physical device before merging with master to confirm. Emulator runs without issue. Physical device confirmation would be preferred.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1005 **Author:** [@MattTheDev](https://github.com/MattTheDev) **Created:** 7/8/2020 **Status:** ✅ Merged **Merged:** 7/8/2020 **Merged by:** [@MattTheDev](https://github.com/MattTheDev) **Base:** `master` ← **Head:** `android-camera-permissions-flow` --- ### 📝 Commits (1) - [`38bcd7d`](https://github.com/bitwarden/android/commit/38bcd7def72a2f69293dbeb66fcee45d1ba9595d) Modified Permissions Flow ### 📊 Changes **3 files changed** (+31 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+2 -2) 📝 `src/App/Pages/Vault/AddEditPage.xaml.cs` (+8 -0) ➕ `src/App/Utilities/PermissionManager.cs` (+21 -0) </details> ### 📄 Description ## Objective Permissions flow for Android was causing the white screen on initial permission grant on occasion. Moved permission grant to pre-TOTP page load. This resvoles #975 ## Code Changes **src/Android/MainActivity.cs** - ZXing.Net.Mobile.Forms.Android.PermissionsHandler.OnRequestPermissionsResult was deprecated, and with new flow, was hanging. I've modified this to point to the new method. **src/App/Pages/Vault/AddEditPage.xaml.cs** - Added permissions check on click to confirm access to camera. If access is denied, return to add page. **src/App/Utilities/PermissionManager.cs** - Added static method for checking/requesting permissions using Xamarin Essentials, for this use case and potential future consumption. ## Known Issues (Must Fix) * None known. Requesting a test on a physical device before merging with master to confirm. Emulator runs without issue. Physical device confirmation would be preferred. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2704
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?