[PR #1011] [MERGED] [KnownUsernameField] Engine update (make the system more flexible) #2707

New Issue

GiteaMirror · 2025-11-26T23:22:59-06:00

GiteaMirror commented

2025-11-26 23:22:59 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1011
Author: @contribucious
Created: 7/14/2020
Status: ✅ Merged
Merged: 8/6/2020
Merged by: @cscharf

Base: master ← Head: KnownUsernameField--engine-update--flexibility

📝 Commits (5)

c2950b5 [KnownUsernameField] Engine update (make the system more flexible)
c1ecf77 [KnownUsernameField] Engine update (make the system more flexible)
057fd6b Use of tuples array instead of multidimensional array (string[,])
cab87a9 Use of tuples array instead of multidimensional array (string[,])
bbf7b70 [FIX] IndexOf -> Contains

📊 Changes

2 files changed (+64 additions, -17 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+61 -12)
📝 src/Android/Accessibility/KnownUsernameField.cs (+3 -5)

📄 Description

CONTEXT: This is an update of this new system (system allowing "user ID" field detection — i.e. email/username/phone/whatever — without "password" field using the accessibility service).

UPDATED: Engine.
↪️ Prerequisite for my next PR which concerns the entries.

This:

allows to have multiple pairs "path / username view ID" per domain;
adds more advanced path support:
- in its case-sensitive version: startswith:string, contains:string, endswith:string and
- in its case-insensitive version: istartswith:string, icontains:string, iendswith:string.

💡 About using StringComparison.Ordinal and StringComparison.OrdinalIgnoreCase, this is recommended for a variety of reasons including better performance. See the page Best Practices for Using Strings in .NET from Microsoft documentation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1011 **Author:** [@contribucious](https://github.com/contribucious) **Created:** 7/14/2020 **Status:** ✅ Merged **Merged:** 8/6/2020 **Merged by:** [@cscharf](https://github.com/cscharf) **Base:** `master` ← **Head:** `KnownUsernameField--engine-update--flexibility` --- ### 📝 Commits (5) - [`c2950b5`](https://github.com/bitwarden/android/commit/c2950b5896e9b69aeed3ae279f68731626ead2dd) [KnownUsernameField] Engine update (make the system more flexible) - [`c1ecf77`](https://github.com/bitwarden/android/commit/c1ecf773f8567a48f6e4b1387b112716aa140889) [KnownUsernameField] Engine update (make the system more flexible) - [`057fd6b`](https://github.com/bitwarden/android/commit/057fd6bbf7baabfca2d054f290562c624ffce8f4) Use of tuples array instead of multidimensional array (string[,]) - [`cab87a9`](https://github.com/bitwarden/android/commit/cab87a91cdc92dc39f9e94ffb328d6c308f0fc20) Use of tuples array instead of multidimensional array (string[,]) - [`bbf7b70`](https://github.com/bitwarden/android/commit/bbf7b7048095931a6ec000a26b2e1beb58fe1d1b) [FIX] IndexOf -> Contains ### 📊 Changes **2 files changed** (+64 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+61 -12) 📝 `src/Android/Accessibility/KnownUsernameField.cs` (+3 -5) </details> ### 📄 Description **CONTEXT:** This is an update of [this new system](https://github.com/bitwarden/mobile/pull/880) _(system allowing "user ID" field detection — i.e. email/username/phone/whatever — without "password" field using the accessibility service)_. **UPDATED:** Engine. :arrow_right_hook: _Prerequisite for my next PR which concerns the **entries**._ ___   **This:** - allows to have multiple pairs "path / username view ID" per domain; - adds more advanced path support: - in its case-sensitive version: `startswith:string`, `contains:string`, `endswith:string` and - in its case-insensitive version: `istartswith:string`, `icontains:string`, `iendswith:string`.   :bulb: About using `StringComparison.Ordinal` and `StringComparison.OrdinalIgnoreCase`, this is recommended for a variety of reasons including better performance. See the page [Best Practices for Using Strings in .NET](https://docs.microsoft.com/en-us/dotnet/standard/base-types/best-practices-strings#recommendations-for-string-usage) from Microsoft documentation.     --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:22:59 -06:00

GiteaMirror closed this issue