github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1073] [MERGED] reposition buttons in Log In and Unlock pages #2730

New Issue
Closed
opened 2025-11-26 23:23:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:19 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1073
Author: @eliykat
Created: 9/17/2020
Status: ✅ Merged
Merged: 11/12/2020
Merged by: @mpbw2

Base: master ← Head: feature-improve-login-ui

📝 Commits (3)

  • d4d5b7a reposition buttons in Log In and Unlock pages
  • 60ecf56 finish changes to improved login ui
  • 7a3d15f Merge branch 'master' into feature-improve-login-ui

📊 Changes

7 files changed (+74 additions, -15 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPage.xaml (+10 -2)
📝 src/App/Pages/Accounts/LockPage.xaml.cs (+26 -0)
📝 src/App/Pages/Accounts/LoginPage.xaml (+11 -3)
📝 src/App/Pages/Accounts/LoginPage.xaml.cs (+26 -0)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+1 -8)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+0 -1)
📝 src/iOS.Extension/LoadingViewController.cs (+0 -1)

📄 Description

Description

I have repositioned the buttons in the Log In and Unlock (i.e. Verify Master Password) pages as discussed in this Community Forums thread. The intention of this is to improve the positioning of primary buttons and the UX flow as the user moves through these pages.

Log In page: move Log In button to primary location below password entry, move Get Your Master Password Hint to the More Options menu. Screenshot

Unlock page (Verify Master Password): swap position of Unlock and Log Out buttons. Screenshot

Changes not implemented

In the Community Forums thread, we discussed putting an icon on the Unlock button and changing the theming of primary buttons (i.e. to use the Bitwarden colour scheme rather than the current grey).

However, this was more complicated than anticipated to implement properly and to get it looking good across all devices. I also think that any change to button theming should be implemented consistently across the app, as these buttons appear in other places that were not the subject of this contribution. I still think this needs to be changed, but it should be a separate contribution so that it can be properly considered and implemented consistently across the app.

Testing

I have tested this in iOS and Android and it all works well subject to the following.

It appears that the Get Your Master Password Hint button is hidden when launching the login flow a certain way in iOS. See the changes to CredentialProviderViewController.cs and LoadingViewController.cs. I have updated these references as required but I was unable to test them because of issues with my iOS development environment. (Briefly, I don't have a provisioning profile or Apple Developer account, so I had to disable custom entitlements to get this to build, which broke certain features of the app such as autofill.) I recommend someone does a quick test of this login flow before accepting the PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1073 **Author:** [@eliykat](https://github.com/eliykat) **Created:** 9/17/2020 **Status:** ✅ Merged **Merged:** 11/12/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature-improve-login-ui` --- ### 📝 Commits (3) - [`d4d5b7a`](https://github.com/bitwarden/android/commit/d4d5b7a0e535c22dd59bf2362ef1d5bb63bed18e) reposition buttons in Log In and Unlock pages - [`60ecf56`](https://github.com/bitwarden/android/commit/60ecf56922824ae472e60738a8873ae2825d5d30) finish changes to improved login ui - [`7a3d15f`](https://github.com/bitwarden/android/commit/7a3d15fd3e77a28e6a7d5d9d70fb2d715311a620) Merge branch 'master' into feature-improve-login-ui ### 📊 Changes **7 files changed** (+74 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPage.xaml` (+10 -2) 📝 `src/App/Pages/Accounts/LockPage.xaml.cs` (+26 -0) 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+11 -3) 📝 `src/App/Pages/Accounts/LoginPage.xaml.cs` (+26 -0) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+1 -8) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+0 -1) 📝 `src/iOS.Extension/LoadingViewController.cs` (+0 -1) </details> ### 📄 Description ## Description I have repositioned the buttons in the Log In and Unlock (i.e. Verify Master Password) pages as discussed in [this Community Forums thread](https://community.bitwarden.com/t/reposition-buttons-in-verify-master-password-and-log-in-screens-on-mobile/14326). The intention of this is to improve the positioning of primary buttons and the UX flow as the user moves through these pages. *Log In page:* move Log In button to primary location below password entry, move Get Your Master Password Hint to the More Options menu. [Screenshot](https://user-images.githubusercontent.com/31796059/93534423-6561d400-f988-11ea-803c-237a11d79e4c.PNG) *Unlock page (Verify Master Password):* swap position of Unlock and Log Out buttons. [Screenshot](https://user-images.githubusercontent.com/31796059/93534441-6e52a580-f988-11ea-82a2-bddc5bf2f909.PNG) ## Changes not implemented In the Community Forums thread, we discussed putting an icon on the Unlock button and changing the theming of primary buttons (i.e. to use the Bitwarden colour scheme rather than the current grey). However, this was more complicated than anticipated to implement properly and to get it looking good across all devices. I also think that any change to button theming should be implemented consistently across the app, as these buttons appear in other places that were not the subject of this contribution. I still think this needs to be changed, but it should be a separate contribution so that it can be properly considered and implemented consistently across the app. ## Testing I have tested this in iOS and Android and it all works well subject to the following. It appears that the Get Your Master Password Hint button is hidden when launching the login flow a certain way in iOS. See the changes to CredentialProviderViewController.cs and LoadingViewController.cs. I have updated these references as required but I was unable to test them because of issues with my iOS development environment. (Briefly, I don't have a provisioning profile or Apple Developer account, so I had to disable custom entitlements to get this to build, which broke certain features of the app such as autofill.) I recommend someone does a quick test of this login flow before accepting the PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2730
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?