github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1037] [MERGED] Biometric integrity check always fails #2715

New Issue
Closed
opened 2025-11-26 23:23:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1037
Author: @Hinton
Created: 8/12/2020
Status: ✅ Merged
Merged: 8/12/2020
Merged by: @cscharf

Base: master ← Head: hotfix/biometric-invalidation

📝 Commits (1)

  • 0f8af7e Return the correct value for valid biometric

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Android/Services/BiometricService.cs (+1 -1)

📄 Description

During testing I accidentally reversed the expected result from ValidateIntegrityAsync. (Emulator has issues with detecting biometric changes, so to verify the message I inverted the check)

Should solve https://github.com/bitwarden/mobile/pull/1026#issuecomment-672996129

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1037 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 8/12/2020 **Status:** ✅ Merged **Merged:** 8/12/2020 **Merged by:** [@cscharf](https://github.com/cscharf) **Base:** `master` ← **Head:** `hotfix/biometric-invalidation` --- ### 📝 Commits (1) - [`0f8af7e`](https://github.com/bitwarden/android/commit/0f8af7ec46612e826a14498974636507a35e2d8d) Return the correct value for valid biometric ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/BiometricService.cs` (+1 -1) </details> ### 📄 Description During testing I accidentally reversed the expected result from `ValidateIntegrityAsync`. (Emulator has issues with detecting biometric changes, so to verify the message I inverted the check) Should solve https://github.com/bitwarden/mobile/pull/1026#issuecomment-672996129 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2715
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?