github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 00:09:31 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3265] [CLOSED] [PM-950] Cannot save new login if personal ownership is disabled #34624

New Issue
Closed
opened 2026-04-21 02:09:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:09:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3265
Author: @LRNcardozoWDF
Created: 5/28/2024
Status: ❌ Closed

Base: main ← Head: vault/pm-950

📝 Commits (10+)

  • 249406e [PM-3545] Fix biometric unlock for autofill (#2710)
  • e30f990 fix for TDE pref naming collision (#2712)
  • 9c7ff85 Autosync the updated translations (#2720)
  • 819aabb don't clear key needed for bio/auto migration in pin migration (#2721)
  • 7ec5c8c Bumped version to 2023.8.0 (#2725)
  • 47be3d6 Bumped version to 2023.8.1 (#2730)
  • 68759fc [PM-3547] Change logic to set user key for inactive account (#2715)
  • 4d0f9d1 [PM-3543] [PM-3607] Fix password re-prompt when editing and on autofill. (#2713)
  • dbadf8c [PM-3222] Migration of data from LiteDB to shared pref storage (#2724)
  • 6d4792b Autosync the updated translations (#2741)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes https://github.com/bitwarden/mobile/issues/1874

Add the ability to select a collection for the new item if personal ownership is disabled.

Code changes

  • LoginAddViewController.cs: Refactor how the number of rows and sections are calculated based on the value of the flag _personalOwnershipPolicyApplies. Added cells to warn the user the personal ownership is disabled and allow organisation and collection selection.
  • FormEntryTableViewCell.cs: Allow a form entry empty.

Screenshots

BEFORE
image

AFTER
image
image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3265 **Author:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Created:** 5/28/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `vault/pm-950` --- ### 📝 Commits (10+) - [`249406e`](https://github.com/bitwarden/android/commit/249406e3a8c43624736696dbd4da19987aef9388) [PM-3545] Fix biometric unlock for autofill (#2710) - [`e30f990`](https://github.com/bitwarden/android/commit/e30f9903d13cfa60e6e29433e01d7695cb6897c5) fix for TDE pref naming collision (#2712) - [`9c7ff85`](https://github.com/bitwarden/android/commit/9c7ff853d726a895c61d9af5e462f3b796676a3b) Autosync the updated translations (#2720) - [`819aabb`](https://github.com/bitwarden/android/commit/819aabb33020b9d7039554ebe64b4620ee932cc2) don't clear key needed for bio/auto migration in pin migration (#2721) - [`7ec5c8c`](https://github.com/bitwarden/android/commit/7ec5c8ccfdf2ae97a7b7cc8fd18306578e366627) Bumped version to 2023.8.0 (#2725) - [`47be3d6`](https://github.com/bitwarden/android/commit/47be3d6aef1bf46cc3b3103dbc22b2a133a27a03) Bumped version to 2023.8.1 (#2730) - [`68759fc`](https://github.com/bitwarden/android/commit/68759fc60829bcf8937c4268bbbfd4e6d16cfd00) [PM-3547] Change logic to set user key for inactive account (#2715) - [`4d0f9d1`](https://github.com/bitwarden/android/commit/4d0f9d1c035e7af2ddaacb667c64e87cc9cad9b2) [PM-3543] [PM-3607] Fix password re-prompt when editing and on autofill. (#2713) - [`dbadf8c`](https://github.com/bitwarden/android/commit/dbadf8c56f724f53a1a19dbbec573189988813af) [PM-3222] Migration of data from LiteDB to shared pref storage (#2724) - [`6d4792b`](https://github.com/bitwarden/android/commit/6d4792bc24cf5daf9270fa07f9d8596245f5086f) Autosync the updated translations (#2741) ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fixes https://github.com/bitwarden/mobile/issues/1874 Add the ability to select a collection for the new item if personal ownership is disabled. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **LoginAddViewController.cs:** Refactor how the number of rows and sections are calculated based on the value of the flag `_personalOwnershipPolicyApplies`. Added cells to warn the user the personal ownership is disabled and allow organisation and collection selection. * **FormEntryTableViewCell.cs:** Allow a form entry empty. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> **BEFORE** <img width="322" alt="image" src="https://github.com/bitwarden/mobile/assets/6855596/1e59f8d3-5a62-4d67-8b97-aa8a7368f913"> **AFTER** <img width="322" alt="image" src="https://github.com/bitwarden/mobile/assets/6855596/1b0b16f0-9ad7-435a-8b3a-f00bfcd3d584"> <img width="322" alt="image" src="https://github.com/bitwarden/mobile/assets/6855596/952763e8-527b-45ff-823f-6f7ac6f902e8"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:09:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34624
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?