github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 12:13:43 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1027] [MERGED] Fix Pin cannot be hidden after showing it #1025 #2713

New Issue
Closed
opened 2025-11-26 23:23:05 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:05 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1027
Author: @cscharf
Created: 7/30/2020
Status: ✅ Merged
Merged: 7/30/2020
Merged by: @cscharf

Base: master ← Head: fix/1025-pin-connect-be-hidden-after-showing-it

📝 Commits (1)

📊 Changes

1 file changed (+7 additions, -3 deletions)

View changed files

📝 src/Android/Renderers/CustomEntryRenderer.cs (+7 -3)

📄 Description

Fixes #1025

Overview

Xamarin Forms handles the scenario where a Numeric keyboard type + IsPassword setting properly sets the native Android Input Type between Numeric vs. NumericPassword. This is overridden by BW's custom entry renderer's implementation which maps custom fonts and behavior for Android.

This change adds the scenario to handle a PIN style (numeric keyboard) which should be masked/password and can be toggled accordingly.

image

image

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1027 **Author:** [@cscharf](https://github.com/cscharf) **Created:** 7/30/2020 **Status:** ✅ Merged **Merged:** 7/30/2020 **Merged by:** [@cscharf](https://github.com/cscharf) **Base:** `master` ← **Head:** `fix/1025-pin-connect-be-hidden-after-showing-it` --- ### 📝 Commits (1) - [`7fd05ed`](https://github.com/bitwarden/android/commit/7fd05ed9e4ba1a69531e7e9badfa7de1e56c9a0d) Fix Pin cannot be hidden after showing it #1025 ### 📊 Changes **1 file changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Renderers/CustomEntryRenderer.cs` (+7 -3) </details> ### 📄 Description Fixes #1025 ## Overview Xamarin Forms handles the scenario where a Numeric keyboard type + IsPassword setting properly sets the native Android Input Type between Numeric vs. NumericPassword. This is overridden by BW's custom entry renderer's implementation which maps custom fonts and behavior for Android. This change adds the scenario to handle a PIN style (numeric keyboard) which should be masked/password and can be toggled accordingly. ![image](https://user-images.githubusercontent.com/3904944/88946143-e50ed480-d25c-11ea-9a2f-52c1f4a3d4d2.png) ![image](https://user-images.githubusercontent.com/3904944/88946200-f35cf080-d25c-11ea-9c74-f9d93938b475.png) ![image](https://user-images.githubusercontent.com/3904944/88946246-fe178580-d25c-11ea-86a8-4df27c76dfab.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2713
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?