github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3223] [CLOSED] [PM-7931] Update CipherAddEditPageViewModel.cs #34603

New Issue
Closed
opened 2026-04-21 02:08:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:08:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3223
Author: @SergBarkovskii
Created: 5/4/2024
Status: ❌ Closed

Base: main ← Head: add-cards

📝 Commits (10+)

  • 0271a4d Autosync the updated translations (#2650)
  • 5aaff1e PM-3249 Removed back button from block autofill uris to be aligned to other views (#2654)
  • c4e64e0 Autosync the updated translations (#2660)
  • c34d1da PM-3298 Updated region selector to be logging in on and also its options (#2657)
  • ec93a61 [PM-3092] Clarify argon2 ios autofill warning (#2630)
  • eea7c6b [PM-2901] Synchronize sends on send creation/update/deletion notification (#2606)
  • 6d4793d [PM-1768] Set up CODEOWNERS file (#2464)
  • 420dc09 Update codeowners (#2691)
  • f426c0e Create section for crowdin sync (#2692)
  • 8474f53 Autosync the updated translations (#2677)

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 src/Core/Pages/Vault/CipherAddEditPageViewModel.cs (+4 -2)

📄 Description

Adding DinaCard & Mir cards

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Adding DinaCard and Mir cards which are currently missed

Code changes

Added two lines and sorted cards (except most popular Visa and Mastercard) by lines Ascending

  • file.ext: Description of what was changed and why
    CipherAddEditPageViewModel.cs: Added DinaCard and Mir cards which are currently missed

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3223 **Author:** [@SergBarkovskii](https://github.com/SergBarkovskii) **Created:** 5/4/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `add-cards` --- ### 📝 Commits (10+) - [`0271a4d`](https://github.com/bitwarden/android/commit/0271a4db4ce6f18fda928c6328d64fb56ca32835) Autosync the updated translations (#2650) - [`5aaff1e`](https://github.com/bitwarden/android/commit/5aaff1ea2014909d870857042f67245f312ca4b4) PM-3249 Removed back button from block autofill uris to be aligned to other views (#2654) - [`c4e64e0`](https://github.com/bitwarden/android/commit/c4e64e082b8b9fd84f32d5fb4238c292aba9c2ab) Autosync the updated translations (#2660) - [`c34d1da`](https://github.com/bitwarden/android/commit/c34d1da6e64ee7b07d77cf57af2b4072fa81d332) PM-3298 Updated region selector to be logging in on and also its options (#2657) - [`ec93a61`](https://github.com/bitwarden/android/commit/ec93a612755099b8f652baa2ae12dd72056fbcdf) [PM-3092] Clarify argon2 ios autofill warning (#2630) - [`eea7c6b`](https://github.com/bitwarden/android/commit/eea7c6b7d72f96b6d3acbd71c6357dcf3a472344) [PM-2901] Synchronize sends on send creation/update/deletion notification (#2606) - [`6d4793d`](https://github.com/bitwarden/android/commit/6d4793d5928e90137aa0d717007d5868d740be44) [PM-1768] Set up CODEOWNERS file (#2464) - [`420dc09`](https://github.com/bitwarden/android/commit/420dc09fd147275b89a67e697c10f1e14b8be056) Update codeowners (#2691) - [`f426c0e`](https://github.com/bitwarden/android/commit/f426c0e37042aeae73fdc8b1c6bb494818b21e01) Create section for crowdin sync (#2692) - [`8474f53`](https://github.com/bitwarden/android/commit/8474f536ffe47491b93898664f48d8c86c3b5f52) Autosync the updated translations (#2677) ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Vault/CipherAddEditPageViewModel.cs` (+4 -2) </details> ### 📄 Description Adding DinaCard & Mir cards ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Adding DinaCard and Mir cards which are currently missed ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Added two lines and sorted cards (except most popular Visa and Mastercard) by lines Ascending * **file.ext:** Description of what was changed and why CipherAddEditPageViewModel.cs: Added DinaCard and Mir cards which are currently missed ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:08:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?