github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 03:09:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #912] [MERGED] Removal of lifecycle hack for 2FA resume flow #2654

New Issue
Closed
opened 2025-11-26 23:22:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/912
Author: @mpbw2
Created: 5/20/2020
Status: ✅ Merged
Merged: 5/20/2020
Merged by: @mpbw2

Base: master ← Head: hack-removal

📝 Commits (1)

  • 2c953d2 Removal of lifecycle hack for 2FA resume flow

📊 Changes

2 files changed (+0 additions, -22 deletions)

View changed files

📝 src/App/App.xaml.cs (+0 -21)
📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+0 -1)

📄 Description

Confirmed this is no longer necessary with the version of Forms we're using. (Flow is also snappier without the hack, making for an improved experience)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/912 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 5/20/2020 **Status:** ✅ Merged **Merged:** 5/20/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `hack-removal` --- ### 📝 Commits (1) - [`2c953d2`](https://github.com/bitwarden/android/commit/2c953d241647409712305d623f6f065e84389058) Removal of lifecycle hack for 2FA resume flow ### 📊 Changes **2 files changed** (+0 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+0 -21) 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+0 -1) </details> ### 📄 Description Confirmed this is no longer necessary with the version of Forms we're using. (Flow is also snappier without the hack, making for an improved experience) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2654
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?