github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #977] [MERGED] Resolve passwords being hidden in upgrade path #2691

New Issue
Closed
opened 2025-11-26 23:22:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/977
Author: @Hinton
Created: 6/12/2020
Status: ✅ Merged
Merged: 6/12/2020
Merged by: @cscharf

Base: master ← Head: hotfix/hidden-passwords

📝 Commits (1)

  • 61fffb2 Resolve all passwords being hidden after upgrade

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Core/Models/Data/CipherData.cs (+1 -1)

📄 Description

Resolves #973.

When a vault is synced, the content is stored using the Data models, since the fallback path relied on CipherResponse defaulting the value, this did not happen for content already synced. By adding a default value to ViewPassword in CipherData de-serialized objects will now default with ViewPassword enabled.

We need to keep the other fallback as well, since otherwise the CipherData will copy the ViewPassword=False from CipherResponse.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/977 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 6/12/2020 **Status:** ✅ Merged **Merged:** 6/12/2020 **Merged by:** [@cscharf](https://github.com/cscharf) **Base:** `master` ← **Head:** `hotfix/hidden-passwords` --- ### 📝 Commits (1) - [`61fffb2`](https://github.com/bitwarden/android/commit/61fffb258177c06e5a7eaa4121aa01efa88cf91a) Resolve all passwords being hidden after upgrade ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Models/Data/CipherData.cs` (+1 -1) </details> ### 📄 Description Resolves #973. When a vault is synced, the content is stored using the `Data` models, since the fallback path relied on `CipherResponse` defaulting the value, this did not happen for content already synced. By adding a default value to `ViewPassword` in `CipherData` de-serialized objects will now default with `ViewPassword` enabled. We need to keep the other fallback as well, since otherwise the `CipherData` will copy the `ViewPassword=False` from `CipherResponse`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2691
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?