github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1925] [MERGED] [PS-676] Accessibility - "Options" expand/collapse control does not announce state #3223

New Issue
Closed
opened 2025-11-26 23:29:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1925
Author: @andrebispo5
Created: 5/25/2022
Status: ✅ Merged
Merged: 5/27/2022
Merged by: @andrebispo5

Base: master ← Head: bug/ps-676-sends-options-voiceover

📝 Commits (3)

  • e33c824 PS-676: Accessibility - "Options" expand/collapse control does not announce state
  • afcef45 Merge branch 'master' into bug/ps-676-sends-options-voiceover
  • 96ed3a0 PS-676 Changed event to command

📊 Changes

5 files changed (+36 additions, -12 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPage.xaml (+10 -6)
📝 src/App/Pages/Send/SendAddEditPage.xaml.cs (+0 -5)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+8 -1)
📝 src/App/Resources/AppResources.Designer.cs (+12 -0)
📝 src/App/Resources/AppResources.resx (+6 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Make options button and chevron button work as a single button. Add accessibility text to describe the state of the layout.

Code changes

  • src/App/Pages/Send/SendAddEditPage.xaml: Moved the click event to the parent StackLayout. Added accessibility text to StackLayout. Removed accessibility on views inside StackLayout.
  • src/App/Pages/Send/SendAddEditPageViewModel.cs: Added property for the accessibility text. Raise prop change on ShowOptions set.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1925 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/25/2022 **Status:** ✅ Merged **Merged:** 5/27/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bug/ps-676-sends-options-voiceover` --- ### 📝 Commits (3) - [`e33c824`](https://github.com/bitwarden/android/commit/e33c824e50deaafaa887eafe25848ed8092c986f) PS-676: Accessibility - "Options" expand/collapse control does not announce state - [`afcef45`](https://github.com/bitwarden/android/commit/afcef45f361aa0e0360df37b98fca78dc855fe03) Merge branch 'master' into bug/ps-676-sends-options-voiceover - [`96ed3a0`](https://github.com/bitwarden/android/commit/96ed3a0f5d3a848312f4422da5e9fd32aa01e0df) PS-676 Changed event to command ### 📊 Changes **5 files changed** (+36 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+10 -6) 📝 `src/App/Pages/Send/SendAddEditPage.xaml.cs` (+0 -5) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+8 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+12 -0) 📝 `src/App/Resources/AppResources.resx` (+6 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Make options button and chevron button work as a single button. Add accessibility text to describe the state of the layout. ## Code changes * **src/App/Pages/Send/SendAddEditPage.xaml**: Moved the click event to the parent `StackLayout`. Added accessibility text to `StackLayout`. Removed accessibility on views inside `StackLayout`. * **src/App/Pages/Send/SendAddEditPageViewModel.cs**: Added property for the accessibility text. Raise prop change on `ShowOptions` set. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3223
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?