github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #946] [MERGED] Singleton LiteDatabase #2677

New Issue
Closed
opened 2025-11-26 23:22:34 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:34 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/946
Author: @kspearrin
Created: 6/2/2020
Status: ✅ Merged
Merged: 6/2/2020
Merged by: @kspearrin

Base: master ← Head: singleton

📝 Commits (2)

  • d1499f1 update litedb. initialize db as a static singleton instance.
  • 39d7c5b dont need to dispose anymore

📊 Changes

2 files changed (+12 additions, -10 deletions)

View changed files

📝 src/Core/Core.csproj (+1 -1)
📝 src/Core/Services/LiteDbStorageService.cs (+11 -9)

📄 Description

Use a static singleton instance of LiteDatabase instead of trying to manually dispose. This should get around the Lite Database file locking issue we have been experiencing and allow us to upgrade to the latest LiteDB version that we need to resolve other bugs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/946 **Author:** [@kspearrin](https://github.com/kspearrin) **Created:** 6/2/2020 **Status:** ✅ Merged **Merged:** 6/2/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `singleton` --- ### 📝 Commits (2) - [`d1499f1`](https://github.com/bitwarden/android/commit/d1499f1d3af7448e719eb06b3faa1f16d0087b23) update litedb. initialize db as a static singleton instance. - [`39d7c5b`](https://github.com/bitwarden/android/commit/39d7c5bb7c53e4f36537d53e3a31984ba2eb582e) dont need to dispose anymore ### 📊 Changes **2 files changed** (+12 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Core.csproj` (+1 -1) 📝 `src/Core/Services/LiteDbStorageService.cs` (+11 -9) </details> ### 📄 Description Use a static singleton instance of LiteDatabase instead of trying to manually dispose. This should get around the Lite Database file locking issue we have been experiencing and allow us to upgrade to the latest LiteDB version that we need to resolve other bugs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:34 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2677
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?