github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2824] [CLOSED] [PM-4327] Adjust LaunchMode of WebAuth & Autofill helper activities #29840

New Issue
Closed
opened 2026-04-18 13:44:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:44:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2824
Author: @mpbw2
Created: 10/13/2023
Status: ❌ Closed

Base: main ← Head: bugfix/helper-activities-launchmode

📝 Commits (10+)

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 src/App/Platforms/Android/AndroidManifest.xml (+1 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Updated the LaunchMode of helper public activities (exported or having intent-filters) to restrict access in older versions of Android

Code changes

  • AutofillExternalSelectionActivity.cs: Add explicit export declaration
  • WebAuthCallbackActivity.cs: Moved declaration to the manifest and changed launch mode to SingleInstance based on Android API level.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2824 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/13/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bugfix/helper-activities-launchmode` --- ### 📝 Commits (10+) - [`afb8c51`](https://github.com/bitwarden/android/commit/afb8c515d6936ae92b03c05388acdefd78fb130a) [PM-3071] Remove share on save toggle on Send view (#2659) - [`7043be6`](https://github.com/bitwarden/android/commit/7043be67dda8fba618db19168c3776a503dfdea7) Update CODEOWNERS (#2701) - [`e274c04`](https://github.com/bitwarden/android/commit/e274c0410749a8c87ec35abce47b9e58bf3ce43c) [PM-3513] Show error SSO policy (#2707) - [`8cae840`](https://github.com/bitwarden/android/commit/8cae840c68082907f9fef7c662450d898edd0f7a) Autosync the updated translations (#2704) - [`249406e`](https://github.com/bitwarden/android/commit/249406e3a8c43624736696dbd4da19987aef9388) [PM-3545] Fix biometric unlock for autofill (#2710) - [`e30f990`](https://github.com/bitwarden/android/commit/e30f9903d13cfa60e6e29433e01d7695cb6897c5) fix for TDE pref naming collision (#2712) - [`9c7ff85`](https://github.com/bitwarden/android/commit/9c7ff853d726a895c61d9af5e462f3b796676a3b) Autosync the updated translations (#2720) - [`819aabb`](https://github.com/bitwarden/android/commit/819aabb33020b9d7039554ebe64b4620ee932cc2) don't clear key needed for bio/auto migration in pin migration (#2721) - [`7ec5c8c`](https://github.com/bitwarden/android/commit/7ec5c8ccfdf2ae97a7b7cc8fd18306578e366627) Bumped version to 2023.8.0 (#2725) - [`47be3d6`](https://github.com/bitwarden/android/commit/47be3d6aef1bf46cc3b3103dbc22b2a133a27a03) Bumped version to 2023.8.1 (#2730) ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/AndroidManifest.xml` (+1 -2) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Updated the LaunchMode of helper public activities (exported or having intent-filters) to restrict access in older versions of Android ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AutofillExternalSelectionActivity.cs:** Add explicit export declaration * **WebAuthCallbackActivity.cs:** Moved declaration to the manifest and changed launch mode to `SingleInstance` based on Android API level. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:44:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29840
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?