github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3232] [CLOSED] [PM-8029] Icon loading fixes and uri parsing improvements #23485

New Issue
Closed
opened 2026-04-16 23:33:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:33:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3232
Author: @1fexd
Created: 5/9/2024
Status: ❌ Closed

Base: main ← Head: uri-parsing

📝 Commits (10+)

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/Core/Core.csproj (+3 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

  • Avoid loading icons when the user has chosen not to display them
  • Remove abitrary TLD restriction for link open / favicon loading check by adding Nager.PublicSuffix
  • Only try to load favicons for valid domains (via publicsuffix)
  • Never attempt to load favicons for .onion / .i2p domains
  • Improve uri parsing util without changing the existing behavior

I've also added some suggestions on what changes to the parsing behavior should be made in my opinion.

Code changes

  • file.ext: Description of what was changed and why

  • src/Core/Core.csproj: Add NuGet package to load publicsuffixlist, add asset

  • src/Core/Pages/Vault/CipherItemViewModel.cs: Don't load favicon if user has disabled favicons

  • src/Core/Utilities/CoreHelpers.cs: Uri parsing improvements with suggested breaking changes

  • src/Core/Utilities/IconImageConverter.cs: Favicon loading fixes and improvements

  • src/Core/Utilities/MauiAssetRuleProvider.cs: Maui asset rule provider

  • src/Core/Utilities/ServiceContainer.cs: Register rule provider

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3232 **Author:** [@1fexd](https://github.com/1fexd) **Created:** 5/9/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `uri-parsing` --- ### 📝 Commits (10+) - [`420dc09`](https://github.com/bitwarden/android/commit/420dc09fd147275b89a67e697c10f1e14b8be056) Update codeowners (#2691) - [`f426c0e`](https://github.com/bitwarden/android/commit/f426c0e37042aeae73fdc8b1c6bb494818b21e01) Create section for crowdin sync (#2692) - [`8474f53`](https://github.com/bitwarden/android/commit/8474f536ffe47491b93898664f48d8c86c3b5f52) Autosync the updated translations (#2677) - [`01ac20e`](https://github.com/bitwarden/android/commit/01ac20e6e40f14890ae5a8cf64eeb32346a462da) Adding missing AutomationIDs on LoginPasswordlessRequestListPage (#2693) - [`6f7100a`](https://github.com/bitwarden/android/commit/6f7100ae4f97904a5b5798e7f41b2aa011fc6ca3) lib updates (#2696) - [`a23454b`](https://github.com/bitwarden/android/commit/a23454bc53c5ed4c5871c34f1e4d542bdde248e0) [PM-3508] Fix Release iPhoneSimulator configuration for iOS / Extensions (#2698) - [`bfcfd36`](https://github.com/bitwarden/android/commit/bfcfd367dd169b8fcf52e9448d569aaaf860d155) Trusted Device Encryption feature (#2656) - [`afb8c51`](https://github.com/bitwarden/android/commit/afb8c515d6936ae92b03c05388acdefd78fb130a) [PM-3071] Remove share on save toggle on Send view (#2659) - [`7043be6`](https://github.com/bitwarden/android/commit/7043be67dda8fba618db19168c3776a503dfdea7) Update CODEOWNERS (#2701) - [`e274c04`](https://github.com/bitwarden/android/commit/e274c0410749a8c87ec35abce47b9e58bf3ce43c) [PM-3513] Show error SSO policy (#2707) ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Core.csproj` (+3 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective * Avoid loading icons when the user has chosen not to display them * Remove abitrary TLD restriction for link open / favicon loading check by adding `Nager.PublicSuffix` * Only try to load favicons for valid domains (via publicsuffix) * Never attempt to load favicons for `.onion` / `.i2p` domains * Improve uri parsing util without changing the existing behavior I've also added some suggestions on what changes to the parsing behavior should be made in my opinion. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why * `src/Core/Core.csproj`: Add NuGet package to load publicsuffixlist, add asset * `src/Core/Pages/Vault/CipherItemViewModel.cs`: Don't load favicon if user has disabled favicons * `src/Core/Utilities/CoreHelpers.cs`: Uri parsing improvements with suggested breaking changes * `src/Core/Utilities/IconImageConverter.cs`: Favicon loading fixes and improvements * `src/Core/Utilities/MauiAssetRuleProvider.cs`: Maui asset rule provider * `src/Core/Utilities/ServiceContainer.cs`: Register rule provider ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:33:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23485
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?