github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #915] [MERGED] Add support for Privacy Browser (Free/Standard). Closes #407 #2656

New Issue
Closed
opened 2025-11-26 23:22:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/915
Author: @contribucious
Created: 5/23/2020
Status: ✅ Merged
Merged: 5/23/2020
Merged by: @kspearrin

Base: master ← Head: privacy-browser-support

📝 Commits (3)

  • ba073b8 Add Privacy Browser (Free/Standard) to SupportedBrowsers dict
  • 3fb6b0e Add Privacy Browser (Free/Standard) to CompatBrowsers
  • 87114d3 Add Privacy Browser (Free/Standard) compatibility-package entries

📊 Changes

3 files changed (+10 additions, -0 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+2 -0)
📝 src/Android/Autofill/AutofillHelpers.cs (+2 -0)
📝 src/Android/Resources/xml/autofillservice.xml (+6 -0)

📄 Description

Privacy_Browser_logo

This:

✔️ The resource-id value (url_edittext) has been checked.

➡️ Only on the Free version though.
↪️ But is more than certainly the same on the Standard version, the latter being mainly a paid ad-free version. See the Privacy Browser Free Advertisements section of their Privacy Policy page.
 

Read more ...

Screenshot (for resource-id value)

Privacy_Browser_Free_resource-id
➡️ com.stoutner.privacybrowser.free:id/ url_edittext

Remark

Note that, on this browser, like many alternative browsers (even from big names like Avast), there is a known problem (which you know well). Namely, if you scroll a long page, the URL bar hides but does not reappear when you click in a password field. This poses a problem for password managers to detect the URL of the web page (for users using the accessibility service). Fortunately, most websites put their login fields at the top of the page, especially on the pages dedicated to logging in. Allowing users not to be confronted with this problem.

Remark (demo)

⏬ To simulate the problem on a website yet correctly coded concerning this, I zoomed the page and scrolled it slightly, to hide the URL bar (screenshot 1). Then clicked in the password field (screenshot 2).

On Google Chrome (handling this correctly) 👍

View me ...

 
Screenshot_1589904732

Screenshot_1589904752

On Mozilla Firefox (handling this correctly) 👍

View me ...

 
Screenshot_1589905587

Screenshot_1589905593

On Privacy Browser (not handling this correctly) :octocat:

View me ...

 
1-Screenshot_1589905800

2-Screenshot_1589905805

Closes #407

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/915 **Author:** [@contribucious](https://github.com/contribucious) **Created:** 5/23/2020 **Status:** ✅ Merged **Merged:** 5/23/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `privacy-browser-support` --- ### 📝 Commits (3) - [`ba073b8`](https://github.com/bitwarden/android/commit/ba073b8b18909298b6ebba7487b59206e873c461) Add Privacy Browser (Free/Standard) to SupportedBrowsers dict - [`3fb6b0e`](https://github.com/bitwarden/android/commit/3fb6b0e6cdbe23fc971d6e7cae5fb887aead596f) Add Privacy Browser (Free/Standard) to CompatBrowsers - [`87114d3`](https://github.com/bitwarden/android/commit/87114d3c0973e965b3dba8d5bd5ccd092e013f96) Add Privacy Browser (Free/Standard) compatibility-package entries ### 📊 Changes **3 files changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+2 -0) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+2 -0) 📝 `src/Android/Resources/xml/autofillservice.xml` (+6 -0) </details> ### 📄 Description ![Privacy_Browser_logo](https://user-images.githubusercontent.com/4764956/82714498-2bf5b200-9c8f-11ea-9061-71ceea87ce71.png) ___ ### This: - adds compatibility for **[Privacy Browser (Free)](https://play.google.com/store/apps/details?id=com.stoutner.privacybrowser.free)** (`com.stoutner.privacybrowser.free`) and - adds compatibility for **[Privacy Browser (Standard)](https://play.google.com/store/apps/details?id=com.stoutner.privacybrowser.standard)** (`com.stoutner.privacybrowser.standard`). &nbsp; :heavy_check_mark: The resource-id value (`url_edittext`) has been checked. :arrow_right: Only on the **Free** version though. :arrow_right_hook: But is more than certainly the same on the **Standard** version, the latter being mainly a paid ad-free version. See the `Privacy Browser Free Advertisements` section of their [Privacy Policy](https://www.stoutner.com/privacy-browser/privacy-policy/) page. &nbsp; <details> <summary>Read more ...</summary> ### Screenshot (for _resource-id_ value) ![Privacy_Browser_Free_resource-id](https://user-images.githubusercontent.com/4764956/82714268-1af87100-9c8e-11ea-8ad0-50e6848f53d3.png) :arrow_right: `com.stoutner.privacybrowser.free:id/` **`url_edittext`** ### Remark Note that, on this browser, like many alternative browsers (even from big names like **Avast**), there is a known problem (which you know well). Namely, if you scroll a long page, the URL bar hides but does not reappear when you click in a password field. This poses a problem for password managers to detect the URL of the web page (for users using the accessibility service). Fortunately, most websites put their login fields at the top of the page, especially on the pages dedicated to logging in. Allowing users not to be confronted with this problem. ### Remark (demo) :arrow_double_down: To simulate the problem on a website yet correctly coded concerning this, I zoomed the page and scrolled it slightly, to hide the URL bar _(screenshot 1)_. Then clicked in the password field _(screenshot 2)_. #### On Google Chrome (handling this correctly) :+1: <details> <summary>View me ...</summary> &nbsp; ![Screenshot_1589904732](https://user-images.githubusercontent.com/4764956/82715145-22217e00-9c92-11ea-9bbe-a635e46caa3f.png) ![Screenshot_1589904752](https://user-images.githubusercontent.com/4764956/82715148-2352ab00-9c92-11ea-9601-4530c5034419.png) </details> #### On Mozilla Firefox (handling this correctly) :+1: <details> <summary>View me ...</summary> &nbsp; ![Screenshot_1589905587](https://user-images.githubusercontent.com/4764956/82716808-ab887e80-9c99-11ea-8468-11f5bd62c405.png) ![Screenshot_1589905593](https://user-images.githubusercontent.com/4764956/82716810-ad524200-9c99-11ea-8da8-179cb97a5992.png) </details> #### On Privacy Browser (not handling this correctly) :octocat: <details> <summary>View me ...</summary> &nbsp; ![1-Screenshot_1589905800](https://user-images.githubusercontent.com/4764956/82715167-3cf3f280-9c92-11ea-97ff-cd5d37918574.png) ![2-Screenshot_1589905805](https://user-images.githubusercontent.com/4764956/82715170-3f564c80-9c92-11ea-9393-847965db6a90.png) </details> </details> ___ Closes #407 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?