* Make arithmetic.ts strict TypeScript compliant
- Add type definitions for ParserState, Operator, OperatorNode, and AstNode
- Add explicit type annotations to all function parameters
- Fix null/undefined handling in parsePrimary function
- Remove type assertion in makeOperatorParser by using explicit Operator type
- Handle null return from currencyToAmount function
- All functions now have proper return type annotations
* Add test for ignoring leftover characters in evalArithmetic function
* docs: add ANZ Plus Bank to community repos
Added ANZ Plus Bank to the Community Repos page.
Link(s): https://github.com/spydisec/PDFtoOFX/
Short summary: Convert ANZ Plus bank statement PDFs to OFX format for seamless import into Actual Budget and other personal finance applications.
Placement: https://actualbudget.org/docs/community-repos/
* Update packages/docs/docs/community-repos.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Fix typo in ANZ Plus bank converter description
* chore: update docs spelling allowlist
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Initial plan
* Add clock-drift error handling to sync flow
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
* Add release notes for PR #6789
* Refactor error handling in sync flow
- Extracted error handling logic into a separate function for better readability and maintainability.
- Updated the receiveMessages and _sendMessages functions to utilize the new errorHandler.
- Removed redundant error handling code from the _sendMessages function.
- Enhanced error handling for SyncError and ClockDriftError to emit specific events.
* Enhance error handling in receiveMessages function
- Added try-catch block to handle Timestamp.ClockDriftError specifically.
- Emitted a sync error event for clock-drift errors to improve synchronization feedback.
- Maintained existing functionality while improving error reporting.
* Update authorship in release notes and refine clock-drift error messaging for clarity
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
* start to a storybook
* release notes
* commit the release notes
* add test:web back
* adding some scripts to the main package for storybook
* styled it up a bit
* remove unneeded icon
* lint
* remove needless comment
* moving clarifying comment
* fast failing
* feedback
* removing unneeded config
* Fix missing bottom navigation bar on mobile reports page
Update route pattern from /reports to /reports/* to match nested routes
* Release notes
* Add release notes for version 6803
* Refactor reports route to include dashboardId parameter
* Initial plan
* Add test case for apostrophe-dot format bug
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
* Fix: Support keyboard apostrophe (U+0027) in arithmetic parser for apostrophe-dot format
The arithmetic parser was only recognizing the typographic apostrophe (U+2019)
that Intl.NumberFormat outputs, but not the regular apostrophe (U+0027) that
users type on their keyboards. This caused amounts like "12'345.67" to be
truncated to "12" when users typed them.
The fix adds U+0027 to the regex character class in arithmetic.ts so both
apostrophe characters are accepted.
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
* Add explicit character code verification to apostrophe-dot test
Use escape sequences (\u0027 and \u2019) to ensure the test explicitly
uses the correct apostrophe characters, and add assertions to verify
the character codes are as expected.
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
* Fix lint
* Add comprehensive tests for apostrophe-dot format in arithmetic.test.ts
Added three new test cases to verify both apostrophe types work correctly:
1. Tests keyboard apostrophe (U+0027) with explicit character code verification
2. Tests typographic apostrophe (U+2019) with explicit character code verification
3. Tests arithmetic operations with both apostrophe types
This addresses the feedback to add tests for the new logic in arithmetic.ts.
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
* [autofix.ci] apply automated fixes
* Add release notes for PR #6795
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update BudgetAnalysisGraph.tsx
Use reportsGray for Balance.
* Fix Budget Analysis Graph balance color variable
Use reportsGray instead of numberNeutral for balance points and line.
* Fix schedule transaction amount color on mobile
Change schedule amount color from pageText to pageTextSubdued to match the label color, consistent with desktop version.
Fixes#6781
* Enhance Budget Analysis report UI and functionality
- Improve chart colors to align with Cash Flow report style
- Streamline report view by removing legend items
- Introduce a quick select option for 1 month in the header
- Implement dynamic interval switching based on date range
This update aims to provide a more cohesive and user-friendly experience in the Budget Analysis report.
* Update snapshot images for account page tests and fix color styling in transaction and schedule list items
- Updated snapshot images for account page tests to reflect recent UI changes.
- Adjusted color styling for transaction amounts to ensure consistency with the overall theme.
- Changed schedule amount color back to match the primary text color for better visibility.
* Add Budget Analysis report with full implementation
Co-authored-by: tabedzki <35670232+tabedzki@users.noreply.github.com>
* Add preset time ranges, intervals, bar chart, hide balance, and display controls
Co-authored-by: tabedzki <35670232+tabedzki@users.noreply.github.com>
* Fix duplicate function declaration syntax error in budget-analysis-spreadsheet.ts
Co-authored-by: tabedzki <35670232+tabedzki@users.noreply.github.com>
* Fix floating point precision error in daily/weekly intervals and replace interval button with dropdown
Co-authored-by: tabedzki <35670232+tabedzki@users.noreply.github.com>
* Make card always display monthly data and match report's chart type
Co-authored-by: tabedzki <35670232+tabedzki@users.noreply.github.com>
* fix: adjust widget placement and presentation
* fix: adjusted the dot presentation
* feat: added svg for line chart/barchart
* fix: added one month to the report
* added the upcoming release notes
* amended the upcoming release notes
* fix: removed unused variables
* formatted using prettier --write
* [autofix.ci] apply automated fixes
* feat: added new feature to the Reports Page in the test budget
* fix: amended the reports.test.ts file to expect Budget Analysis
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6137
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6137
* revert: removed the inclusion of the Budget Analysis tool from the test file
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6137
* fix: changed the display to always be monthly since budgets are monthly; removed the 1month view
* [autofix.ci] apply automated fixes
* [autofix.ci] apply automated fixes (attempt 2/3)
* fix: removed comment
* feat: added experimental feature flag for Budget Analysis tool
* feat: Switched option to use SVG Icons instead of words to shorten horizontal layout
* Removed interval possibilities and removed unnecessary compact variable as indicated by CodeRabbit
* Update packages/desktop-client/src/components/reports/reports/BudgetAnalysisCard.tsx
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Added basic documentation for Budget Analysis Report
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6137
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6137
* fix: added budget-analysis doc to sidebar
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6137
* feat(reports): improve Budget Analysis report UI and behavior
- Update chart colors to match Cash Flow report style
(Budgeted: blue, Balance: pageTextLight)
- Remove legend items from report view for cleaner UI
- Add 1 month quick select option to header
- Pass isConcise prop to BudgetAnalysisGraph for proper date formatting
- Add dynamic daily/monthly interval switching based on date range
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6137
* feat(reports): refactor BudgetAnalysisGraph and improve isConcise calculation according to Rabbit AI
* feat(reports): add translation support for Budget Analysis graph labels
* feat(reports): centralize translation for Budget Analysis graph labels
* feat: use the budget values directly from the budget spreadsheet/server
* feat: enhance budget analysis with overspending adjustments and detailed reporting
* style: format code for better readability in BudgetAnalysis and budget-analysis-spreadsheet components
* refactor: remove unused variables
* docs: added in the image to the docs
* fix: reimplement support for conditionsOp
* [autofix.ci] apply automated fixes
* style: simplify budget analysis labels for clarity
* fix: add the on copy function
* feat: tooltip improvements
* feat: enhance budget analysis to track overspending adjustments across months
* fix: removed the absolute value for spent
* feat: update the charts to look closer to the CashFlow report
* fix: correct financial formatting for totalSpent in BudgetAnalysis
* feat: add filterExclude prop to Header and BudgetAnalysis for improved filtering options
* feat: implement privacy mode for Y-axis values in BudgetAnalysisGraph
* feat: change default graph type to Bar in BudgetAnalysis
* feat: remove commented-out filter button code in Header component
* feat: remove commented-out code for filter exclusion in Header component
* fix: update the feedback link to the dedicated issue
* refactor: financial display components to use FinancialText for consistency in Budget Analysis reports
* fix: update the card to also start as bar graph
* docs: update Budget Analysis report to include category filtering information
* style: refactor imports and whitespace
* refactor: simplify inline content structure in BudgetAnalysis component
* [autofix.ci] apply automated fixes
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6137
* fix: removed color descriptors from the chart
* fix: update color themes for Budget Analysis to use custom theme definitions
* [autofix.ci] apply automated fixes
* feat: update Budget Analysis merge md file
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6137
* fix: update budget analysis report image
* fix: white space adjustment in descriptor
* [autofix.ci] apply automated fixes
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
* use old budget page colours
* running balance
* schedule indicator
* mobile to budget
* note
* template indicator due should match underfunded
* coderabbit
* mobile to budget neutral zero
* matiss feedback
* mobile account balance
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6764
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add budget color variables to theme
* Add isPositive check for budget amount styling
* Add budget number constants for positive, zero, and negative
* Add budget status constants for positive, zero, and negative
* Add budget number constants for positive, zero, and negative
* Update midnight.ts
* Create 6754.md
Add the ability to specify expected monthly contributions to the
crossover report. This will allow users to estimate the growth of their
investments more accurately instead of treating all account growth as
exponential investment returns. When the checkbox is unclicked, the
automatically calculated historical return value will be used. When the
checkbox is clicked, it will display two input fields. One for expected
investment growth, and one for expected monthly contributions to your
retirement accounts.
Signed-off-by: Jonathon Jongsma <jonathon@quotidian.org>
* Add 'Shades of Gray (light)' theme to catalog
* Update color format in customThemeCatalog.json
* [autofix.ci] apply automated fixes
* Add release notes for light custom theme enhancement
🎨 Light custom theme featuring shades of gray and a few colors.
* Reorder color values in customThemeCatalog.json
* Change color value
Updated a color value in the custom theme catalog.
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* Fix reports to correctly render categories with identical names
Use category id instead of name as the data key for chart lookups to prevent
collisions when multiple categories share the same display name.
* Enhance CustomTooltip in LineGraph and StackedBarGraph to utilize legend data for improved display names. This change introduces a new LegendEntity type and updates the tooltip rendering logic to map data keys to their corresponding names, ensuring clarity when displaying chart data.
* Enhance Average Goal Template to allow adjusting the budgetted amount from the average by a percent or fixed amount
* fix typos
* ensure check is for undefined, so zero doesn't cause edge cases
* typo in enhancement message
* scale by cents for fixed amount, fixup tests for this as well
* Add support for fixed values in Schedule template
* [autofix.ci] apply automated fixes
* Changed to 'fixed' from 'amount'. Added unparse logic for Average, also fixed Schedule unparse
* move to generic for syntax from specific number
* consider currency preferences when calculating fixed modifications
* lint
* [autofix.ci] apply automated fixes
* timeframe -> period
* percentage -> value
* pass currency for calculation
* lint
* import from proper local dir
* [autofix.ci] apply automated fixes
* script block around {number} to prevent mdx conflict
* match order of ops between schedule and average for percent adjustment
* diversify example
* Link to schedule>adjustments from average
* Removed example column in favor of extra context
Slight rewording to avoid 'average' overload
* rabbit nitpicks
* number
* period
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
Change the "Switch budget file" menu option on mobile to navigate back
to the config/budget selection page instead of opening a modal. This
makes the behavior consistent with the "Switch file" button in settings.
Remove the now-unused BudgetFileSelectionModal component.
* Add new theme 'Theme from 1970' to customThemeCatalog
* Add release notes for 1970-inspired light theme
Added release notes for a new custom light theme inspired by 1970 colors.
* Replace theme screenshots with color palette preview
- Replace screenshot images in theme installer with 3x2 color palette grid
- Add colors array to catalog themes in customThemeCatalog.json
- Update CatalogTheme type to include optional colors property
- Remove getThemeScreenshotUrl function
- Extract ColorPalette component to separate file
- Update documentation to reflect color palette instead of screenshots
- Update tests to verify color palettes instead of images
- Extract actual theme colors from GitHub repositories
* Update ColorPalette component to use data-swatch attribute for color swatches in ThemeInstaller tests
* Update packages/desktop-client/src/data/customThemeCatalog.json
Co-authored-by: Michael Clark <5285928+MikesGlitch@users.noreply.github.com>
* Update color palettes for Simple Dark and Okabe Ito themes
Co-authored-by: matiss <matiss@mja.lv>
---------
Co-authored-by: Michael Clark <5285928+MikesGlitch@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
* Fix AuthSettings - hide if no server configured and show warning if offline
* Add release notes for auth settings fix
* Refactor AuthSettings component to always display OpenID label hint and remove offline condition check in tests
* Upgrade oxfmt/oxlint and migrate import sorting to oxfmt
Upgrade oxfmt from 0.22.0 to 0.26.0 and oxlint from 1.38.0 to 1.41.0.
Move import sorting configuration from oxlint (perfectionist/sort-imports)
to oxfmt's new experimentalSortImports feature, which provides native
import sorting support in the formatter.
* Add release notes for maintenance updates including oxlint and oxfmt upgrades
* Fix accessibility issues: use semantic HTML and correct tab indices
- Replace View with semantic h1 in ModalHeader
- Fix tabIndex from 1 to 0 in Menu component
- Remove disabled oxlint accessibility rules
- Update components to use proper semantic HTML elements
* Refactor button elements to semantic HTML in Autocomplete and CategoryAutocomplete components
- Replace button elements with div/View while maintaining role="button" for accessibility.
- Update styles and props accordingly to ensure consistent behavior.
- Adjust onClick types in Item and SecondaryItem components for better type safety.
* Add release notes for upcoming maintenance updates addressing various accessibility issues
* Refactor autocomplete components to improve text alignment and button semantics
- Added textAlign: 'left' style to AccountItem and PayeeItem for consistent text alignment.
- Removed type="button" from CategoryItem to streamline button semantics.
- Updated ItemContent to use the Button component instead of a button element, enhancing accessibility and consistency.
* Refactor budget and report components to improve text alignment
- Removed font: 'inherit' style from EnvelopeBudgetComponents and TrackingBudgetComponents for cleaner styling.
- Updated ActionableGridListItem and ReportCard components to replace font: 'inherit' with textAlign: 'left' for consistent text alignment.
* Update ActionableGridListItem to include font inheritance for improved styling consistency
* Refactor button elements to use the Button component for consistency and improved semantics
- Updated various components (EnvelopeBudgetComponents, IncomeCategoryMonth, CategoryMonth, ActionableGridListItem, ReportCard, DesktopLinkedNotes) to replace native button elements with the custom Button component.
- Adjusted styles and event handlers to align with the new Button implementation, ensuring consistent behavior and accessibility across the application.
* Update Button and ActionableGridListItem styles for consistency
- Set a fixed borderRadius of 4 for the Button component, ensuring uniformity across variants.
- Adjusted ActionableGridListItem to have a borderRadius of 0 for a cleaner design.
* Update CategoryAutocomplete to include button type attribute for improved semantics
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6679
* Update VRT screenshot for Payees search functionality
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Initial plan
* Fix mobile Calendar fatal error by correcting height constraint
The Virtualizer component in TransactionList requires its parent to have a defined height. Changed the View wrapper from height: '100%' to flex: 1 to properly distribute space within the flex container, accounting for the chevron button.
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
* Add DisplayPayeeProvider to fix mobile Calendar error
The TransactionListItem component uses useDisplayPayee hook which requires DisplayPayeeProvider context. Wrapped TransactionListMobile with DisplayPayeeProvider to fix "useDisplayPayee must be used within a DisplayPayeeContextProvider" error on mobile.
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
* Change flex to height for View component
* Add release notes for PR #6698
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
