github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #6911] Fix Ctrl+Enter losing amount value when adding transaction #6810

New Issue
Closed
opened 2026-02-28 21:33:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:33:00 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6911

State: closed
Merged: Yes

Fixes #6901

Summary

When using Ctrl+Enter to add a transaction immediately after typing in the amount field, the value wasn't being committed before the transaction was saved, resulting in a zero amount.

Changes

  • Wrapped the add-and-close logic in an afterSave() callback to ensure field values are committed before adding the transaction
  • Added regression tests for both debit and credit fields to verify the fix works correctly

Test Plan

  • yarn typecheck passes
  • yarn lint:fix passes
  • Added unit tests that verify the bug is fixed
  • All existing tests pass

Testing Instructions

  1. Open any account
  2. Click "Add New" to create a transaction
  3. Fill in the notes field
  4. Tab to the amount field and type a value (e.g., 150.75)
  5. Immediately press Ctrl+Enter (or Cmd+Enter on Mac) without tabbing away
  6. Verify the transaction is added with the correct amount (not zero)

🤖 Generated with Claude Code

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.47 MB → 14.47 MB (+83 B) +0.00%
loot-core 1 5.86 MB 0%
api 1 4.39 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.47 MB → 14.47 MB (+83 B) +0.00%
Changeset
File Δ Size
src/components/transactions/TransactionsTable.tsx 📈 +76 B (+0.09%) 86.09 kB → 86.17 kB
locale/es.json 📈 +7 B (+0.00%) 173.83 kB → 173.83 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 9.32 MB → 9.33 MB (+76 B) +0.00%
static/js/es.js 173.83 kB → 173.83 kB (+7 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 106.62 kB 0%
static/js/de.js 178.39 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 164.55 kB 0%
static/js/fr.js 179.62 kB 0%
static/js/it.js 171.44 kB 0%
static/js/nb-NO.js 157.23 kB 0%
static/js/nl.js 106.65 kB 0%
static/js/pl.js 88.64 kB 0%
static/js/pt-BR.js 154.57 kB 0%
static/js/sv.js 78.2 kB 0%
static/js/th.js 182.35 kB 0%
static/js/uk.js 215.11 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.11 MB 0%
static/js/narrow.js 640.46 kB 0%
static/js/TransactionList.js 105.97 kB 0%
static/js/wide.js 160.07 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.79 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.86 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.G2jIa5TY.js 5.86 MB 0%

api

Total

Files count Total bundle size % Changed
1 4.39 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
bundle.api.js 4.39 MB 0%
**Original Pull Request:** https://github.com/actualbudget/actual/pull/6911 **State:** closed **Merged:** Yes --- Fixes #6901 ## Summary When using Ctrl+Enter to add a transaction immediately after typing in the amount field, the value wasn't being committed before the transaction was saved, resulting in a zero amount. ## Changes - Wrapped the add-and-close logic in an `afterSave()` callback to ensure field values are committed before adding the transaction - Added regression tests for both debit and credit fields to verify the fix works correctly ## Test Plan - [x] `yarn typecheck` passes - [x] `yarn lint:fix` passes - [x] Added unit tests that verify the bug is fixed - [x] All existing tests pass ## Testing Instructions 1. Open any account 2. Click "Add New" to create a transaction 3. Fill in the notes field 4. Tab to the amount field and type a value (e.g., 150.75) 5. Immediately press Ctrl+Enter (or Cmd+Enter on Mac) without tabbing away 6. Verify the transaction is added with the correct amount (not zero) --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.47 MB → 14.47 MB (+83 B) | +0.00% loot-core | 1 | 5.86 MB | 0% api | 1 | 4.39 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.47 MB → 14.47 MB (+83 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/transactions/TransactionsTable.tsx` | 📈 +76 B (+0.09%) | 86.09 kB → 86.17 kB `locale/es.json` | 📈 +7 B (+0.00%) | 173.83 kB → 173.83 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.32 MB → 9.33 MB (+76 B) | +0.00% static/js/es.js | 173.83 kB → 173.83 kB (+7 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 106.62 kB | 0% static/js/de.js | 178.39 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 164.55 kB | 0% static/js/fr.js | 179.62 kB | 0% static/js/it.js | 171.44 kB | 0% static/js/nb-NO.js | 157.23 kB | 0% static/js/nl.js | 106.65 kB | 0% static/js/pl.js | 88.64 kB | 0% static/js/pt-BR.js | 154.57 kB | 0% static/js/sv.js | 78.2 kB | 0% static/js/th.js | 182.35 kB | 0% static/js/uk.js | 215.11 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.11 MB | 0% static/js/narrow.js | 640.46 kB | 0% static/js/TransactionList.js | 105.97 kB | 0% static/js/wide.js | 160.07 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.79 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.86 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.G2jIa5TY.js | 5.86 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.39 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.39 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end --->
GiteaMirror added the pull-request label 2026-02-28 21:33:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6810
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?