github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #6716] fix "show completed schedules" toggle being persisted #6689

New Issue
Closed
opened 2026-02-28 21:31:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:31:30 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6716

State: closed
Merged: Yes

Fix https://github.com/actualbudget/actual/issues/6606

I tried to match the logic to the way the desktop view does it to make it easier to read across from one to the other. I also got rid of the modal as it would have been empty, but we can always add it back later for things like "discover existing schedules" like we have on desktop.

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 14.5 MB → 14.49 MB (-3.05 kB) -0.02%
loot-core 1 5.83 MB → 5.83 MB (-998 B) -0.02%
api 1 4.37 MB → 4.37 MB (-842 B) -0.02%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 14.5 MB → 14.49 MB (-3.05 kB) -0.02%
Changeset
File Δ Size
src/components/mobile/schedules/SchedulesList.tsx 📈 +1.39 kB (+32.94%) 4.23 kB → 5.62 kB
src/hooks/useFormulaExecution.ts 📈 +226 B (+2.75%) 8.01 kB → 8.23 kB
node_modules/hyperformula/es/i18n/languages/enGB.mjs 📉 -2 B (-0.02%) 9.4 kB → 9.4 kB
src/components/formula/codeMirror-excelLanguage.tsx 📉 -9 B (-0.04%) 21.06 kB → 21.05 kB
node_modules/hyperformula/es/index.mjs 📉 -6 B (-0.19%) 3.11 kB → 3.1 kB
src/components/schedules/SchedulesTable.tsx 📉 -117 B (-0.58%) 19.8 kB → 19.69 kB
src/components/Modals.tsx 📉 -143 B (-0.99%) 14.08 kB → 13.95 kB
src/components/formula/queryModeFunctions.ts 📉 -253 B (-1.05%) 23.57 kB → 23.32 kB
src/components/formula/transactionModeFunctions.ts 📉 -253 B (-1.64%) 15.03 kB → 14.79 kB
src/components/mobile/schedules/MobileSchedulesPage.tsx 📉 -523 B (-6.99%) 7.3 kB → 6.79 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/customFunctions.ts 📉 -512 B (-47.50%) 1.05 kB → 566 B
src/components/modals/SchedulesPageMenuModal.tsx 🔥 -2.59 kB (-100%) 2.59 kB → 0 B
node_modules/hyperformula/es/i18n/languages/enUS.mjs 🔥 -166 B (-100%) 166 B → 0 B
home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts 🔥 -139 B (-100%) 139 B → 0 B
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/narrow.js 640.05 kB → 640.93 kB (+904 B) +0.14%
static/js/ReportRouter.js 1.13 MB → 1.13 MB (+226 B) +0.02%

Smaller

Asset File Size % Changed
static/js/index.js 9.24 MB → 9.24 MB (-3.65 kB) -0.04%
static/js/FormulaEditor.js 1.04 MB → 1.04 MB (-515 B) -0.05%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 107.03 kB 0%
static/js/de.js 172.31 kB 0%
static/js/en-GB.js 7.24 kB 0%
static/js/en.js 159.21 kB 0%
static/js/es.js 173.04 kB 0%
static/js/fr.js 178.56 kB 0%
static/js/it.js 173.46 kB 0%
static/js/nb-NO.js 158.85 kB 0%
static/js/nl.js 103.57 kB 0%
static/js/pl.js 88.78 kB 0%
static/js/pt-BR.js 147.31 kB 0%
static/js/ru.js 108.05 kB 0%
static/js/sv.js 78.42 kB 0%
static/js/th.js 182.7 kB 0%
static/js/uk.js 217.6 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/TransactionList.js 101.58 kB 0%
static/js/wide.js 159.96 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.79 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.83 MB → 5.83 MB (-998 B) -0.02%
Changeset
File Δ Size
node_modules/hyperformula/es/i18n/languages/enGB.mjs 📉 -2 B (-0.02%) 11.03 kB → 11.03 kB
node_modules/hyperformula/es/index.mjs 📉 -6 B (-0.18%) 3.33 kB → 3.33 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts 📉 -126 B (-1.39%) 8.83 kB → 8.71 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/customFunctions.ts 📉 -670 B (-48.34%) 1.35 kB → 716 B
node_modules/hyperformula/es/i18n/languages/enUS.mjs 🔥 -194 B (-100%) 194 B → 0 B
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.BrDUZwR6.js 0 B → 5.83 MB (+5.83 MB) -

Removed

Asset File Size % Changed
kcab.worker.B3_-Z7dv.js 5.83 MB → 0 B (-5.83 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
1 4.37 MB → 4.37 MB (-842 B) -0.02%
Changeset
File Δ Size
node_modules/hyperformula/es/i18n/languages/enGB.mjs 📉 -2 B (-0.02%) 9.4 kB → 9.4 kB
node_modules/hyperformula/es/index.mjs 📉 -6 B (-0.19%) 3.1 kB → 3.1 kB
src/server/rules/action.ts 📉 -106 B (-1.32%) 7.83 kB → 7.73 kB
src/server/rules/customFunctions.ts 📉 -562 B (-47.71%) 1.15 kB → 616 B
node_modules/hyperformula/es/i18n/languages/enUS.mjs 🔥 -166 B (-100%) 166 B → 0 B
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
bundle.api.js 4.37 MB → 4.37 MB (-842 B) -0.02%

Unchanged
No assets were unchanged

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6716 **State:** closed **Merged:** Yes --- Fix https://github.com/actualbudget/actual/issues/6606 I tried to match the logic to the way the desktop view does it to make it easier to read across from one to the other. I also got rid of the modal as it would have been empty, but we can always add it back later for things like "discover existing schedules" like we have on desktop. <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 14.5 MB → 14.49 MB (-3.05 kB) | -0.02% loot-core | 1 | 5.83 MB → 5.83 MB (-998 B) | -0.02% api | 1 | 4.37 MB → 4.37 MB (-842 B) | -0.02% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 14.5 MB → 14.49 MB (-3.05 kB) | -0.02% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/mobile/schedules/SchedulesList.tsx` | 📈 +1.39 kB (+32.94%) | 4.23 kB → 5.62 kB `src/hooks/useFormulaExecution.ts` | 📈 +226 B (+2.75%) | 8.01 kB → 8.23 kB `node_modules/hyperformula/es/i18n/languages/enGB.mjs` | 📉 -2 B (-0.02%) | 9.4 kB → 9.4 kB `src/components/formula/codeMirror-excelLanguage.tsx` | 📉 -9 B (-0.04%) | 21.06 kB → 21.05 kB `node_modules/hyperformula/es/index.mjs` | 📉 -6 B (-0.19%) | 3.11 kB → 3.1 kB `src/components/schedules/SchedulesTable.tsx` | 📉 -117 B (-0.58%) | 19.8 kB → 19.69 kB `src/components/Modals.tsx` | 📉 -143 B (-0.99%) | 14.08 kB → 13.95 kB `src/components/formula/queryModeFunctions.ts` | 📉 -253 B (-1.05%) | 23.57 kB → 23.32 kB `src/components/formula/transactionModeFunctions.ts` | 📉 -253 B (-1.64%) | 15.03 kB → 14.79 kB `src/components/mobile/schedules/MobileSchedulesPage.tsx` | 📉 -523 B (-6.99%) | 7.3 kB → 6.79 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/customFunctions.ts` | 📉 -512 B (-47.50%) | 1.05 kB → 566 B `src/components/modals/SchedulesPageMenuModal.tsx` | 🔥 -2.59 kB (-100%) | 2.59 kB → 0 B `node_modules/hyperformula/es/i18n/languages/enUS.mjs` | 🔥 -166 B (-100%) | 166 B → 0 B `home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts` | 🔥 -139 B (-100%) | 139 B → 0 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/narrow.js | 640.05 kB → 640.93 kB (+904 B) | +0.14% static/js/ReportRouter.js | 1.13 MB → 1.13 MB (+226 B) | +0.02% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.24 MB → 9.24 MB (-3.65 kB) | -0.04% static/js/FormulaEditor.js | 1.04 MB → 1.04 MB (-515 B) | -0.05% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 107.03 kB | 0% static/js/de.js | 172.31 kB | 0% static/js/en-GB.js | 7.24 kB | 0% static/js/en.js | 159.21 kB | 0% static/js/es.js | 173.04 kB | 0% static/js/fr.js | 178.56 kB | 0% static/js/it.js | 173.46 kB | 0% static/js/nb-NO.js | 158.85 kB | 0% static/js/nl.js | 103.57 kB | 0% static/js/pl.js | 88.78 kB | 0% static/js/pt-BR.js | 147.31 kB | 0% static/js/ru.js | 108.05 kB | 0% static/js/sv.js | 78.42 kB | 0% static/js/th.js | 182.7 kB | 0% static/js/uk.js | 217.6 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/TransactionList.js | 101.58 kB | 0% static/js/wide.js | 159.96 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.79 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.83 MB → 5.83 MB (-998 B) | -0.02% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `node_modules/hyperformula/es/i18n/languages/enGB.mjs` | 📉 -2 B (-0.02%) | 11.03 kB → 11.03 kB `node_modules/hyperformula/es/index.mjs` | 📉 -6 B (-0.18%) | 3.33 kB → 3.33 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts` | 📉 -126 B (-1.39%) | 8.83 kB → 8.71 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/customFunctions.ts` | 📉 -670 B (-48.34%) | 1.35 kB → 716 B `node_modules/hyperformula/es/i18n/languages/enUS.mjs` | 🔥 -194 B (-100%) | 194 B → 0 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BrDUZwR6.js | 0 B → 5.83 MB (+5.83 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.B3_-Z7dv.js | 5.83 MB → 0 B (-5.83 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.37 MB → 4.37 MB (-842 B) | -0.02% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `node_modules/hyperformula/es/i18n/languages/enGB.mjs` | 📉 -2 B (-0.02%) | 9.4 kB → 9.4 kB `node_modules/hyperformula/es/index.mjs` | 📉 -6 B (-0.19%) | 3.1 kB → 3.1 kB `src/server/rules/action.ts` | 📉 -106 B (-1.32%) | 7.83 kB → 7.73 kB `src/server/rules/customFunctions.ts` | 📉 -562 B (-47.71%) | 1.15 kB → 616 B `node_modules/hyperformula/es/i18n/languages/enUS.mjs` | 🔥 -166 B (-100%) | 166 B → 0 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.37 MB → 4.37 MB (-842 B) | -0.02% **Unchanged** No assets were unchanged </div> </details> </details> <!--- bundlestats-action-comment key:combined end --->
GiteaMirror added the pull-request label 2026-02-28 21:31:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?