mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-09 03:32:54 -05:00
[PR #6471] [WIP] Add a category group filter to the transactions pages #6551
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#6551
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/actualbudget/actual/pull/6471
State: closed
Merged: No
resolves #3791 and resolves #4031 (they're duplicate issues from what I can tell).
I had to fix what I believe to be a subtle bug in the AQL compiler in order to get this to work.
In most cases, the JOIN clauses in SELECT queries were being generated using table names instead of the corresponding view names, which was a problem here because the name of the category group column in category table does not match the AQL schema, but the name of the category group column in the category view does match the AQL schema.
Refactoring the AQL compiler to always use views instead of tables (if a view exists) when generating JOIN clauses allows the necessary queries to be generated correctly and appears to be the desired behavior based on documentation on the Actual website and in the code itself.