github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #6815] Skip release notes generation for docs-only PRs #6755

New Issue
Open
opened 2026-02-28 21:32:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:32:16 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6815

State: open
Merged: No

Summary

This PR prevents the automatic generation of release notes for documentation-only pull requests.

Fixes #6586

What

  • Extended pr-details.js to detect docs-only PRs by checking if all changed files are in packages/docs/
  • Added pagination support to handle PRs with more than 100 changed files
  • Added a consolidated eligibility check in the workflow that combines base branch and docs-only validation
  • Simplified step conditions to reduce redundancy by having each step only check its immediate dependency

Why

Documentation-only PRs don't need release notes since they don't affect the application functionality. Generating release notes for these PRs creates unnecessary noise in the changelog and extra work for maintainers to review/remove them.

How

  1. The pr-details.js script fetches all changed files (with pagination via octokit.paginate) and sets isDocsOnly: true if all files are under packages/docs/
  2. A new "Check if PR qualifies for release notes" step evaluates both the target branch (must be master) and the docs-only flag
  3. If eligible=false, all subsequent release notes generation steps are naturally skipped due to cascading conditions

AI Generated

Yes, this PR was created with AI prompts.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6815 **State:** open **Merged:** No --- ## Summary This PR prevents the automatic generation of release notes for documentation-only pull requests. Fixes #6586 ## What - Extended `pr-details.js` to detect docs-only PRs by checking if all changed files are in `packages/docs/` - Added pagination support to handle PRs with more than 100 changed files - Added a consolidated eligibility check in the workflow that combines base branch and docs-only validation - Simplified step conditions to reduce redundancy by having each step only check its immediate dependency ## Why Documentation-only PRs don't need release notes since they don't affect the application functionality. Generating release notes for these PRs creates unnecessary noise in the changelog and extra work for maintainers to review/remove them. ## How 1. The `pr-details.js` script fetches all changed files (with pagination via `octokit.paginate`) and sets `isDocsOnly: true` if all files are under `packages/docs/` 2. A new "Check if PR qualifies for release notes" step evaluates both the target branch (must be master) and the docs-only flag 3. If `eligible=false`, all subsequent release notes generation steps are naturally skipped due to cascading conditions ### AI Generated Yes, this PR was created with AI prompts.
GiteaMirror added the pull-request label 2026-02-28 21:32:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6755
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?