github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3212] [CLOSED] [PM-7886] Show either card number or security code and not both #45696

New Issue
Closed
opened 2026-04-26 12:58:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:58:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3212
Author: @GobinathAL
Created: 5/2/2024
Status: ❌ Closed

Base: main ← Head: togglecarddetails

📝 Commits (10+)

  • dd52ff0 [PM-2320] Improve Android block Auto-fill URIs (#2616)
  • ae9ba81 Autosync the updated translations (#2634)
  • 87b1d18 PM-2320 fix duplicated resource (#2638)
  • 174549e fix image alt text error (#2641)
  • ea81acb [PM-1575] Display Passkeys (#2523)
  • 9eda015 PM-3165 Finish task completion source when cancelling the dialog tapping on the background. (#2647)
  • 375718f PM-3227 Avoid clone on discoverable passkeys. (#2648)
  • 0271a4d Autosync the updated translations (#2650)
  • 5aaff1e PM-3249 Removed back button from block autofill uris to be aligned to other views (#2654)
  • c4e64e0 Autosync the updated translations (#2660)

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/Core/Pages/Vault/CipherDetailsPageViewModel.cs (+2 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Enhancing security by implementing a feature to hide the CVV (Card Verification Value) when displaying the card number and vice versa. This enhancement aims to mitigate the risk of unauthorized access to sensitive financial information and aligns with industry best practices for safeguarding user data.

Code changes

src/Core/Pages/Vault/CipherDetailsPageViewModel.cs

Modified ToggleCardNumber and ToggleCardCode methods

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3212 **Author:** [@GobinathAL](https://github.com/GobinathAL) **Created:** 5/2/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `togglecarddetails` --- ### 📝 Commits (10+) - [`dd52ff0`](https://github.com/bitwarden/android/commit/dd52ff0dccb45c067f0a36877e741c14c089a19c) [PM-2320] Improve Android block Auto-fill URIs (#2616) - [`ae9ba81`](https://github.com/bitwarden/android/commit/ae9ba810ffef5fc6ea6c694d8381c852759ad556) Autosync the updated translations (#2634) - [`87b1d18`](https://github.com/bitwarden/android/commit/87b1d18872b3db908fc903e54e4c8fc5fd18125f) PM-2320 fix duplicated resource (#2638) - [`174549e`](https://github.com/bitwarden/android/commit/174549e5bcfb57764185d19d29b8aee45d6aa720) fix image alt text error (#2641) - [`ea81acb`](https://github.com/bitwarden/android/commit/ea81acb3bfaeb9fa416f2831b6ebd2bf4ae0baa4) [PM-1575] Display Passkeys (#2523) - [`9eda015`](https://github.com/bitwarden/android/commit/9eda01537168ba8a3a09a56995e2a9025c058208) PM-3165 Finish task completion source when cancelling the dialog tapping on the background. (#2647) - [`375718f`](https://github.com/bitwarden/android/commit/375718f94521dceebc39a71202919213f814f206) PM-3227 Avoid clone on discoverable passkeys. (#2648) - [`0271a4d`](https://github.com/bitwarden/android/commit/0271a4db4ce6f18fda928c6328d64fb56ca32835) Autosync the updated translations (#2650) - [`5aaff1e`](https://github.com/bitwarden/android/commit/5aaff1ea2014909d870857042f67245f312ca4b4) PM-3249 Removed back button from block autofill uris to be aligned to other views (#2654) - [`c4e64e0`](https://github.com/bitwarden/android/commit/c4e64e082b8b9fd84f32d5fb4238c292aba9c2ab) Autosync the updated translations (#2660) ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Vault/CipherDetailsPageViewModel.cs` (+2 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Enhancing security by implementing a feature to hide the CVV (Card Verification Value) when displaying the card number and vice versa. This enhancement aims to mitigate the risk of unauthorized access to sensitive financial information and aligns with industry best practices for safeguarding user data. ## Code changes [src/Core/Pages/Vault/CipherDetailsPageViewModel.cs](https://github.com/GobinathAL/bitwarden-mobile/blob/e81e411abcc3a53e729a9be0912fb0d5593c0f44/src/Core/Pages/Vault/CipherDetailsPageViewModel.cs) Modified ToggleCardNumber and ToggleCardCode methods ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:58:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45696
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?