github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1906] [MERGED] PS-591 Fix avoid ambiguous characters #1664 #3212

New Issue
Closed
opened 2025-11-26 23:29:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1906
Author: @andrebispo5
Created: 5/12/2022
Status: ✅ Merged
Merged: 5/18/2022
Merged by: @andrebispo5

Base: master ← Head: bug/fix-avoid-ambiguous-chars

📝 Commits (2)

  • f107076 PS-591 - iOS - Avoid ambiguous characters is activated inside the main client, but is deactivated when creating a vault item from the autofill prompt. #1664
  • fb11d13 PS-591 - iOS - Avoid ambiguous characters is activated inside the main client, but is deactivated when creating a vault item from the autofill prompt. #1664

📊 Changes

5 files changed (+26 additions, -16 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorPage.xaml (+1 -1)
📝 src/App/Pages/Generator/GeneratorPageViewModel.cs (+17 -7)
📝 src/Core/Models/Domain/PasswordGenerationOptions.cs (+3 -3)
📝 src/Core/Services/PasswordGenerationService.cs (+3 -3)
📝 src/iOS.Core/Controllers/PasswordGeneratorViewController.cs (+2 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix avoid ambiguous characters option. On mobile the value was being stored locally inverted of what the user had selected. Wasn't noticed during the session due to caching.

Code changes

Refactor the name of the property Ambiguous to AvoidAmbiguous, this naming was misleading.
Fixed bug where the boolean value for the AvoidAmbiguous property was being stored inverted.

  • GeneratorPageViewModel.cs:140: value was being stored inverted of what UI was showing

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1906 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/12/2022 **Status:** ✅ Merged **Merged:** 5/18/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bug/fix-avoid-ambiguous-chars` --- ### 📝 Commits (2) - [`f107076`](https://github.com/bitwarden/android/commit/f1070766cb338abc047e3a588394fdb48d6eeca1) PS-591 - iOS - Avoid ambiguous characters is activated inside the main client, but is deactivated when creating a vault item from the autofill prompt. #1664 - [`fb11d13`](https://github.com/bitwarden/android/commit/fb11d13c0d85ef804f2c4c4fd1b72662411786b3) PS-591 - iOS - Avoid ambiguous characters is activated inside the main client, but is deactivated when creating a vault item from the autofill prompt. #1664 ### 📊 Changes **5 files changed** (+26 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+1 -1) 📝 `src/App/Pages/Generator/GeneratorPageViewModel.cs` (+17 -7) 📝 `src/Core/Models/Domain/PasswordGenerationOptions.cs` (+3 -3) 📝 `src/Core/Services/PasswordGenerationService.cs` (+3 -3) 📝 `src/iOS.Core/Controllers/PasswordGeneratorViewController.cs` (+2 -2) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fix **avoid ambiguous characters** option. On mobile the value was being stored locally inverted of what the user had selected. Wasn't noticed during the session due to caching. ## Code changes Refactor the name of the property `Ambiguous` to `AvoidAmbiguous`, this naming was misleading. Fixed bug where the boolean value for the `AvoidAmbiguous` property was being stored inverted. * **GeneratorPageViewModel.cs:140:** value was being stored inverted of what UI was showing ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3212
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?