[PR #851] [MERGED] Fixed clipboard not clearing on Android 10 #2616

Closed
opened 2025-11-26 23:21:45 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/851
Author: @mpbw2
Created: 4/22/2020
Status: Merged
Merged: 4/23/2020
Merged by: @mpbw2

Base: masterHead: bugfix-clearclipboard


📝 Commits (1)

  • f5ea9f6 Fixed clipboard not clearing on Android 10

📊 Changes

5 files changed (+2 additions, -31 deletions)

View changed files

📝 src/Android/Android.csproj (+0 -1)
📝 src/Android/MainActivity.cs (+0 -1)
📝 src/Android/Receivers/ClearClipboardAlarmReceiver.cs (+1 -9)
📝 src/Android/Services/DeviceActionService.cs (+1 -1)
src/Android/Utilities/StaticStore.cs (+0 -19)

📄 Description

In Android 10 it is no longer possible to retrieve the contents of the clipboard unless you're in the foreground or an IME (keyboard, etc.). We're now simply clearing the clipboard contents after [time] regardless of what's in it.

  • Removed StaticStore class as its only purpose has been rendered obsolete
  • Replaced deprecated method of setting clipboard contents
  • The "bitwarden" label in the ClipData acts as a content description for developers. (It's not possible to retrieve this value without focus or IME either or I would have used it to at least identify ownership of the clipboard contents)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/851 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 4/22/2020 **Status:** ✅ Merged **Merged:** 4/23/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-clearclipboard` --- ### 📝 Commits (1) - [`f5ea9f6`](https://github.com/bitwarden/android/commit/f5ea9f604cdb8ec385297cdf6da66303b98e997d) Fixed clipboard not clearing on Android 10 ### 📊 Changes **5 files changed** (+2 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+0 -1) 📝 `src/Android/MainActivity.cs` (+0 -1) 📝 `src/Android/Receivers/ClearClipboardAlarmReceiver.cs` (+1 -9) 📝 `src/Android/Services/DeviceActionService.cs` (+1 -1) ➖ `src/Android/Utilities/StaticStore.cs` (+0 -19) </details> ### 📄 Description In Android 10 it is no longer possible to retrieve the contents of the clipboard unless you're in the foreground or an IME (keyboard, etc.). We're now simply clearing the clipboard contents after [time] regardless of what's in it. - Removed `StaticStore` class as its only purpose has been rendered obsolete - Replaced deprecated method of setting clipboard contents - The "bitwarden" label in the `ClipData` acts as a content description for developers. (It's not possible to retrieve this value without focus or IME either or I would have used it to at least identify ownership of the clipboard contents) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:45 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2616