github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-21 22:00:42 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1659] [CLOSED] Support installing development and prod concurrently #3036

New Issue
Closed
opened 2025-11-26 23:27:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1659
Author: @Hinton
Created: 11/23/2021
Status: ❌ Closed

Base: master ← Head: feature/dev-app-id

📝 Commits (3)

  • daeda1b Add separate bundle id when running app in development
  • 321fb54 Merge branch 'master' of github.com:bitwarden/mobile into feature/dev-app-id
  • 1f1b413 Only use info-dev.plist when in debug mode

📊 Changes

7 files changed (+381 additions, -3 deletions)

View changed files

➕ src/iOS.Autofill/Info-dev.plist (+101 -0)
📝 src/iOS.Autofill/iOS.Autofill.csproj (+7 -1)
📝 src/iOS.Core/Utilities/iOSCoreHelpers.cs (+8 -0)
➕ src/iOS.Extension/Info-dev.plist (+118 -0)
📝 src/iOS.Extension/iOS.Extension.csproj (+7 -1)
➕ src/iOS/Info-dev.plist (+133 -0)
📝 src/iOS/iOS.csproj (+7 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Configures the debug build to use a different app bundle id than release, allowing you to install the development build alongside a regular instance of the application.

Only the Debug build is affected and all other builds will use the production app bundle id, which should ensure that the AppStore and Testflight builds behave identical as before.

Code changes

I duplicated the Info.plist files to Info-dev.plist and modified the bundle id. And changed the projects to conditionally load the Info.plist files depending on which configuration is run.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1659 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 11/23/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/dev-app-id` --- ### 📝 Commits (3) - [`daeda1b`](https://github.com/bitwarden/android/commit/daeda1bfc6002fedb403ae68ea9f06102fa6e891) Add separate bundle id when running app in development - [`321fb54`](https://github.com/bitwarden/android/commit/321fb54b8e7c5df5ee7ee9dc7e257c5e70b14966) Merge branch 'master' of github.com:bitwarden/mobile into feature/dev-app-id - [`1f1b413`](https://github.com/bitwarden/android/commit/1f1b4132b4bd47bc6cfb2bc82d62c24dba88aa86) Only use info-dev.plist when in debug mode ### 📊 Changes **7 files changed** (+381 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `src/iOS.Autofill/Info-dev.plist` (+101 -0) 📝 `src/iOS.Autofill/iOS.Autofill.csproj` (+7 -1) 📝 `src/iOS.Core/Utilities/iOSCoreHelpers.cs` (+8 -0) ➕ `src/iOS.Extension/Info-dev.plist` (+118 -0) 📝 `src/iOS.Extension/iOS.Extension.csproj` (+7 -1) ➕ `src/iOS/Info-dev.plist` (+133 -0) 📝 `src/iOS/iOS.csproj` (+7 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Configures the debug build to use a different app bundle id than release, allowing you to install the development build alongside a regular instance of the application. Only the `Debug` build is affected and all other builds will use the production app bundle id, which should ensure that the AppStore and Testflight builds behave identical as before. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> I duplicated the `Info.plist` files to `Info-dev.plist` and modified the bundle id. And changed the projects to conditionally load the `Info.plist` files depending on which configuration is run. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3036
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?