github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3036] [MERGED] [PM-5917] Fix for send arrow now being touch sensitive to expand collapse #45581

New Issue
Closed
opened 2026-04-26 12:53:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:53:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3036
Author: @dinisvieira
Created: 2/26/2024
Status: ✅ Merged
Merged: 2/26/2024
Merged by: @dinisvieira

Base: main ← Head: feature/PM-5917-fix-send-arrow-not-tappable

📝 Commits (3)

  • f5656a5 PM-5917 fix for send arrow not being tappable
  • 21f6b56 Added min width to send icon button so that it has correct spacing like in Android and old Xamarin Forms app.
  • a2ebc81 Updated min width from previous commit to 25 instead of 20 for more equivalent look to xamarin forms app on iOS

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 src/Core/Pages/Send/SendAddEditPage.xaml (+4 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Touching the arrow icon itself doesn't trigger the expand/collapse command likely because the icon button is handling/ignoring the even and it doesn't propagate to the TapGestureRecognizer.

Code changes

Set the icon buttons to be InputTransparent.
Also took the chance to add the Min Width to ensure the arrow isn't right next to the label on iOS. (so it's looking like the Xamarin Forms app)

  • SendAddEditPage.xaml: Added InputTransparent="True" and MinimumWidthRequest="25"

Screenshots

Before After
iOS Before iOS After

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3036 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/26/2024 **Status:** ✅ Merged **Merged:** 2/26/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `main` ← **Head:** `feature/PM-5917-fix-send-arrow-not-tappable` --- ### 📝 Commits (3) - [`f5656a5`](https://github.com/bitwarden/android/commit/f5656a5afac0f441a1fdbc7e0d4901093b2f6794) PM-5917 fix for send arrow not being tappable - [`21f6b56`](https://github.com/bitwarden/android/commit/21f6b567612795dcaec39f049064a080f3c57d8f) Added min width to send icon button so that it has correct spacing like in Android and old Xamarin Forms app. - [`a2ebc81`](https://github.com/bitwarden/android/commit/a2ebc81a987f782199766a913a26172c666e24f5) Updated min width from previous commit to 25 instead of 20 for more equivalent look to xamarin forms app on iOS ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Send/SendAddEditPage.xaml` (+4 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Touching the arrow icon itself doesn't trigger the expand/collapse command likely because the icon button is handling/ignoring the even and it doesn't propagate to the TapGestureRecognizer. ## Code changes Set the icon buttons to be InputTransparent. Also took the chance to add the Min Width to ensure the arrow isn't right next to the label on iOS. (so it's looking like the Xamarin Forms app) * **SendAddEditPage.xaml:** Added `InputTransparent="True"` and `MinimumWidthRequest="25"` ## Screenshots Before | After :-------------------------:|:-------------------------: <img width="1024" alt="iOS Before" src="https://github.com/bitwarden/mobile/assets/2824952/d9197eaf-2f61-439c-ab9c-5f2efe155a8b"> | <img width="1024" alt="iOS After" src="https://github.com/bitwarden/mobile/assets/2824952/cacb3bb3-5b72-4858-b487-06922d28520b"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:53:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45581
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?