github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #3036] [PM-5917] Fix for send arrow now being touch sensitive to expand collapse #3979

New Issue
Closed
opened 2025-11-26 23:39:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:39:11 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3036

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Touching the arrow icon itself doesn't trigger the expand/collapse command likely because the icon button is handling/ignoring the even and it doesn't propagate to the TapGestureRecognizer.

Code changes

Set the icon buttons to be InputTransparent.
Also took the chance to add the Min Width to ensure the arrow isn't right next to the label on iOS. (so it's looking like the Xamarin Forms app)

  • SendAddEditPage.xaml: Added InputTransparent="True" and MinimumWidthRequest="25"

Screenshots

Before After
iOS Before iOS After

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3036 **State:** closed **Merged:** Yes --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Touching the arrow icon itself doesn't trigger the expand/collapse command likely because the icon button is handling/ignoring the even and it doesn't propagate to the TapGestureRecognizer. ## Code changes Set the icon buttons to be InputTransparent. Also took the chance to add the Min Width to ensure the arrow isn't right next to the label on iOS. (so it's looking like the Xamarin Forms app) * **SendAddEditPage.xaml:** Added `InputTransparent="True"` and `MinimumWidthRequest="25"` ## Screenshots Before | After :-------------------------:|:-------------------------: <img width="1024" alt="iOS Before" src="https://github.com/bitwarden/mobile/assets/2824952/d9197eaf-2f61-439c-ab9c-5f2efe155a8b"> | <img width="1024" alt="iOS After" src="https://github.com/bitwarden/mobile/assets/2824952/cacb3bb3-5b72-4858-b487-06922d28520b"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:39:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3979
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?