github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

Passphrase generation disallows empty word separator #1659

New Issue
Closed
opened 2025-11-26 22:54:46 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-26 22:54:46 -06:00
Owner
Copy Link

Originally created by @joseph082 on GitHub (May 19, 2023).

Steps To Reproduce

  1. Go to Generator
  2. Set the generator to generate a passphrase
  3. Make the word separator empty
  4. Generate a passphrase which will be generated with space as the word separator

Expected Result

The expected behavior is to generate a passphrase with the empty string as the word separator.

Actual Result

The actual behavior is to generate a passphrase with space as the word separator.

Screenshots or Videos

No response

Additional Context

Same issue as https://github.com/bitwarden/clients/issues/5437. This was intended behavior and not a bug (there's no other issue template). This issue https://github.com/bitwarden/desktop/issues/1099#issuecomment-941733523 says that allowing the empty string being the word separator is okay.

Operating System

Android

Operating System Version

No response

Device

No response

Build Version

2023.4.0 (6203)

Beta

  • Using a pre-release version of the application.
Originally created by @joseph082 on GitHub (May 19, 2023). ### Steps To Reproduce 1. Go to Generator 2. Set the generator to generate a passphrase 3. Make the word separator empty 4. Generate a passphrase which will be generated with space as the word separator ### Expected Result The expected behavior is to generate a passphrase with the empty string as the word separator. ### Actual Result The actual behavior is to generate a passphrase with space as the word separator. ### Screenshots or Videos _No response_ ### Additional Context Same issue as https://github.com/bitwarden/clients/issues/5437. This was intended behavior and not a bug (there's no other issue template). This issue https://github.com/bitwarden/desktop/issues/1099#issuecomment-941733523 says that allowing the empty string being the word separator is okay. ### Operating System Android ### Operating System Version _No response_ ### Device _No response_ ### Build Version 2023.4.0 (6203) ### Beta - [ ] Using a pre-release version of the application.
GiteaMirror added the bug label 2025-11-26 22:54:46 -06:00
GiteaMirror commented 2025-11-26 22:54:47 -06:00
Author
Owner
Copy Link

@atjbramley commented on GitHub (May 19, 2023):

Hi @joseph082 ,

Thank you for your report and PR.

I was able to reproduce this issue, and I have flagged this to our engineering team. A member will vet your submission shortly.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

@atjbramley commented on GitHub (May 19, 2023): Hi @joseph082 , Thank you for your report and PR. I was able to reproduce this issue, and I have flagged this to our engineering team. A member will vet your submission shortly. If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these. Thanks once again!
GiteaMirror commented 2025-11-26 22:54:47 -06:00
Author
Owner
Copy Link

@vvolkgang commented on GitHub (Jun 20, 2024):

Issue migrated to https://github.com/bitwarden/mobile/issues/2525

@vvolkgang commented on GitHub (Jun 20, 2024): Issue migrated to https://github.com/bitwarden/mobile/issues/2525
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#1659
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?