Replace CLOSE_BUDGET action

* Migrate to accountSlice

* Release notes

* Fix lint and typecheck errors

* Update types

* Fix lint

* Fix types

* Cleanup

* Rename file

* Rename state

* Cleanup types

* Cleanup

* Remove useActions

* AppStore type

* Fix typecheck error

* Fix typecheck error

* Move createAppAsyncThunk

* Fix errors

* Rename LinkAccountArgs to LinkAccountPayload

* Fix import transactions modal

* Update upgradingId type

* Undo accounts redux state rename

* Fix typecheck error

* Fix lint error

* Revert PayeeEntity import order

.eslintignore

@@ -1,28 +0,0 @@
-packages/api/app/bundle.api.js
-packages/api/dist
-packages/api/@types
-packages/api/migrations
-
-packages/crdt/dist
-
-packages/desktop-client/bundle.browser.js
-packages/desktop-client/build/
-packages/desktop-client/build-stats/
-packages/desktop-client/public/kcab/
-packages/desktop-client/public/data/
-packages/desktop-client/**/node_modules/*
-packages/desktop-client/node_modules/
-packages/desktop-client/src/icons/**/*
-packages/desktop-client/test-results/
-packages/desktop-client/playwright-report/
-
-packages/desktop-electron/client-build/
-packages/desktop-electron/dist/
-
-packages/import-ynab4/**/node_modules/*
-
-packages/import-ynab5/**/node_modules/*
-
-packages/loot-core/**/node_modules/*
-packages/loot-core/**/lib-dist/*
-packages/loot-core/**/proto/*

.eslintrc.js

@@ -1,608 +0,0 @@
-const path = require('path');
-
-const rulesDirPlugin = require('eslint-plugin-rulesdir');
-rulesDirPlugin.RULES_DIR = path.join(
-  __dirname,
-  'packages',
-  'eslint-plugin-actual',
-  'lib',
-  'rules',
-);
-
-const ruleFCMsg =
-  'Type the props argument and let TS infer or use ComponentType for a component prop';
-
-const restrictedImportPatterns = [
-  {
-    group: ['*.api', '*.web', '*.electron'],
-    message: 'Don’t directly reference imports from other platforms',
-  },
-  {
-    group: ['uuid'],
-    importNames: ['*'],
-    message: "Use `import { v4 as uuidv4 } from 'uuid'` instead",
-  },
-];
-
-const restrictedImportColors = [
-  {
-    group: ['**/style', '**/colors'],
-    importNames: ['colors'],
-    message: 'Please use themes instead of colors',
-  },
-];
-
-module.exports = {
-  root: true,
-  env: {
-    browser: true,
-    commonjs: true,
-    es6: true,
-    jest: true,
-    node: true,
-  },
-  plugins: [
-    'prettier',
-    'import',
-    'rulesdir',
-    '@typescript-eslint',
-    'jsx-a11y',
-    'react-hooks',
-  ],
-  extends: [
-    'plugin:react/recommended',
-    'plugin:react/jsx-runtime',
-    'plugin:prettier/recommended',
-    'plugin:@typescript-eslint/recommended',
-    'plugin:import/typescript',
-  ],
-  parser: '@typescript-eslint/parser',
-  parserOptions: { project: [path.join(__dirname, './tsconfig.json')] },
-  reportUnusedDisableDirectives: true,
-  globals: {
-    globalThis: false,
-    vi: true,
-  },
-  rules: {
-    // http://eslint.org/docs/rules/
-    'array-callback-return': 'warn',
-    'default-case': ['warn', { commentPattern: '^no default$' }],
-    'dot-location': ['warn', 'property'],
-    eqeqeq: ['warn', 'smart'],
-    'new-parens': 'warn',
-    'no-array-constructor': 'warn',
-    'no-caller': 'warn',
-    'no-cond-assign': ['warn', 'except-parens'],
-    'no-const-assign': 'warn',
-    'no-control-regex': 'warn',
-    'no-delete-var': 'warn',
-    'no-dupe-args': 'warn',
-    'no-dupe-class-members': 'warn',
-    'no-dupe-keys': 'warn',
-    'no-duplicate-case': 'warn',
-    'no-empty-character-class': 'warn',
-    'no-empty-pattern': 'warn',
-    'no-eval': 'warn',
-    'no-ex-assign': 'warn',
-    'no-extend-native': 'warn',
-    'no-extra-bind': 'warn',
-    'no-extra-label': 'warn',
-    'no-fallthrough': 'warn',
-    'no-func-assign': 'warn',
-    'no-implied-eval': 'warn',
-    'no-invalid-regexp': 'warn',
-    'no-iterator': 'warn',
-    'no-label-var': 'warn',
-    'no-labels': ['warn', { allowLoop: true, allowSwitch: false }],
-    'no-lone-blocks': 'warn',
-    'no-mixed-operators': [
-      'warn',
-      {
-        groups: [
-          ['&', '|', '^', '~', '<<', '>>', '>>>'],
-          ['==', '!=', '===', '!==', '>', '>=', '<', '<='],
-          ['&&', '||'],
-          ['in', 'instanceof'],
-        ],
-        allowSamePrecedence: false,
-      },
-    ],
-    'no-multi-str': 'warn',
-    'no-global-assign': 'warn',
-    'no-unsafe-negation': 'warn',
-    'no-new-func': 'warn',
-    'no-new-object': 'warn',
-    'no-new-symbol': 'warn',
-    'no-new-wrappers': 'warn',
-    'no-obj-calls': 'warn',
-    'no-octal': 'warn',
-    'no-octal-escape': 'warn',
-    'no-redeclare': 'warn',
-    'no-regex-spaces': 'warn',
-    'no-script-url': 'warn',
-    'no-self-assign': 'warn',
-    'no-self-compare': 'warn',
-    'no-sequences': 'warn',
-    'no-shadow-restricted-names': 'warn',
-    'no-sparse-arrays': 'warn',
-    'no-template-curly-in-string': 'warn',
-    'no-this-before-super': 'warn',
-    'no-throw-literal': 'warn',
-    'no-undef': 'error',
-    'no-unreachable': 'warn',
-    'no-unused-expressions': [
-      'error',
-      {
-        allowShortCircuit: true,
-        allowTernary: true,
-        allowTaggedTemplates: true,
-      },
-    ],
-    'no-unused-labels': 'warn',
-    'no-use-before-define': [
-      'warn',
-      {
-        functions: false,
-        classes: false,
-        variables: false,
-      },
-    ],
-    'no-useless-computed-key': 'warn',
-    'no-useless-concat': 'warn',
-    'no-useless-constructor': 'warn',
-    'no-useless-escape': 'warn',
-    'no-useless-rename': [
-      'warn',
-      {
-        ignoreDestructuring: false,
-        ignoreImport: false,
-        ignoreExport: false,
-      },
-    ],
-    'no-with': 'warn',
-    'no-whitespace-before-property': 'warn',
-    'react-hooks/exhaustive-deps': [
-      'warn',
-      {
-        additionalHooks: '(useQuery)',
-      },
-    ],
-    'require-yield': 'warn',
-    'rest-spread-spacing': ['warn', 'never'],
-    strict: ['warn', 'never'],
-    'unicode-bom': ['warn', 'never'],
-    'use-isnan': 'warn',
-    'valid-typeof': 'warn',
-    'no-restricted-properties': [
-      'error',
-      {
-        object: 'require',
-        property: 'ensure',
-        message:
-          'Please use import() instead. More info: https://facebook.github.io/create-react-app/docs/code-splitting',
-      },
-      {
-        object: 'System',
-        property: 'import',
-        message:
-          'Please use import() instead. More info: https://facebook.github.io/create-react-app/docs/code-splitting',
-      },
-    ],
-    'getter-return': 'warn',
-
-    // https://github.com/benmosher/eslint-plugin-import/tree/master/docs/rules
-    'import/first': 'error',
-    'import/no-amd': 'error',
-    'import/no-anonymous-default-export': 'warn',
-    'import/no-webpack-loader-syntax': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/tree/master/docs/rules
-    'react/forbid-foreign-prop-types': ['warn', { allowInPropTypes: true }],
-    'react/jsx-no-comment-textnodes': 'warn',
-    'react/jsx-no-duplicate-props': 'warn',
-    'react/jsx-no-target-blank': 'warn',
-    'react/jsx-no-undef': 'error',
-    'react/jsx-pascal-case': [
-      'warn',
-      {
-        allowAllCaps: true,
-        ignore: [],
-      },
-    ],
-    'react/no-danger-with-children': 'warn',
-    // Disabled because of undesirable warnings
-    // See https://github.com/facebook/create-react-app/issues/5204 for
-    // blockers until its re-enabled
-    // 'react/no-deprecated': 'warn',
-    'react/no-direct-mutation-state': 'warn',
-    'react/no-is-mounted': 'warn',
-    'react/no-typos': 'error',
-    'react/require-render-return': 'error',
-    'react/style-prop-object': 'warn',
-
-    // https://github.com/evcohen/eslint-plugin-jsx-a11y/tree/master/docs/rules
-    'jsx-a11y/alt-text': 'warn',
-    'jsx-a11y/anchor-has-content': 'warn',
-    'jsx-a11y/anchor-is-valid': [
-      'warn',
-      {
-        aspects: ['noHref', 'invalidHref'],
-      },
-    ],
-    'jsx-a11y/aria-activedescendant-has-tabindex': 'warn',
-    'jsx-a11y/aria-props': 'warn',
-    'jsx-a11y/aria-proptypes': 'warn',
-    'jsx-a11y/aria-role': ['warn', { ignoreNonDOM: true }],
-    'jsx-a11y/aria-unsupported-elements': 'warn',
-    'jsx-a11y/heading-has-content': 'warn',
-    'jsx-a11y/iframe-has-title': 'warn',
-    'jsx-a11y/img-redundant-alt': 'warn',
-    'jsx-a11y/no-access-key': 'warn',
-    'jsx-a11y/no-distracting-elements': 'warn',
-    'jsx-a11y/no-redundant-roles': 'warn',
-    'jsx-a11y/role-has-required-aria-props': 'warn',
-    'jsx-a11y/role-supports-aria-props': 'warn',
-    'jsx-a11y/scope': 'warn',
-
-    // https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks
-    'react-hooks/rules-of-hooks': 'error',
-
-    'prettier/prettier': 'warn',
-
-    // Note: base rule explicitly disabled in favor of the TS one
-    'no-unused-vars': 'off',
-    '@typescript-eslint/no-unused-vars': [
-      'warn',
-      {
-        varsIgnorePattern: '^(_|React)',
-        ignoreRestSiblings: true,
-        caughtErrors: 'none',
-      },
-    ],
-
-    curly: ['warn', 'multi-line', 'consistent'],
-
-    'no-restricted-globals': ['warn'].concat(
-      require('confusing-browser-globals').filter(g => g !== 'self'),
-    ),
-
-    'react/jsx-filename-extension': [
-      'warn',
-      { extensions: ['.jsx', '.tsx'], allow: 'as-needed' },
-    ],
-    'react/jsx-no-useless-fragment': 'warn',
-    'react/self-closing-comp': 'warn',
-    'react/no-unstable-nested-components': [
-      'warn',
-      { allowAsProps: true, customValidators: ['formatter'] },
-    ],
-
-    'rulesdir/typography': 'warn',
-    'rulesdir/prefer-if-statement': 'warn',
-
-    // https://github.com/eslint/eslint/issues/16954
-    // https://github.com/eslint/eslint/issues/16953
-    'no-loop-func': 'off',
-
-    // Do don't need this as we're using TypeScript
-    'react/prop-types': 'off',
-
-    // TODO: re-enable these rules
-    'react/react-in-jsx-scope': 'off',
-
-    'no-var': 'warn',
-    'react/jsx-curly-brace-presence': 'warn',
-    'object-shorthand': ['warn', 'properties'],
-
-    'import/extensions': [
-      'warn',
-      'never',
-      {
-        json: 'always',
-      },
-    ],
-    'import/no-useless-path-segments': 'warn',
-    'import/no-duplicates': ['warn', { 'prefer-inline': true }],
-    'import/no-unused-modules': ['warn', { unusedExports: true }],
-    'import/order': [
-      'warn',
-      {
-        alphabetize: {
-          caseInsensitive: true,
-          order: 'asc',
-        },
-        groups: [
-          'builtin', // Built-in types are first
-          'external',
-          'parent',
-          'sibling',
-          'index', // Then the index file
-        ],
-        'newlines-between': 'always',
-        pathGroups: [
-          // Enforce that React (and react-related packages) is the first import
-          { group: 'builtin', pattern: 'react?(-*)', position: 'before' },
-          // Separate imports from Actual from "real" external imports
-          {
-            group: 'external',
-            pattern: 'loot-{core,design}/**/*',
-            position: 'after',
-          },
-        ],
-        pathGroupsExcludedImportTypes: ['react'],
-      },
-    ],
-
-    'no-restricted-syntax': [
-      'warn',
-      {
-        // forbid React.* as they are legacy https://twitter.com/dan_abramov/status/1308739731551858689
-        selector:
-          ":matches(MemberExpression[object.name='React'], TSQualifiedName[left.name='React'])",
-        message:
-          'Using default React import is discouraged, please use named exports directly instead.',
-      },
-      {
-        // forbid <a> in favor of <Link>
-        selector: 'JSXOpeningElement[name.name="a"]',
-        message: 'Using <a> is discouraged, please use <Link> instead.',
-      },
-    ],
-    'no-restricted-imports': [
-      'warn',
-      { patterns: [...restrictedImportPatterns, ...restrictedImportColors] },
-    ],
-
-    '@typescript-eslint/ban-ts-comment': [
-      'error',
-      { 'ts-ignore': 'allow-with-description' },
-    ],
-
-    // Rules disable during TS migration
-    '@typescript-eslint/no-var-requires': 'off',
-    'prefer-const': 'warn',
-    'prefer-spread': 'off',
-    '@typescript-eslint/no-empty-function': 'off',
-    '@typescript-eslint/no-require-imports': 'off',
-    'import/no-default-export': 'warn',
-  },
-  overrides: [
-    {
-      files: ['**/*.ts?(x)'],
-      parser: '@typescript-eslint/parser',
-      parserOptions: {
-        ecmaVersion: 2018,
-        sourceType: 'module',
-        ecmaFeatures: {
-          jsx: true,
-        },
-
-        // typescript-eslint specific options
-        warnOnUnsupportedTypeScriptVersion: true,
-      },
-      plugins: ['@typescript-eslint'],
-      // If adding a typescript-eslint version of an existing ESLint rule,
-      // make sure to disable the ESLint rule here.
-      rules: {
-        // TypeScript's `noFallthroughCasesInSwitch` option is more robust (#6906)
-        'default-case': 'off',
-        // 'tsc' already handles this (https://github.com/typescript-eslint/typescript-eslint/issues/291)
-        'no-dupe-class-members': 'off',
-        // 'tsc' already handles this (https://github.com/typescript-eslint/typescript-eslint/issues/477)
-        'no-undef': 'off',
-
-        // Add TypeScript specific rules (and turn off ESLint equivalents)
-        '@typescript-eslint/consistent-type-assertions': 'warn',
-        'no-array-constructor': 'off',
-        '@typescript-eslint/no-array-constructor': 'warn',
-        'no-redeclare': 'off',
-        '@typescript-eslint/no-redeclare': 'warn',
-        'no-use-before-define': 'off',
-        '@typescript-eslint/no-use-before-define': [
-          'warn',
-          {
-            functions: false,
-            classes: false,
-            variables: false,
-            typedefs: false,
-          },
-        ],
-        'no-unused-expressions': 'off',
-        '@typescript-eslint/no-unused-expressions': [
-          'error',
-          {
-            allowShortCircuit: true,
-            allowTernary: true,
-            allowTaggedTemplates: true,
-          },
-        ],
-        'no-useless-constructor': 'off',
-        '@typescript-eslint/no-useless-constructor': 'warn',
-      },
-    },
-    {
-      files: ['.eslintrc.js', './**/.eslintrc.js'],
-      parserOptions: { project: null },
-      rules: {
-        '@typescript-eslint/consistent-type-exports': 'off',
-      },
-    },
-    {
-      files: [
-        './packages/desktop-client/**/*.{ts,tsx}',
-        './packages/loot-core/src/client/**/*.{ts,tsx}',
-      ],
-      rules: {
-        // enforce type over interface
-        '@typescript-eslint/consistent-type-definitions': ['warn', 'type'],
-        // enforce import type
-        '@typescript-eslint/consistent-type-imports': [
-          'warn',
-          { prefer: 'type-imports', fixStyle: 'inline-type-imports' },
-        ],
-        '@typescript-eslint/no-restricted-types': [
-          'warn',
-          {
-            types: {
-              // forbid FC as superflous
-              FunctionComponent: { message: ruleFCMsg },
-              FC: { message: ruleFCMsg },
-            },
-          },
-        ],
-      },
-    },
-    {
-      files: ['./packages/desktop-client/**/*'],
-      excludedFiles: [
-        './packages/desktop-client/src/hooks/useNavigate.{ts,tsx}',
-      ],
-      rules: {
-        'no-restricted-imports': [
-          'warn',
-          {
-            patterns: [
-              {
-                group: ['react-router-dom'],
-                importNames: ['useNavigate'],
-                message: 'Please use Actual’s useNavigate() hook instead.',
-              },
-            ],
-          },
-        ],
-      },
-    },
-    {
-      files: ['./packages/loot-core/src/**/*'],
-      rules: {
-        'no-restricted-imports': [
-          'warn',
-          {
-            patterns: [
-              ...restrictedImportPatterns,
-              {
-                group: ['loot-core/**'],
-                message:
-                  'Please use relative imports in loot-core instead of importing from `loot-core/*`',
-              },
-            ],
-          },
-        ],
-      },
-    },
-    {
-      files: [
-        'packages/loot-core/src/types/**/*',
-        'packages/loot-core/src/client/state-types/**/*',
-        '**/icons/**/*',
-        '**/{mocks,__mocks__}/**/*',
-        // can't correctly resolve usages
-        '**/*.{testing,electron,browser,web,api}.ts',
-      ],
-      rules: { 'import/no-unused-modules': 'off' },
-    },
-    {
-      files: [
-        './packages/desktop-client/src/style/index.*',
-        './packages/desktop-client/src/style/palette.*',
-      ],
-      rules: {
-        'no-restricted-imports': ['off', { patterns: restrictedImportColors }],
-      },
-    },
-    {
-      files: [
-        './packages/api/migrations/*',
-        './packages/loot-core/migrations/*',
-      ],
-      rules: {
-        'import/no-default-export': 'off',
-      },
-    },
-    {
-      // TODO: fix the issues in these files
-      files: [
-        './packages/desktop-client/src/components/accounts/Account.jsx',
-        './packages/desktop-client/src/components/accounts/MobileAccount.jsx',
-        './packages/desktop-client/src/components/accounts/MobileAccounts.jsx',
-        './packages/desktop-client/src/components/App.tsx',
-        './packages/desktop-client/src/components/budget/BudgetCategories.jsx',
-        './packages/desktop-client/src/components/budget/BudgetSummaries.tsx',
-        './packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx',
-        './packages/desktop-client/src/components/budget/index.tsx',
-        './packages/desktop-client/src/components/budget/MobileBudget.tsx',
-        './packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx',
-        './packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx',
-        './packages/desktop-client/src/components/common/Menu.tsx',
-        './packages/desktop-client/src/components/FinancesApp.tsx',
-        './packages/desktop-client/src/components/GlobalKeys.ts',
-        './packages/desktop-client/src/components/LoggedInUser.tsx',
-        './packages/desktop-client/src/components/manager/ManagementApp.jsx',
-        './packages/desktop-client/src/components/manager/subscribe/common.tsx',
-        './packages/desktop-client/src/components/ManageRules.tsx',
-        './packages/desktop-client/src/components/mobile/MobileAmountInput.jsx',
-        './packages/desktop-client/src/components/mobile/MobileNavTabs.tsx',
-        './packages/desktop-client/src/components/Modals.tsx',
-        './packages/desktop-client/src/components/modals/EditRule.jsx',
-        './packages/desktop-client/src/components/modals/ImportTransactions.jsx',
-        './packages/desktop-client/src/components/modals/MergeUnusedPayees.jsx',
-        './packages/desktop-client/src/components/Notifications.tsx',
-        './packages/desktop-client/src/components/payees/ManagePayees.jsx',
-        './packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx',
-        './packages/desktop-client/src/components/payees/PayeeTable.tsx',
-        './packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx',
-        './packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx',
-        './packages/desktop-client/src/components/reports/reports/CashFlowCard.jsx',
-        './packages/desktop-client/src/components/reports/reports/CustomReport.jsx',
-        './packages/desktop-client/src/components/reports/reports/NetWorthCard.jsx',
-        './packages/desktop-client/src/components/reports/SaveReportName.tsx',
-        './packages/desktop-client/src/components/reports/useReport.ts',
-        './packages/desktop-client/src/components/schedules/ScheduleDetails.jsx',
-        './packages/desktop-client/src/components/schedules/SchedulesTable.tsx',
-        './packages/desktop-client/src/components/select/DateSelect.tsx',
-        './packages/desktop-client/src/components/sidebar/Tools.tsx',
-        './packages/desktop-client/src/components/sort.tsx',
-        './packages/desktop-client/src/components/spreadsheet/useSheetValue.ts',
-        './packages/desktop-client/src/components/table.tsx',
-        './packages/desktop-client/src/components/Titlebar.tsx',
-        './packages/desktop-client/src/components/transactions/MobileTransaction.jsx',
-        './packages/desktop-client/src/components/transactions/SelectedTransactions.jsx',
-        './packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx',
-        './packages/desktop-client/src/components/transactions/TransactionList.jsx',
-        './packages/desktop-client/src/components/transactions/TransactionsTable.jsx',
-        './packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx',
-        './packages/desktop-client/src/hooks/useAccounts.ts',
-        './packages/desktop-client/src/hooks/useCategories.ts',
-        './packages/desktop-client/src/hooks/usePayees.ts',
-        './packages/desktop-client/src/hooks/useProperFocus.tsx',
-        './packages/desktop-client/src/hooks/useSelected.tsx',
-        './packages/loot-core/src/client/query-hooks.tsx',
-      ],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
-    {
-      files: [
-        '.eslintrc.js',
-        '*.test.js',
-        '*.test.ts',
-        '*.test.jsx',
-        '*.test.tsx',
-      ],
-      rules: {
-        'rulesdir/typography': 'off',
-      },
-    },
-  ],
-  settings: {
-    react: {
-      version: 'detect',
-    },
-    'import/resolver': {
-      typescript: {
-        alwaysTryTypes: true,
-      },
-    },
-  },
-};

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -23,8 +23,6 @@ body:
       options:
         - label: 'I have searched and found no existing issue'
           required: true
-        - label: 'I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)'
-          required: true
     validations:
       required: true
   - type: textarea
@@ -36,6 +34,14 @@ body:
       value: 'A bug happened!'
     validations:
       required: true
+  - type: textarea
+    id: reproduction
+    attributes:
+      label: How can we reproduce the issue?
+      description: Please give step-by-step instructions on how to reproduce the issue. In most cases this might also require uploading a sample budget/import file.
+      value: 'How can we reproduce the issue?'
+    validations:
+      required: true
   - type: markdown
     id: env-info
     attributes:

.github/actions/setup/action.yml

@@ -1,5 +1,15 @@
 name: Setup
 
+inputs:
+  working-directory:
+    description: 'Working directory to run in, default .'
+    required: false
+    default: '.'
+  download-translations:
+    description: 'Whether to download translations as part of setup, default true'
+    required: false
+    default: 'true'
+
 runs:
   using: composite
   steps:
@@ -7,13 +17,24 @@ runs:
       uses: actions/setup-node@v4
       with:
         node-version: 18.16.0
+    - name: Install yarn
+      run: npm install -g yarn
+      shell: bash
+      if: ${{ env.ACT }}
     - name: Cache
       uses: actions/cache@v4
       id: cache
       with:
-        path: '**/node_modules'
-        key: yarn-v1-${{ runner.os }}-${{ hashFiles('.nvmrc') }}-${{ hashFiles('**/yarn.lock') }}
+        path: ${{ format('{0}/**/node_modules', inputs.working-directory) }}
+        key: yarn-v1-${{ runner.os }}-${{ hashFiles(format('{0}/.nvmrc', inputs.working-directory)) }}-${{ hashFiles(format('{0}/**/yarn.lock', inputs.working-directory)) }}
     - name: Install
+      working-directory: ${{ inputs.working-directory }}
       run: yarn --immutable
       shell: bash
       if: steps.cache.outputs.cache-hit != 'true'
+    - name: Download translations
+      uses: actions/checkout@v4
+      with:
+        repository: actualbudget/translations
+        path: ${{ inputs.working-directory }}/packages/desktop-client/locale
+      if: ${{ inputs.download-translations == 'true' }}

.github/workflows/electron-master.yml

@@ -80,6 +80,7 @@ jobs:
       - name: Add to Release
         uses: softprops/action-gh-release@v2
         with:
+          draft: true
           files: |
             packages/desktop-electron/dist/*.dmg
             packages/desktop-electron/dist/*.exe

.github/workflows/i18n-string-extract-master.yml

@@ -0,0 +1,80 @@
+name: Extract and upload i18n strings
+
+on:
+  schedule:
+    # 4am UTC
+    - cron: "0 4 * * *"
+  workflow_dispatch:
+
+jobs:
+  extract-and-upload-i18n-strings:
+    runs-on: ubuntu-latest
+    if: github.repository == 'actualbudget/actual'
+    steps:
+      - name: Check out main repository
+        uses: actions/checkout@v4
+        with:
+          path: actual
+      - name: Set up environment
+        uses: ./actual/.github/actions/setup
+        with:
+          working-directory: actual
+          download-translations: false  # As we'll manually clone instead
+      - name: Configure Git config
+        run: |
+          git config --global user.name "github-actions[bot]"
+          git config --global user.email "41898282+github-actions[bot]@users.noreply.github.com"
+      - name: Configure i18n client
+        run: |
+          pip install wlc
+
+      - name: Lock translations
+        run: |
+          wlc \
+            --url https://hosted.weblate.org/api/ \
+            --key "${{ secrets.WEBLATE_API_KEY_CI_STRINGS }}" \
+            lock \
+            actualbudget/actual
+
+      - name: Update VCS with latest translations
+        run: |
+          wlc \
+            --url https://hosted.weblate.org/api/ \
+            --key "${{ secrets.WEBLATE_API_KEY_CI_STRINGS }}" \
+            pull \
+            actualbudget/actual
+      - name: Check out updated translations
+        uses: actions/checkout@v4
+        with:
+          ssh-key: ${{ secrets.STRING_IMPORT_DEPLOY_KEY }}
+          repository: actualbudget/translations
+          path: translations
+      - name: Generate i18n strings
+        working-directory: actual
+        run: |
+          mkdir -p packages/desktop-client/locale/
+          cp ../translations/en.json packages/desktop-client/locale/
+          yarn generate:i18n
+          if [[ ! -f packages/desktop-client/locale/en.json ]]; then
+            echo "File packages/desktop-client/locale/en.json not found. Ensure the file was generated correctly."
+            exit 1
+          fi
+      - name: Check in new i18n strings
+        working-directory: translations
+        run: |
+          cp ../actual/packages/desktop-client/locale/en.json .
+          git add .
+          if git commit -m "Update source strings"; then
+            git push
+          else
+            echo "No changes to commit"
+          fi
+
+      - name: Unlock translations
+        if: always()  # Clean up even on failure
+        run: |
+          wlc \
+            --url https://hosted.weblate.org/api/ \
+            --key "${{ secrets.WEBLATE_API_KEY_CI_STRINGS }}" \
+            unlock \
+            actualbudget/actual

TODO.txt

@@ -1 +0,0 @@
-Figure out why loot-core-server is not detecting loot-core-shared files.

bin/package-browser

@@ -4,8 +4,15 @@ ROOT=`dirname $0`
 
 cd "$ROOT/.."
 
-yarn workspace loot-core-server build:browser
-# yarn workspace loot-core build:browser
+echo "Updating translations..."
+if ! [ -d packages/desktop-client/locale ]; then
+    git clone https://github.com/actualbudget/translations packages/desktop-client/locale
+fi
+pushd packages/desktop-client/locale > /dev/null
+git pull
+popd > /dev/null
+
+yarn workspace loot-core build:browser
 yarn workspace @actual-app/web build:browser
 
 echo "packages/desktop-client/build"

bin/package-electron

@@ -34,8 +34,7 @@ if [ "$OSTYPE" == "msys" ]; then
     fi
 fi
 
-yarn workspace loot-core-server build:node
-# yarn workspace loot-core build:node
+yarn workspace loot-core build:node
 
 yarn workspace @actual-app/web build --mode=desktop # electron specific build
 

eslint.config.mjs

@@ -0,0 +1,816 @@
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+import globals from 'globals';
+
+import pluginImport from 'eslint-plugin-import';
+import pluginJSXA11y from 'eslint-plugin-jsx-a11y';
+import pluginPrettier from 'eslint-plugin-prettier/recommended';
+import pluginReact from 'eslint-plugin-react';
+import pluginReactHooks from 'eslint-plugin-react-hooks';
+import pluginRulesDir from 'eslint-plugin-rulesdir';
+import pluginTypescript from 'typescript-eslint';
+
+import tsParser from '@typescript-eslint/parser';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+
+pluginRulesDir.RULES_DIR = path.join(
+  __dirname,
+  'packages',
+  'eslint-plugin-actual',
+  'lib',
+  'rules',
+);
+
+const confusingBrowserGlobals = [
+  // https://github.com/facebook/create-react-app/tree/main/packages/confusing-browser-globals
+  'addEventListener',
+  'blur',
+  'close',
+  'closed',
+  'confirm',
+  'defaultStatus',
+  'defaultstatus',
+  'event',
+  'external',
+  'find',
+  'focus',
+  'frameElement',
+  'frames',
+  'history',
+  'innerHeight',
+  'innerWidth',
+  'length',
+  'location',
+  'locationbar',
+  'menubar',
+  'moveBy',
+  'moveTo',
+  'name',
+  'onblur',
+  'onerror',
+  'onfocus',
+  'onload',
+  'onresize',
+  'onunload',
+  'open',
+  'opener',
+  'opera',
+  'outerHeight',
+  'outerWidth',
+  'pageXOffset',
+  'pageYOffset',
+  'parent',
+  'print',
+  'removeEventListener',
+  'resizeBy',
+  'resizeTo',
+  'screen',
+  'screenLeft',
+  'screenTop',
+  'screenX',
+  'screenY',
+  'scroll',
+  'scrollbars',
+  'scrollBy',
+  'scrollTo',
+  'scrollX',
+  'scrollY',
+  'status',
+  'statusbar',
+  'stop',
+  'toolbar',
+  'top',
+];
+
+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  {
+    ignores: [
+      'packages/api/app/bundle.api.js',
+      'packages/api/dist',
+      'packages/api/@types',
+      'packages/api/migrations',
+      'packages/crdt/dist',
+      'packages/desktop-client/bundle.browser.js',
+      'packages/desktop-client/build/',
+      'packages/desktop-client/build-electron/',
+      'packages/desktop-client/build-stats/',
+      'packages/desktop-client/public/kcab/',
+      'packages/desktop-client/public/data/',
+      'packages/desktop-client/**/node_modules/*',
+      'packages/desktop-client/node_modules/',
+      'packages/desktop-client/src/icons/**/*',
+      'packages/desktop-client/test-results/',
+      'packages/desktop-client/playwright-report/',
+      'packages/desktop-electron/client-build/',
+      'packages/desktop-electron/build/',
+      'packages/desktop-electron/dist/',
+      'packages/import-ynab4/**/node_modules/*',
+      'packages/import-ynab5/**/node_modules/*',
+      'packages/loot-core/**/node_modules/*',
+      'packages/loot-core/**/lib-dist/*',
+      'packages/loot-core/**/proto/*',
+      '.yarn/*',
+      '.github/*',
+    ],
+  },
+  {
+    linterOptions: {
+      reportUnusedDisableDirectives: true,
+    },
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.commonjs,
+        ...globals.jest,
+        ...globals.node,
+        globalThis: false,
+        vi: true,
+      },
+    },
+    settings: {
+      react: {
+        version: 'detect',
+      },
+
+      'import/resolver': {
+        typescript: {
+          alwaysTryTypes: true,
+        },
+      },
+    },
+  },
+  pluginReact.configs.flat.recommended,
+  pluginReact.configs.flat['jsx-runtime'],
+  pluginPrettier,
+  ...pluginTypescript.configs.recommended,
+  pluginImport.flatConfigs.recommended,
+  {
+    plugins: {
+      'react-hooks': pluginReactHooks,
+      'jsx-a11y': pluginJSXA11y,
+      rulesdir: pluginRulesDir,
+    },
+  },
+  {
+    files: ['**/*.{js,ts,jsx,tsx}'],
+    rules: {
+      // http://eslint.org/docs/rules/
+      'array-callback-return': 'warn',
+
+      'default-case': [
+        'warn',
+        {
+          commentPattern: '^no default$',
+        },
+      ],
+
+      curly: ['warn', 'multi-line', 'consistent'],
+      'dot-location': ['warn', 'property'],
+      eqeqeq: ['warn', 'smart'],
+      'new-parens': 'warn',
+      'no-array-constructor': 'warn',
+      'no-caller': 'warn',
+      'no-cond-assign': ['warn', 'except-parens'],
+      'no-const-assign': 'warn',
+      'no-control-regex': 'warn',
+      'no-delete-var': 'warn',
+      'no-dupe-args': 'warn',
+      'no-dupe-class-members': 'warn',
+      'no-dupe-keys': 'warn',
+      'no-duplicate-case': 'warn',
+      'no-empty-character-class': 'warn',
+      'no-empty-pattern': 'warn',
+      'no-eval': 'warn',
+      'no-ex-assign': 'warn',
+      'no-extend-native': 'warn',
+      'no-extra-bind': 'warn',
+      'no-extra-label': 'warn',
+      'no-fallthrough': 'warn',
+      'no-func-assign': 'warn',
+      'no-implied-eval': 'warn',
+      'no-invalid-regexp': 'warn',
+      'no-iterator': 'warn',
+      'no-label-var': 'warn',
+
+      'no-labels': [
+        'warn',
+        {
+          allowLoop: true,
+          allowSwitch: false,
+        },
+      ],
+
+      'no-lone-blocks': 'warn',
+
+      'no-mixed-operators': [
+        'warn',
+        {
+          groups: [
+            ['&', '|', '^', '~', '<<', '>>', '>>>'],
+            ['==', '!=', '===', '!==', '>', '>=', '<', '<='],
+            ['&&', '||'],
+            ['in', 'instanceof'],
+          ],
+
+          allowSamePrecedence: false,
+        },
+      ],
+
+      'no-multi-str': 'warn',
+      'no-global-assign': 'warn',
+      'no-unsafe-negation': 'warn',
+      'no-new-func': 'warn',
+      'no-new-object': 'warn',
+      'no-new-symbol': 'warn',
+      'no-new-wrappers': 'warn',
+      'no-obj-calls': 'warn',
+      'no-octal': 'warn',
+      'no-octal-escape': 'warn',
+      'no-redeclare': 'warn',
+      'no-regex-spaces': 'warn',
+      'no-script-url': 'warn',
+      'no-self-assign': 'warn',
+      'no-self-compare': 'warn',
+      'no-sequences': 'warn',
+      'no-shadow-restricted-names': 'warn',
+      'no-sparse-arrays': 'warn',
+      'no-template-curly-in-string': 'warn',
+      'no-this-before-super': 'warn',
+      'no-throw-literal': 'warn',
+      'no-undef': 'error',
+      'no-unreachable': 'warn',
+
+      'no-unused-expressions': [
+        'error',
+        {
+          allowShortCircuit: true,
+          allowTernary: true,
+          allowTaggedTemplates: true,
+        },
+      ],
+
+      'no-unused-labels': 'warn',
+
+      'no-use-before-define': [
+        'warn',
+        {
+          functions: false,
+          classes: false,
+          variables: false,
+        },
+      ],
+
+      'no-useless-computed-key': 'warn',
+      'no-useless-concat': 'warn',
+      'no-useless-constructor': 'warn',
+      'no-useless-escape': 'warn',
+
+      'no-useless-rename': [
+        'warn',
+        {
+          ignoreDestructuring: false,
+          ignoreImport: false,
+          ignoreExport: false,
+        },
+      ],
+
+      'no-with': 'warn',
+      'no-whitespace-before-property': 'warn',
+
+      'require-yield': 'warn',
+      'rest-spread-spacing': ['warn', 'never'],
+      strict: ['warn', 'never'],
+      'unicode-bom': ['warn', 'never'],
+      'use-isnan': 'warn',
+      'valid-typeof': 'warn',
+
+      'no-restricted-properties': [
+        'error',
+        {
+          object: 'require',
+          property: 'ensure',
+          message:
+            'Please use import() instead. More info: https://facebook.github.io/create-react-app/docs/code-splitting',
+        },
+        {
+          object: 'System',
+          property: 'import',
+          message:
+            'Please use import() instead. More info: https://facebook.github.io/create-react-app/docs/code-splitting',
+        },
+      ],
+
+      'getter-return': 'warn',
+
+      // https://github.com/benmosher/eslint-plugin-import/tree/master/docs/rules
+      'import/first': 'error',
+      'import/no-amd': 'error',
+      'import/no-anonymous-default-export': 'warn',
+      'import/no-webpack-loader-syntax': 'error',
+      'import/extensions': [
+        'warn',
+        'never',
+        {
+          json: 'always',
+        },
+      ],
+      'import/no-useless-path-segments': 'warn',
+      'import/no-duplicates': [
+        'warn',
+        {
+          'prefer-inline': true,
+        },
+      ],
+      'import/order': [
+        'warn',
+        {
+          alphabetize: {
+            caseInsensitive: true,
+            order: 'asc',
+          },
+
+          groups: ['builtin', 'external', 'parent', 'sibling', 'index'],
+          'newlines-between': 'always',
+
+          pathGroups: [
+            {
+              // Enforce that React (and react-related packages) is the first import
+              group: 'builtin',
+              pattern: 'react?(-*)',
+              position: 'before',
+            },
+            {
+              // Separate imports from Actual from "real" external imports
+              group: 'external',
+              pattern: 'loot-{core,design}/**/*',
+              position: 'after',
+            },
+          ],
+
+          pathGroupsExcludedImportTypes: ['react'],
+        },
+      ],
+
+      // https://github.com/yannickcr/eslint-plugin-react/tree/master/docs/rules
+      'react/forbid-foreign-prop-types': [
+        'warn',
+        {
+          allowInPropTypes: true,
+        },
+      ],
+      'react/jsx-no-comment-textnodes': 'warn',
+      'react/jsx-no-duplicate-props': 'warn',
+      'react/jsx-no-target-blank': 'warn',
+      'react/jsx-no-undef': 'error',
+      'react/jsx-pascal-case': [
+        'warn',
+        {
+          allowAllCaps: true,
+          ignore: [],
+        },
+      ],
+      'react/no-danger-with-children': 'warn',
+      // Disabled because of undesirable warnings
+      // See https://github.com/facebook/create-react-app/issues/5204 for
+      // blockers until its re-enabled
+      // 'react/no-deprecated': 'warn',
+      'react/no-direct-mutation-state': 'warn',
+      'react/no-is-mounted': 'warn',
+      'react/no-typos': 'error',
+      'react/require-render-return': 'error',
+      'react/style-prop-object': 'warn',
+      'react/jsx-no-useless-fragment': 'warn',
+      'react/self-closing-comp': 'warn',
+      'react/jsx-filename-extension': [
+        'warn',
+        {
+          extensions: ['.jsx', '.tsx'],
+          allow: 'as-needed',
+        },
+      ],
+      'react/no-unstable-nested-components': [
+        'warn',
+        {
+          allowAsProps: true,
+          customValidators: ['formatter'],
+        },
+      ],
+      // Don't need this as we're using TypeScript
+      'react/prop-types': 'off',
+
+      // https://github.com/evcohen/eslint-plugin-jsx-a11y/tree/master/docs/rules
+      'jsx-a11y/alt-text': 'warn',
+      'jsx-a11y/anchor-has-content': 'warn',
+      'jsx-a11y/anchor-is-valid': [
+        'warn',
+        {
+          aspects: ['noHref', 'invalidHref'],
+        },
+      ],
+      'jsx-a11y/aria-activedescendant-has-tabindex': 'warn',
+      'jsx-a11y/aria-props': 'warn',
+      'jsx-a11y/aria-proptypes': 'warn',
+      'jsx-a11y/aria-role': [
+        'warn',
+        {
+          ignoreNonDOM: true,
+        },
+      ],
+      'jsx-a11y/aria-unsupported-elements': 'warn',
+      'jsx-a11y/heading-has-content': 'warn',
+      'jsx-a11y/iframe-has-title': 'warn',
+      'jsx-a11y/img-redundant-alt': 'warn',
+      'jsx-a11y/no-access-key': 'warn',
+      'jsx-a11y/no-distracting-elements': 'warn',
+      'jsx-a11y/no-redundant-roles': 'warn',
+      'jsx-a11y/role-has-required-aria-props': 'warn',
+      'jsx-a11y/role-supports-aria-props': 'warn',
+      'jsx-a11y/scope': 'warn',
+
+      // https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks
+      'react-hooks/rules-of-hooks': 'error',
+      'react-hooks/exhaustive-deps': [
+        'warn',
+        {
+          additionalHooks: '(useQuery)',
+        },
+      ],
+
+      'rulesdir/typography': 'warn',
+      'rulesdir/prefer-if-statement': 'warn',
+
+      // Note: base rule explicitly disabled in favor of the TS one
+      'no-unused-vars': 'off',
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        {
+          varsIgnorePattern: '^(_|React)',
+          ignoreRestSiblings: true,
+          caughtErrors: 'none',
+        },
+      ],
+
+      'no-restricted-globals': ['warn', ...confusingBrowserGlobals],
+
+      // https://github.com/eslint/eslint/issues/16954
+      // https://github.com/eslint/eslint/issues/16953
+      'no-loop-func': 'off',
+
+      // TODO: re-enable these rules
+      'react/react-in-jsx-scope': 'off',
+      'no-var': 'warn',
+      'react/jsx-curly-brace-presence': 'warn',
+      'object-shorthand': ['warn', 'properties'],
+
+      'no-restricted-syntax': [
+        'warn',
+        {
+          // forbid React.* as they are legacy https://twitter.com/dan_abramov/status/1308739731551858689
+          selector:
+            ":matches(MemberExpression[object.name='React'], TSQualifiedName[left.name='React'])",
+          message:
+            'Using default React import is discouraged, please use named exports directly instead.',
+        },
+        {
+          // forbid <a> in favor of <Link>
+          selector: 'JSXOpeningElement[name.name="a"]',
+          message: 'Using <a> is discouraged, please use <Link> instead.',
+        },
+      ],
+
+      'no-restricted-imports': [
+        'warn',
+        {
+          patterns: [
+            {
+              group: ['*.api', '*.web', '*.electron'],
+              message: "Don't directly reference imports from other platforms",
+            },
+            {
+              group: ['uuid'],
+              importNames: ['*'],
+              message: "Use `import { v4 as uuidv4 } from 'uuid'` instead",
+            },
+            {
+              group: ['**/style', '**/colors'],
+              importNames: ['colors'],
+              message: 'Please use themes instead of colors',
+            },
+          ],
+        },
+      ],
+
+      '@typescript-eslint/ban-ts-comment': [
+        'error',
+        {
+          'ts-ignore': 'allow-with-description',
+        },
+      ],
+
+      // Rules disabled during TS migration
+      '@typescript-eslint/no-var-requires': 'off',
+      'prefer-const': 'warn',
+      'prefer-spread': 'off',
+      '@typescript-eslint/no-empty-function': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+      'import/no-default-export': 'warn',
+    },
+  },
+  {
+    files: ['**/*.ts?(x)'],
+
+    languageOptions: {
+      parser: tsParser,
+      ecmaVersion: 2018,
+      sourceType: 'module',
+
+      parserOptions: {
+        project: [path.join(__dirname, './tsconfig.json')],
+        ecmaFeatures: {
+          jsx: true,
+        },
+
+        // typescript-eslint specific options
+        warnOnUnsupportedTypeScriptVersion: true,
+      },
+    },
+
+    // If adding a typescript-eslint version of an existing ESLint rule,
+    // make sure to disable the ESLint rule here.
+    rules: {
+      // TypeScript's `noFallthroughCasesInSwitch` option is more robust (#6906)
+      'default-case': 'off',
+      // 'tsc' already handles this (https://github.com/typescript-eslint/typescript-eslint/issues/291)
+      'no-dupe-class-members': 'off',
+      // 'tsc' already handles this (https://github.com/typescript-eslint/typescript-eslint/issues/477)
+      'no-undef': 'off',
+
+      // Add TypeScript specific rules (and turn off ESLint equivalents)
+      '@typescript-eslint/consistent-type-assertions': 'warn',
+      'no-array-constructor': 'off',
+      '@typescript-eslint/no-array-constructor': 'warn',
+      'no-redeclare': 'off',
+      '@typescript-eslint/no-redeclare': 'warn',
+      'no-use-before-define': 'off',
+
+      '@typescript-eslint/no-use-before-define': [
+        'warn',
+        {
+          functions: false,
+          classes: false,
+          variables: false,
+          typedefs: false,
+        },
+      ],
+
+      'no-unused-expressions': 'off',
+
+      '@typescript-eslint/no-unused-expressions': [
+        'error',
+        {
+          allowShortCircuit: true,
+          allowTernary: true,
+          allowTaggedTemplates: true,
+        },
+      ],
+
+      'no-useless-constructor': 'off',
+      '@typescript-eslint/no-useless-constructor': 'warn',
+    },
+  },
+  {
+    files: [
+      'packages/desktop-client/**/*.{ts,tsx}',
+      'packages/loot-core/src/client/**/*.{ts,tsx}',
+    ],
+
+    rules: {
+      // enforce type over interface
+      '@typescript-eslint/consistent-type-definitions': ['warn', 'type'],
+
+      // enforce import type
+      '@typescript-eslint/consistent-type-imports': [
+        'warn',
+        {
+          prefer: 'type-imports',
+          fixStyle: 'inline-type-imports',
+        },
+      ],
+
+      '@typescript-eslint/no-restricted-types': [
+        'warn',
+        {
+          types: {
+            // forbid FC as superflous
+            FunctionComponent: {
+              message:
+                'Type the props argument and let TS infer or use ComponentType for a component prop',
+            },
+
+            FC: {
+              message:
+                'Type the props argument and let TS infer or use ComponentType for a component prop',
+            },
+          },
+        },
+      ],
+    },
+  },
+  {
+    files: ['packages/desktop-client/**/*'],
+    ignores: ['packages/desktop-client/src/hooks/useNavigate.{ts,tsx}'],
+
+    rules: {
+      'no-restricted-imports': [
+        'warn',
+        {
+          paths: [
+            {
+              name: 'react-router-dom',
+              importNames: ['useNavigate'],
+              message:
+                "Please import Actual's useNavigate() hook from `src/hooks` instead.",
+            },
+          ],
+        },
+      ],
+    },
+  },
+  {
+    files: ['packages/desktop-client/**/*', 'packages/loot-core/**/*'],
+    ignores: ['packages/desktop-client/src/redux/index.{ts,tsx}'],
+
+    rules: {
+      'no-restricted-imports': [
+        'warn',
+        {
+          paths: [
+            {
+              name: 'react-redux',
+              importNames: ['useDispatch'],
+              message:
+                "Please import Actual's useDispatch() hook from `src/redux` instead.",
+            },
+            {
+              name: 'react-redux',
+              importNames: ['useSelector'],
+              message:
+                "Please import Actual's useSelector() hook from `src/redux` instead.",
+            },
+          ],
+        },
+      ],
+    },
+  },
+  {
+    files: ['packages/loot-core/src/**/*'],
+
+    rules: {
+      'no-restricted-imports': [
+        'warn',
+        {
+          patterns: [
+            {
+              group: ['*.api', '*.web', '*.electron'],
+              message: "Don't directly reference imports from other platforms",
+            },
+            {
+              group: ['uuid'],
+              importNames: ['*'],
+              message: "Use `import { v4 as uuidv4 } from 'uuid'` instead",
+            },
+            {
+              group: ['loot-core/**'],
+              message:
+                'Please use relative imports in loot-core instead of importing from `loot-core/*`',
+            },
+          ],
+        },
+      ],
+    },
+  },
+  {
+    files: [
+      'packages/loot-core/src/types/**/*',
+      'packages/loot-core/src/client/state-types/**/*',
+      '**/icons/**/*',
+      '**/{mocks,__mocks__}/**/*',
+      // can't correctly resolve usages
+      '**/*.{testing,electron,browser,web,api}.ts',
+    ],
+
+    rules: {
+      'import/no-unused-modules': 'off',
+    },
+  },
+  {
+    files: [
+      'packages/desktop-client/src/style/index.*',
+      'packages/desktop-client/src/style/palette.*',
+    ],
+
+    rules: {
+      'no-restricted-imports': [
+        'off',
+        {
+          patterns: [
+            {
+              group: ['**/style', '**/colors'],
+              importNames: ['colors'],
+              message: 'Please use themes instead of colors',
+            },
+          ],
+        },
+      ],
+    },
+  },
+  {
+    files: ['packages/api/migrations/*', 'packages/loot-core/migrations/*'],
+
+    rules: {
+      'import/no-default-export': 'off',
+    },
+  },
+  {},
+  {
+    // TODO: fix the issues in these files
+    files: [
+      'packages/desktop-client/src/components/accounts/Account.jsx',
+      'packages/desktop-client/src/components/accounts/MobileAccount.jsx',
+      'packages/desktop-client/src/components/accounts/MobileAccounts.jsx',
+      'packages/desktop-client/src/components/App.tsx',
+      'packages/desktop-client/src/components/budget/BudgetCategories.jsx',
+      'packages/desktop-client/src/components/budget/BudgetSummaries.tsx',
+      'packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx',
+      'packages/desktop-client/src/components/budget/index.tsx',
+      'packages/desktop-client/src/components/budget/MobileBudget.tsx',
+      'packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx',
+      'packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx',
+      'packages/desktop-client/src/components/common/Menu.tsx',
+      'packages/desktop-client/src/components/FinancesApp.tsx',
+      'packages/desktop-client/src/components/GlobalKeys.ts',
+      'packages/desktop-client/src/components/LoggedInUser.tsx',
+      'packages/desktop-client/src/components/manager/ManagementApp.jsx',
+      'packages/desktop-client/src/components/manager/subscribe/common.tsx',
+      'packages/desktop-client/src/components/ManageRules.tsx',
+      'packages/desktop-client/src/components/mobile/MobileAmountInput.jsx',
+      'packages/desktop-client/src/components/mobile/MobileNavTabs.tsx',
+      'packages/desktop-client/src/components/Modals.tsx',
+      'packages/desktop-client/src/components/modals/EditRule.jsx',
+      'packages/desktop-client/src/components/modals/ImportTransactions.jsx',
+      'packages/desktop-client/src/components/modals/MergeUnusedPayees.jsx',
+      'packages/desktop-client/src/components/Notifications.tsx',
+      'packages/desktop-client/src/components/payees/ManagePayees.jsx',
+      'packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx',
+      'packages/desktop-client/src/components/payees/PayeeTable.tsx',
+      'packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx',
+      'packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx',
+      'packages/desktop-client/src/components/reports/reports/CashFlowCard.jsx',
+      'packages/desktop-client/src/components/reports/reports/CustomReport.jsx',
+      'packages/desktop-client/src/components/reports/reports/NetWorthCard.jsx',
+      'packages/desktop-client/src/components/reports/SaveReportName.tsx',
+      'packages/desktop-client/src/components/reports/useReport.ts',
+      'packages/desktop-client/src/components/schedules/ScheduleDetails.jsx',
+      'packages/desktop-client/src/components/schedules/SchedulesTable.tsx',
+      'packages/desktop-client/src/components/select/DateSelect.tsx',
+      'packages/desktop-client/src/components/sidebar/Tools.tsx',
+      'packages/desktop-client/src/components/sort.tsx',
+      'packages/desktop-client/src/components/spreadsheet/useSheetValue.ts',
+      'packages/desktop-client/src/components/table.tsx',
+      'packages/desktop-client/src/components/Titlebar.tsx',
+      'packages/desktop-client/src/components/transactions/MobileTransaction.jsx',
+      'packages/desktop-client/src/components/transactions/SelectedTransactions.jsx',
+      'packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx',
+      'packages/desktop-client/src/components/transactions/TransactionList.jsx',
+      'packages/desktop-client/src/components/transactions/TransactionsTable.jsx',
+      'packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx',
+      'packages/desktop-client/src/hooks/useAccounts.ts',
+      'packages/desktop-client/src/hooks/useCategories.ts',
+      'packages/desktop-client/src/hooks/usePayees.ts',
+      'packages/desktop-client/src/hooks/useProperFocus.tsx',
+      'packages/desktop-client/src/hooks/useSelected.tsx',
+      'packages/loot-core/src/client/query-hooks.tsx',
+    ],
+
+    rules: {
+      'react-hooks/exhaustive-deps': 'off',
+    },
+  },
+  {
+    files: [
+      'eslint.config.mjs',
+      '**/*.test.js',
+      '**/*.test.ts',
+      '**/*.test.jsx',
+      '**/*.test.tsx',
+    ],
+
+    rules: {
+      'rulesdir/typography': 'off',
+    },
+  },
+];

package.json

@@ -38,33 +38,33 @@
     "vrt:docker": "./bin/run-vrt",
     "rebuild-electron": "./node_modules/.bin/electron-rebuild -f -m ./packages/loot-core",
     "rebuild-node": "yarn workspace loot-core rebuild",
-    "lint": "eslint . --max-warnings 0 --ext .js,.jsx,.ts,.tsx",
+    "lint": "eslint . --max-warnings 0",
     "lint:verbose": "DEBUG=eslint:cli-engine eslint . --max-warnings 0",
     "typecheck": "yarn tsc && tsc-strict",
     "jq": "./node_modules/node-jq/bin/jq",
     "prepare": "husky"
   },
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^8.1.0",
-    "@typescript-eslint/parser": "^8.1.0",
-    "confusing-browser-globals": "^1.0.11",
+    "@typescript-eslint/parser": "^8.18.1",
     "cross-env": "^7.0.3",
-    "eslint": "^8.57.0",
+    "eslint": "^9.17.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "3.6.1",
-    "eslint-plugin-import": "2.29.1",
-    "eslint-plugin-jsx-a11y": "^6.9.0",
+    "eslint-import-resolver-typescript": "^3.7.0",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-jsx-a11y": "^6.10.2",
     "eslint-plugin-prettier": "5.2.1",
-    "eslint-plugin-react": "7.35.0",
-    "eslint-plugin-react-hooks": "^4.6.2",
+    "eslint-plugin-react": "^7.37.2",
+    "eslint-plugin-react-hooks": "^5.1.0",
     "eslint-plugin-rulesdir": "^0.2.2",
+    "globals": "^15.13.0",
     "husky": "^9.0.11",
     "lint-staged": "^15.2.9",
     "node-jq": "^4.0.1",
     "npm-run-all": "^4.1.5",
-    "prettier": "3.3.3",
+    "prettier": "^3.4.2",
     "source-map-support": "^0.5.21",
     "typescript": "^5.5.4",
+    "typescript-eslint": "^8.18.1",
     "typescript-strict-plugin": "^2.4.4"
   },
   "resolutions": {

packages/api/methods.ts

@@ -86,7 +86,10 @@ export function addTransactions(
 }
 
 export function importTransactions(accountId, transactions) {
-  return send('api/transactions-import', { accountId, transactions });
+  return send('api/transactions-import', {
+    accountId,
+    transactions,
+  });
 }
 
 export function getTransactions(accountId, startDate, endDate) {

packages/api/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@actual-app/api",
-  "version": "24.11.0",
+  "version": "25.1.0",
   "license": "MIT",
   "description": "An API for Actual",
   "engines": {
@@ -23,7 +23,7 @@
   },
   "dependencies": {
     "@actual-app/crdt": "workspace:^",
-    "better-sqlite3": "^9.6.0",
+    "better-sqlite3": "^11.7.0",
     "compare-versions": "^6.1.0",
     "node-fetch": "^3.3.2",
     "uuid": "^9.0.1"

packages/desktop-client/.gitignore

@@ -25,3 +25,6 @@ public/kcab
 public/data
 public/data-file-index.txt
 public/*.wasm
+
+# translations
+locale/

packages/desktop-client/e2e/accounts.test.js

@@ -54,17 +54,17 @@ test.describe('Accounts', () => {
     await expect(page).toMatchThemeScreenshots();
   });
 
-  test.describe('Budgeted Accounts', () => {
+  test.describe('On Budget Accounts', () => {
     // Reset filters
     test.afterEach(async () => {
       await accountPage.removeFilter(0);
     });
 
     test('creates a transfer from two existing transactions', async () => {
-      accountPage = await navigation.goToAccountPage('For budget');
+      accountPage = await navigation.goToAccountPage('On budget');
       await accountPage.waitFor();
 
-      await expect(accountPage.accountName).toHaveText('Budgeted Accounts');
+      await expect(accountPage.accountName).toHaveText('On Budget Accounts');
 
       await accountPage.filterByNote('Test Acc Transfer');
 

packages/desktop-client/e2e/budget.mobile.test.js

@@ -1,5 +1,6 @@
 import { test, expect } from '@playwright/test';
-import * as monthUtils from 'loot-core-shared/months';
+
+import * as monthUtils from 'loot-core/src/shared/months';
 
 import { ConfigurationPage } from './page-models/configuration-page';
 import { MobileNavigation } from './page-models/mobile-navigation';

packages/desktop-client/e2e/budget.test.js

@@ -27,12 +27,12 @@ test.describe('Budget', () => {
   test('renders the summary information: available funds, overspent, budgeted and for next month', async () => {
     const summary = budgetPage.budgetSummary.first();
 
-    await expect(summary.getByText('Available Funds')).toBeVisible({
+    await expect(summary.getByText('Available funds')).toBeVisible({
       timeout: 10000,
     });
     await expect(summary.getByText(/^Overspent in /)).toBeVisible();
     await expect(summary.getByText('Budgeted')).toBeVisible();
-    await expect(summary.getByText('For Next Month')).toBeVisible();
+    await expect(summary.getByText('For next month')).toBeVisible();
     await expect(page).toMatchThemeScreenshots();
   });
 

packages/desktop-client/e2e/page-models/mobile-budget-page.js

@@ -34,7 +34,7 @@ export class MobileBudgetPage {
       name: 'Saved',
     });
     this.projectedSavingsButton = this.budgetTableHeader.getByRole('button', {
-      name: 'Projected Savings',
+      name: 'Projected savings',
     });
     this.overspentButton = this.budgetTableHeader.getByRole('button', {
       name: 'Overspent',
@@ -294,7 +294,7 @@ export class MobileBudgetPage {
     }
 
     throw new Error(
-      'None of “Saved”, “Projected Savings”, or “Overspent” buttons could be located on the page',
+      'None of “Saved”, “Projected savings”, or “Overspent” buttons could be located on the page',
     );
   }
 

packages/desktop-client/e2e/page-models/mobile-navigation.js

@@ -1,3 +1,4 @@
+import { MobileAccountPage } from './mobile-account-page';
 import { MobileAccountsPage } from './mobile-accounts-page';
 import { MobileBudgetPage } from './mobile-budget-page';
 import { MobileTransactionEntryPage } from './mobile-transaction-entry-page';
@@ -22,6 +23,13 @@ export class MobileNavigation {
     return new MobileAccountsPage(this.page);
   }
 
+  async goToUncategorizedPage() {
+    const button = this.page.getByRole('button', { name: /uncategorized/ });
+    await button.click();
+
+    return new MobileAccountPage(this.page);
+  }
+
   async goToTransactionEntryPage() {
     const link = this.page.getByRole('link', { name: 'Transaction' });
     await link.click();

packages/desktop-client/e2e/page-models/navigation.js

@@ -58,7 +58,7 @@ export class Navigation {
   async createAccount(data) {
     await this.page.getByRole('button', { name: 'Add account' }).click();
     await this.page
-      .getByRole('button', { name: 'Create local account' })
+      .getByRole('button', { name: 'Create a local account' })
       .click();
 
     // Fill the form
@@ -66,7 +66,7 @@ export class Navigation {
     await this.page.getByLabel('Balance:').fill(String(data.balance));
 
     if (data.offBudget) {
-      await this.page.getByLabel('Off-budget').click();
+      await this.page.getByLabel('Off budget').click();
     }
 
     await this.page