Fix icon hover effect in transaction table (#4070)

* Fix icon hover effect in transaction table

* Add release notes

* Add test
This commit is contained in:
Julian Dominguez-Schatz
2025-01-02 11:45:59 -05:00
committed by GitHub
parent 1e65939147
commit be5bfa275e
12 changed files with 42 additions and 28 deletions

View File

@@ -58,6 +58,10 @@ test.describe('Schedules', () => {
await expect(transaction.debit).toHaveText('25.00');
await expect(transaction.credit).toHaveText('');
const icon = transaction.payee.getByTestId('schedule-icon');
await icon.hover();
await expect(page).toMatchThemeScreenshots();
// go to rules page
const rulesPage = await navigation.goToRulesPage();
await rulesPage.searchFor('Home Depot');

Binary file not shown.

Before

Width:  |  Height:  |  Size: 109 KiB

After

Width:  |  Height:  |  Size: 79 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 109 KiB

After

Width:  |  Height:  |  Size: 79 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 109 KiB

After

Width:  |  Height:  |  Size: 78 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 78 KiB

After

Width:  |  Height:  |  Size: 107 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 79 KiB

After

Width:  |  Height:  |  Size: 106 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 78 KiB

After

Width:  |  Height:  |  Size: 106 KiB

View File

@@ -699,40 +699,42 @@ function PayeeCell({
);
return (
<div
style={{
overflow: 'hidden',
textOverflow: 'ellipsis',
display: 'flex',
alignItems: 'center',
}}
>
<>
<PayeeIcons
transaction={transaction}
transferAccount={transferAccount}
onNavigateToTransferAccount={onNavigateToTransferAccount}
onNavigateToSchedule={onNavigateToSchedule}
/>
{importedPayee ? (
<Tooltip
content={
<View style={{ padding: 10 }}>
<Text style={{ fontWeight: 'bold' }}>Imported Payee</Text>
<Text style={{ fontWeight: 'normal' }}>
{importedPayee}
</Text>
</View>
}
style={{ ...styles.tooltip, borderRadius: '0px 5px 5px 0px' }}
placement="bottom"
triggerProps={{ delay: 750 }}
>
{payeeName}
</Tooltip>
) : (
payeeName
)}
</div>
<div
style={{
overflow: 'hidden',
textOverflow: 'ellipsis',
display: 'flex',
alignItems: 'center',
}}
>
{importedPayee ? (
<Tooltip
content={
<View style={{ padding: 10 }}>
<Text style={{ fontWeight: 'bold' }}>Imported Payee</Text>
<Text style={{ fontWeight: 'normal' }}>
{importedPayee}
</Text>
</View>
}
style={{ ...styles.tooltip, borderRadius: '0px 5px 5px 0px' }}
placement="bottom"
triggerProps={{ delay: 750 }}
>
{payeeName}
</Tooltip>
) : (
payeeName
)}
</div>
</>
);
}}
>
@@ -804,6 +806,7 @@ function PayeeIcons({
{schedule && (
<Button
variant="bare"
data-testid="schedule-icon"
aria-label="See schedule details"
style={payeeIconButtonStyle}
onPress={() => {
@@ -820,6 +823,7 @@ function PayeeIcons({
{transferAccount && (
<Button
variant="bare"
data-testid="transfer-icon"
aria-label="See transfer account"
style={payeeIconButtonStyle}
onPress={() => {

View File

@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [jfdoming]
---
Fix regression in hover effect for icons